* [PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node
@ 2014-06-12 8:23 Jaewon Kim
2014-06-12 9:21 ` Sachin Kamat
0 siblings, 1 reply; 2+ messages in thread
From: Jaewon Kim @ 2014-06-12 8:23 UTC (permalink / raw)
To: Ben Dooks, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, linux-arm-kernel,
linux-samsung-soc, devicetree
Cc: myungjoo.ham, cw00.choi, Jaewon Kim
pwm-cells should be 3. Third cell is optional PWM flags.
And This flag supported by this binding is PWM_POLARITY_INVERTED
Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
arch/arm/boot/dts/exynos4.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8ece4b..b687e53 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -548,13 +548,13 @@
status = "disabled";
};
- pwm@139D0000 {
+ pwm: pwm@139D0000 {
compatible = "samsung,exynos4210-pwm";
reg = <0x139D0000 0x1000>;
interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
clocks = <&clock CLK_PWM>;
clock-names = "timers";
- #pwm-cells = <2>;
+ #pwm-cells = <3>;
status = "disabled";
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node
2014-06-12 8:23 [PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node Jaewon Kim
@ 2014-06-12 9:21 ` Sachin Kamat
0 siblings, 0 replies; 2+ messages in thread
From: Sachin Kamat @ 2014-06-12 9:21 UTC (permalink / raw)
To: Jaewon Kim
Cc: Ben Dooks, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King,
linux-arm-kernel@lists.infradead.org, linux-samsung-soc,
devicetree, myungjoo.ham, cw00.choi, Sachin Kamat
Hi Jaewon,
On Thu, Jun 12, 2014 at 1:53 PM, Jaewon Kim <jaewon02.kim@samsung.com> wrote:
> pwm-cells should be 3. Third cell is optional PWM flags.
> And This flag supported by this binding is PWM_POLARITY_INVERTED
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index b8ece4b..b687e53 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -548,13 +548,13 @@
> status = "disabled";
> };
>
> - pwm@139D0000 {
> + pwm: pwm@139D0000 {
unrelated change.
> compatible = "samsung,exynos4210-pwm";
> reg = <0x139D0000 0x1000>;
> interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
> clocks = <&clock CLK_PWM>;
> clock-names = "timers";
> - #pwm-cells = <2>;
> + #pwm-cells = <3>;
> status = "disabled";
> };
Otherwise looks good.
Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>
Regards,
Sachin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-12 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-12 8:23 [PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node Jaewon Kim
2014-06-12 9:21 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).