From: Sricharan R <r.sricharan@ti.com>
To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: nm@ti.com, linux@arm.linux.org.uk, jason@lakedaemon.net,
	tony@atomide.com, rnayak@ti.com, r.sricharan@ti.com,
	santosh.shilimkar@ti.com, tglx@linutronix.de
Subject: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar
Date: Thu, 12 Jun 2014 17:23:11 +0530	[thread overview]
Message-ID: <1402574007-13987-4-git-send-email-r.sricharan@ti.com> (raw)
In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com>
From: Nishanth Menon <nm@ti.com>
When, in the system due to varied reasons, interrupts might be unusable
due to hardware behavior, but register maps do exist, then those interrupts
should be skipped while mapping irq to crossbars.
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 drivers/irqchip/irq-crossbar.c |   47 ++++++++++++++++++++++++++++++++++++----
 1 file changed, 43 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 51d4b87..847f6e3 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -13,11 +13,13 @@
 #include <linux/io.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
+#include <linux/of_device.h>
 #include <linux/slab.h>
 #include <linux/irqchip/arm-gic.h>
 
 #define IRQ_FREE	-1
 #define IRQ_RESERVED	-2
+#define IRQ_SKIP	-3
 #define GIC_IRQ_START	32
 
 /*
@@ -34,6 +36,16 @@ struct crossbar_device {
 	void (*write) (int, int);
 };
 
+/**
+ * struct crossbar_data: Platform specific data
+ * @irqs_unused: array of irqs that cannot be used because of hw erratas
+ * @size: size of the irqs_unused array
+ */
+struct crossbar_data {
+	const uint *irqs_unused;
+	const uint size;
+};
+
 static struct crossbar_device *cb;
 
 static inline void crossbar_writel(int irq_no, int cb_no)
@@ -119,10 +131,12 @@ const struct irq_domain_ops routable_irq_domain_ops = {
 	.xlate = crossbar_domain_xlate
 };
 
-static int __init crossbar_of_init(struct device_node *node)
+static int __init crossbar_of_init(struct device_node *node,
+				   const struct crossbar_data *data)
 {
 	int i, size, max, reserved = 0, entry;
 	const __be32 *irqsr;
+	const int *irqsk = NULL;
 
 	cb = kzalloc(sizeof(*cb), GFP_KERNEL);
 
@@ -194,6 +208,22 @@ static int __init crossbar_of_init(struct device_node *node)
 		reserved += size;
 	}
 
+	/* Skip the ones marked as unused */
+	if (data) {
+		irqsk = data->irqs_unused;
+		size = data->size;
+
+		for (i = 0; i < size; i++) {
+			entry = irqsk[i];
+
+			if (entry > max) {
+				pr_err("Invalid skip entry\n");
+				goto err3;
+			}
+			cb->irq_map[entry] = IRQ_SKIP;
+		}
+	}
+
 	register_routable_domain_ops(&routable_irq_domain_ops);
 	return 0;
 
@@ -208,18 +238,27 @@ err1:
 	return -ENOMEM;
 }
 
+/* irq number 10 cannot be used because of hw bug */
+int dra_irqs_unused[] = { 10 };
+struct crossbar_data cb_dra_data = { dra_irqs_unused,
+				     ARRAY_SIZE(dra_irqs_unused) };
+
 static const struct of_device_id crossbar_match[] __initconst = {
-	{ .compatible = "ti,irq-crossbar" },
+	{ .compatible = "ti,irq-crossbar", .data = &cb_dra_data },
 	{}
 };
 
 int __init irqcrossbar_init(void)
 {
 	struct device_node *np;
-	np = of_find_matching_node(NULL, crossbar_match);
+	const struct of_device_id *of_id;
+	const struct crossbar_data *cdata;
+
+	np = of_find_matching_node_and_match(NULL, crossbar_match, &of_id);
 	if (!np)
 		return -ENODEV;
 
-	crossbar_of_init(np);
+	cdata = of_id->data;
+	crossbar_of_init(np, cdata);
 	return 0;
 }
-- 
1.7.9.5
next prev parent reply	other threads:[~2014-06-12 11:53 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 11:53 [PATCH V2 00/19] irqchip: crossbar: driver fixes Sricharan R
2014-06-12 11:53 ` [PATCH V2 01/19] irqchip: crossbar: dont use '0' to mark reserved interrupts Sricharan R
2014-06-12 11:53 ` [PATCH V2 02/19] irqchip: crossbar: check for premapped crossbar before allocating Sricharan R
2014-06-12 11:53 ` Sricharan R [this message]
2014-06-12 12:51   ` [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar Jason Cooper
     [not found]     ` <20140612125134.GS8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-12 13:19       ` Sricharan R
     [not found]         ` <5399A8D5.6070105-l0cyMroinI0@public.gmane.org>
2014-06-12 14:07           ` Jason Cooper
     [not found]             ` <20140612140729.GD8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-13  6:37               ` Sricharan R
2014-06-13 13:34                 ` Jason Cooper
2014-06-12 13:57     ` Tony Lindgren
2014-06-12 14:05       ` Jason Cooper
2014-06-13  6:56         ` Sricharan R
     [not found]           ` <539AA08A.7010001-l0cyMroinI0@public.gmane.org>
2014-06-13 11:04             ` Sricharan R
2014-06-13 13:10           ` Jason Cooper
     [not found]             ` <20140613131005.GF8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-13 13:35               ` Santosh Shilimkar
2014-06-13 13:41                 ` Jason Cooper
2014-06-13  6:31       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value Sricharan R
2014-06-12 11:53 ` [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs Sricharan R
     [not found]   ` <1402574007-13987-6-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 12:56     ` Jason Cooper
2014-06-13  6:09       ` Sricharan R
     [not found]         ` <539A95A3.1010301-l0cyMroinI0@public.gmane.org>
2014-06-13 13:13           ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 06/19] irqchip: crossbar: remove IS_ERR_VALUE check Sricharan R
2014-06-12 11:53 ` [PATCH V2 07/19] irqchip: crossbar: fix sparse warnings Sricharan R
2014-06-12 11:53 ` [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning Sricharan R
     [not found]   ` <1402574007-13987-9-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:10     ` Jason Cooper
     [not found]       ` <20140612131042.GU8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-12 13:35         ` Sricharan R
     [not found]           ` <5399AC9C.4080602-l0cyMroinI0@public.gmane.org>
2014-06-12 14:18             ` Joe Perches
2014-06-12 15:32               ` Jason Cooper
     [not found]                 ` <20140612153226.GE8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-12 16:05                   ` Joe Perches
2014-06-13  6:30                     ` Sricharan R
     [not found]                       ` <539A9A87.6020004-l0cyMroinI0@public.gmane.org>
2014-06-13 13:15                         ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning Sricharan R
     [not found]   ` <1402574007-13987-10-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:14     ` Jason Cooper
2014-06-12 13:39       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list Sricharan R
     [not found]   ` <1402574007-13987-11-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:16     ` Jason Cooper
2014-06-12 13:21       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 11/19] irqchip: crossbar: fix memory leak incase of invalid entry Sricharan R
     [not found]   ` <1402574007-13987-12-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:20     ` Jason Cooper
2014-06-12 13:37       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 12/19] irqchip: crossbar: return proper error value Sricharan R
2014-06-12 13:39   ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 13/19] irqchip: crossbar: change the goto naming Sricharan R
     [not found]   ` <1402574007-13987-14-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:41     ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 14/19] irqchip: crossbar: set cb pointer to null in case of error Sricharan R
2014-06-12 11:53 ` [PATCH V2 15/19] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback Sricharan R
2014-06-12 13:49   ` Jason Cooper
2014-06-12 13:50     ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping Sricharan R
     [not found]   ` <1402574007-13987-17-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:54     ` Jason Cooper
2014-06-13 10:54       ` Sricharan R
2014-06-13 13:17         ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 17/19] irqchip: crossbar: introduce centralized check for crossbar write Sricharan R
2014-06-12 11:53 ` [PATCH V2 18/19] Documentation: dt: OMAP: crossbar: add description for interrupt consumer Sricharan R
2014-06-12 11:53 ` [PATCH V2 19/19] irqchip: crossbar allow for quirky hardware with direct hardwiring of GIC Sricharan R
     [not found] ` <1402574007-13987-1-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-13 15:01   ` [PATCH V2 00/19] irqchip: crossbar: driver fixes Jason Cooper
2014-06-13 16:14     ` Joe Perches
2014-06-13 16:37       ` Jason Cooper
2014-06-13 16:48         ` Joe Perches
2014-06-13 16:54           ` Jason Cooper
2014-06-13 20:38             ` Thomas Gleixner
2014-06-13 22:22               ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=1402574007-13987-4-git-send-email-r.sricharan@ti.com \
    --to=r.sricharan@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nm@ti.com \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).