devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: George Cherian <george.cherian@ti.com>
To: cw00.choi@samsung.com, myungjoo.ham@samsung.com,
	grant.likely@linaro.org, rdunlap@infradead.org,
	galak@codeaurora.org, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, robh+dt@kernel.org,
	pawel.moll@arm.com, linux@roeck-us.net
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	devicetree@vger.kernel.org, george.cherian@ti.com
Subject: [PATCH 2/2] extcon: gpio: Add dt support for the driver.
Date: Tue, 17 Jun 2014 09:28:20 +0530	[thread overview]
Message-ID: <1402977500-19987-3-git-send-email-george.cherian@ti.com> (raw)
In-Reply-To: <1402977500-19987-1-git-send-email-george.cherian@ti.com>

Add device tree support to extcon-gpio driver.
Add devicetree binding documentation

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 .../devicetree/bindings/extcon/extcon-gpio.txt     | 34 ++++++++++++++++++++++
 drivers/extcon/extcon-gpio.c                       | 29 ++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-gpio.txt

diff --git a/Documentation/devicetree/bindings/extcon/extcon-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
new file mode 100644
index 0000000..80b791b
--- /dev/null
+++ b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
@@ -0,0 +1,34 @@
+GPIO based EXTCON
+
+EXTCON GPIO
+-----------
+
+Required Properties:
+ - compatible: should be:
+   * "ti,extcon-gpio"
+ - gpios: specifies the gpio pin used.
+ - debounce: Debounce time for GPIO IRQ in ms
+ - irq-flags: IRQ flag to be used ( eg: IRQ_TYPE_EDGE_FALLING)
+
+Optional Properties:
+ - gpio-active-low: Property describing whether gpio active state is 1 or 0
+		    If defined , low state of gpio means active.
+ - check-on-resume: Property describing whether to check the gpio state
+		    while resuming from SLEEP.
+ - state-on: print_state is overriden with state_on string if provided.
+	     If NULL, default method of extcon class is used.
+ - state_off: print_state is overriden with state_off string  if provided.
+	      If NUll, default method of extcon class is used.
+
+Eg:
+
+        extcon1: am43_usbid_extcon1 {
+                compatible = "ti,extcon-gpio";
+                gpios = <&gpio3 12 GPIO_ACTIVE_HIGH>;
+                gpio-active-low;
+                debounce = <20>;
+                irq-flags = <IRQ_TYPE_EDGE_FALLING>;
+                state-on = "USB ID FLOAT";
+                state-off = "USB ID GND";
+
+        };
diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
index 6c268b4..14d999d 100644
--- a/drivers/extcon/extcon-gpio.c
+++ b/drivers/extcon/extcon-gpio.c
@@ -27,6 +27,7 @@
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/of_gpio.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/workqueue.h>
@@ -83,12 +84,34 @@ static ssize_t extcon_gpio_print_state(struct extcon_dev *edev, char *buf)
 
 static int gpio_extcon_probe(struct platform_device *pdev)
 {
+	struct device_node *np = pdev->dev.of_node;
 	struct gpio_extcon_platform_data *pdata = dev_get_platdata(&pdev->dev);
 	struct gpio_extcon_data *extcon_data;
 	int ret;
 
+	if (np) {
+		pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
+		if (!pdata)
+			return -ENOMEM;
+
+		pdata->gpio = of_get_gpio(np, 0);
+		if (!gpio_is_valid(pdata->gpio))
+			return -EPROBE_DEFER;
+
+		pdata->name = np->name;
+		pdata->gpio_active_low = of_property_read_bool(np,
+						"gpio-active-low");
+		pdata->check_on_resume = of_property_read_bool(np,
+						"check-on-resume");
+		of_property_read_u32(np, "debounce", (u32 *)&pdata->debounce);
+		of_property_read_u32(np, "irq-flags", (u32 *)&pdata->irq_flags);
+		of_property_read_string(np, "state-on", &pdata->state_on);
+		of_property_read_string(np, "state-off", &pdata->state_off);
+	}
+
 	if (!pdata)
 		return -EBUSY;
+
 	if (!pdata->irq_flags) {
 		dev_err(&pdev->dev, "IRQ flag is not specified.\n");
 		return -EINVAL;
@@ -177,6 +200,11 @@ static int gpio_extcon_resume(struct device *dev)
 
 static SIMPLE_DEV_PM_OPS(gpio_extcon_pm_ops, NULL, gpio_extcon_resume);
 
+static struct of_device_id of_extcon_gpio_match_tbl[] = {
+	{ .compatible = "ti,extcon-gpio", },
+	{ /* end */ }
+};
+
 static struct platform_driver gpio_extcon_driver = {
 	.probe		= gpio_extcon_probe,
 	.remove		= gpio_extcon_remove,
@@ -184,6 +212,7 @@ static struct platform_driver gpio_extcon_driver = {
 		.name	= "extcon-gpio",
 		.owner	= THIS_MODULE,
 		.pm	= &gpio_extcon_pm_ops,
+		.of_match_table = of_extcon_gpio_match_tbl,
 	},
 };
 
-- 
1.8.3.1

  parent reply	other threads:[~2014-06-17  3:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17  3:58 [PATCH 0/2] Add devicetree support for extcon-gpio George Cherian
2014-06-17  3:58 ` [PATCH 1/2] extcon: gpio: Minor cleanups George Cherian
2014-06-17  3:58 ` George Cherian [this message]
2014-06-17 15:57   ` [PATCH 2/2] extcon: gpio: Add dt support for the driver Mark Rutland
2014-06-19  3:30     ` George Cherian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402977500-19987-3-git-send-email-george.cherian@ti.com \
    --to=george.cherian@ti.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).