From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E2BE29CB5B for ; Fri, 18 Jul 2025 10:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752834073; cv=none; b=QUpILowkZX3PLXm6Chr3PJmDC4EK655VtSOpVOhT/znokfWLAozTR5qbczBkJ/BqQ801dauknAmDZTTrYjEdhhRbivPXhlaGehfqztvGCa00y9JCum5D97uTrcZAiDUsx0bJiWX2X1oyWWY+Tcf2XO+zj+rxYJIDmMQ5g4fn808= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752834073; c=relaxed/simple; bh=g0MCGJ7YaYbAjDt3WhSX/LOOkU6F6Pxo7BkKvNMJkvo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Nl0N86wXKM391/9eHAoLQQtkQI7vi1ZfMSdKdry281bcMsGyu+DqtcryWE8txSqV1DFOP1bh2N/vux6Q/1NMlChjXhis8zkg+qkQX4R/8Iw1O6qIgfSk8TItTe/eRzvEl4GM+27IBzdUv3ianLPQyFHMBmI84rWKIIYMWIoey7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=J/wWWskB; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J/wWWskB" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3b49ffbb31bso1155768f8f.3 for ; Fri, 18 Jul 2025 03:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752834070; x=1753438870; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0OAIcBL70630f3jMfmSHdEwCAV/8PODlKAUzq5Lxgf4=; b=J/wWWskBzPKPx1yaR7a+bWgJi8A/MIVn7ItK7/YQCis1Xz+EY+YQKZAX0kgMHw/OKO jERX7ACjBL0auwz409G0hE/JClq/5/Y8kMUCPU9B5e2E54eXhyXGrXwBfvWoZpoYPfhy +YPW/szg4MpecksdbkFdvkKAmZ5GMYYMuVlA4FGplKVfPmg46y4NC2Vr0AlJGn5H9JqJ l9Da2T7Xv8UjiNlf9gGKhTausYqcspHyHCZWNnRKShJlg4MyaW+m07P6H/HZzwmOxCgc w7DMVzmRNhYzA7NGZMIdtFEsElqijKyHldkztsn1vLf+DIdvpi580AObPJRJt/0RY/4v ir0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752834070; x=1753438870; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0OAIcBL70630f3jMfmSHdEwCAV/8PODlKAUzq5Lxgf4=; b=WFO5ghnVZov6DMeCQe1hL2Q3hMldL5NC+3mCeONVs4nhvnOCPz5mvwJKJq1KWd4iVb LL8m0SqDyUfKxnwBpQrbURXzCC2hjBcjHNdK9yi3vKVrRMyy9hrNxbUO3EnMvjqLQorv rxpcmQuHh3zqA9lKI7fImLCnBwXhaJlm9YkQRnhLd6LUGTbCwFdqSCdaHIdFPNk4N2wz avDjRjlMuTNy2GD4hNt+O2qRAP1vg93GccspciK2mzH/URvfMWrErgKJXyt4PaDz3lBi K9ZJSIDbW3ur54HKLIFbTgAr6EEWl27dCJ2PMxEUXJFHg70ZbiUCoftCrCRy115BWFhX Q/sw== X-Forwarded-Encrypted: i=1; AJvYcCUw4BpdVbIsvQIKIYuhwTI9iS2XfU+SxgQJiOdchDXjFDbC8ahvYI4BRUZ2TzR1gHDmf8JVLgxNflu4@vger.kernel.org X-Gm-Message-State: AOJu0YxTD8/8NSPQ+Sp5ssFjebdPkreztORq8uKG6TssT97AlVU1LQgk 0dtfKf9byYpu0GNLHvMQ5oL9xHawMGyzOrXP4zzw+v+la1+YU8DvpEtmd8EU6D2SBsk= X-Gm-Gg: ASbGnctHYoqYS+ZOXMeFYJutf+uRMf8djO7JIvkGwKzWO5mpxHFj7AXduqAUaWhN4i7 NFU+rNoYfoB0agc/8iC+B0lx6163Zr2s5Otrd27xWw3qslMd0NaQxtTYVUvxmRPRHKmp0X5tOHI H30+SApqzCqhc84VuYdTMalswPhqMLSd9F++kNVl/aY/wVrPa9+b9vohvTwHbr+R2YwnlWUMRQ3 Pke3KQD3NL9uPqoAti6nj9Gv/W8z2yx/V/6/SL5To0pKxfgVAm7cqsUDLnasyWg9BIKQB1Z7sM7 sagccYRDubgHFr0HL0P47Y9tZ1nukf9FGPQMUacPXeVYKBvRnDdrS8zBN0Z95dNzCZ3g/wM6dhb 4hMj5zvEaKWJBZgzRcriRwAlA+JZ8Ee+wlc1BPPFz2skPZUEwdGqAj8bJecNN7NSBNlkNjikxq/ Q= X-Google-Smtp-Source: AGHT+IFb4UrEaIgReWQNYtGNnuAGOrUAMETqNaFcLfwK/JPQUJ9ADxpbWpnghscMDuTHhPHpfNW4tw== X-Received: by 2002:a05:6000:26c9:b0:3a5:3b03:3bc6 with SMTP id ffacd0b85a97d-3b613e983bemr5609226f8f.28.1752834069708; Fri, 18 Jul 2025 03:21:09 -0700 (PDT) Received: from [192.168.0.34] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca2b945sm1427254f8f.22.2025.07.18.03.21.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 03:21:09 -0700 (PDT) Message-ID: <1402a52f-639c-4872-a153-b549603c13a7@linaro.org> Date: Fri, 18 Jul 2025 11:21:07 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/7] media: dt-bindings: venus: Add qcm2290 dt schema To: Krzysztof Kozlowski , Konrad Dybcio , Jorge Ramirez Cc: quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, krzk+dt@kernel.org, konradybcio@kernel.org, mchehab@kernel.org, andersson@kernel.org, conor+dt@kernel.org, amit.kucheria@oss.qualcomm.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250715204749.2189875-1-jorge.ramirez@oss.qualcomm.com> <20250715204749.2189875-2-jorge.ramirez@oss.qualcomm.com> <8a63f517-a443-48e4-9b9c-0c4b362f59f8@linaro.org> <0bb2867a-393b-46f9-ad6f-1aeee5a3a9d4@kernel.org> <5afbaf46-bbb1-47d8-84aa-29b18987564f@kernel.org> <18d013e5-352e-457b-ba96-3dd19f1cbaed@oss.qualcomm.com> <56d4e911-5bec-458e-acd1-3594a6d8b91d@kernel.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <56d4e911-5bec-458e-acd1-3594a6d8b91d@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18/07/2025 11:04, Krzysztof Kozlowski wrote: > On 18/07/2025 12:02, Konrad Dybcio wrote: >> On 7/18/25 8:27 AM, Krzysztof Kozlowski wrote: >>> On 17/07/2025 19:00, Jorge Ramirez wrote: >>>> On 17/07/25 13:16:31, Jorge Ramirez wrote: >>>> Not sure if I’ve shared this before, but following an internal >>>> discussion, I think it’s worth highlighting a functional dependency in >>>> the current kernel: >>>> >>>> - the driver only works if the first two IOMMUs in the list — the >>>> non-secure ones — are placed at the beginning. Reordering them breaks >>>> functionality, which introduces unexpected fragility. >>>> >>>> Regardless, this seems like a valid concern to me — a driver shouldn't >>>> rely on the order of phandles — and I just wanted to make sure you're >>>> aware of it before I post a v8 (likely sometime next week or the >>>> following, as I’ll be taking a short break soon). >>> >>> >>> Hm? Order of lists is strictly defined. That's actually an overlook that >>> we never do it for iommus, but the core rule stays. >> >> (FWIW "items:" is an ordered list, "enum:" is unordered) > > enum is not a list, but enumeration, meaning one item of multiple values. > > Best regards, > Krzysztof As Krzysztof says the ordering is strict. I think the right-thing-to-do is to document in the commit log the dependency. The final three entries are secure entries and the ordering is important. --- bod