devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: nm@ti.com, linux@arm.linux.org.uk, jason@lakedaemon.net,
	tony@atomide.com, rnayak@ti.com, r.sricharan@ti.com,
	santosh.shilimkar@ti.com, joe@perches.com, tglx@linutronix.de
Subject: [PATCH V4 02/16] irqchip: crossbar: Check for premapped crossbar before allocating
Date: Thu, 26 Jun 2014 12:40:20 +0530	[thread overview]
Message-ID: <1403766634-18543-3-git-send-email-r.sricharan@ti.com> (raw)
In-Reply-To: <1403766634-18543-1-git-send-email-r.sricharan@ti.com>

From: Nishanth Menon <nm@ti.com>

If irq_of_parse_and_map is executed twice, the same crossbar is mapped to two
different GIC interrupts. This is completely undesirable. Instead, check
if the requested crossbar event is pre-allocated and provide that GIC
mapping back to caller if already allocated.

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 drivers/irqchip/irq-crossbar.c |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 20105bc..51d4b87 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -51,6 +51,17 @@ static inline void crossbar_writeb(int irq_no, int cb_no)
 	writeb(cb_no, cb->crossbar_base + cb->register_offsets[irq_no]);
 }
 
+static inline int get_prev_map_irq(int cb_no)
+{
+	int i;
+
+	for (i = 0; i < cb->int_max; i++)
+		if (cb->irq_map[i] == cb_no)
+			return i;
+
+	return -ENODEV;
+}
+
 static inline int allocate_free_irq(int cb_no)
 {
 	int i;
@@ -88,11 +99,16 @@ static int crossbar_domain_xlate(struct irq_domain *d,
 {
 	unsigned long ret;
 
+	ret = get_prev_map_irq(intspec[1]);
+	if (!IS_ERR_VALUE(ret))
+		goto found;
+
 	ret = allocate_free_irq(intspec[1]);
 
 	if (IS_ERR_VALUE(ret))
 		return ret;
 
+found:
 	*out_hwirq = ret + GIC_IRQ_START;
 	return 0;
 }
-- 
1.7.9.5

  parent reply	other threads:[~2014-06-26  7:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26  7:10 [PATCH V4 00/16] irqchip: crossbar: Driver fixes Sricharan R
2014-06-26  7:10 ` [PATCH V4 01/16] irqchip: crossbar: Dont use '0' to mark reserved interrupts Sricharan R
2014-06-26  7:10 ` Sricharan R [this message]
2014-06-26  7:10 ` [PATCH V4 04/16] irqchip: crossbar: Initialise the crossbar with a safe value Sricharan R
2014-06-26  7:10 ` [PATCH V4 05/16] irqchip: crossbar: Change allocation logic by reversing search for free irqs Sricharan R
2014-06-26  7:10 ` [PATCH V4 06/16] irqchip: crossbar: Remove IS_ERR_VALUE check Sricharan R
2014-06-26  7:10 ` [PATCH V4 07/16] irqchip: crossbar: Fix sparse and checkpatch warnings Sricharan R
2014-06-26  7:10 ` [PATCH V4 08/16] irqchip: crossbar: Fix kerneldoc warning Sricharan R
2014-06-26  7:10 ` [PATCH V4 09/16] irqchip: crossbar: Return proper error value Sricharan R
     [not found] ` <1403766634-18543-1-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-26  7:10   ` [PATCH V4 03/16] irqchip: crossbar: Introduce ti,irqs-skip to skip irqs that bypass crossbar Sricharan R
2014-06-26  7:10   ` [PATCH V4 10/16] irqchip: crossbar: Change the goto naming Sricharan R
2014-06-26  7:42   ` [PATCH V4 00/16] irqchip: crossbar: Driver fixes Tony Lindgren
     [not found]     ` <20140626074209.GE28884-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-06-27 12:01       ` Jason Cooper
2014-06-26  7:10 ` [PATCH V4 11/16] irqchip: crossbar: Set cb pointer to null in case of error Sricharan R
2014-06-26  7:10 ` [PATCH V4 12/16] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback Sricharan R
2014-06-26  7:10 ` [PATCH V4 13/16] irqchip: crossbar: Introduce ti,max-crossbar-sources to identify valid crossbar mapping Sricharan R
     [not found]   ` <1403766634-18543-14-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-27 12:00     ` Jason Cooper
2014-06-30 19:30       ` Jason Cooper
2014-06-26  7:10 ` [PATCH V4 14/16] irqchip: crossbar: Introduce centralized check for crossbar write Sricharan R
2014-06-26  7:10 ` [PATCH V4 15/16] documentation: dt: omap: crossbar: Add description for interrupt consumer Sricharan R
     [not found]   ` <1403766634-18543-16-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-27 11:57     ` Jason Cooper
2014-06-26  7:10 ` [PATCH V4 16/16] irqchip: crossbar: Allow for quirky hardware with direct hardwiring of GIC Sricharan R
2014-06-30 19:29 ` [PATCH V4 00/16] irqchip: crossbar: Driver fixes Jason Cooper
2014-07-01  7:59   ` Tony Lindgren
2014-07-01  9:36     ` Sricharan R
2014-07-01 12:23       ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403766634-18543-3-git-send-email-r.sricharan@ti.com \
    --to=r.sricharan@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=joe@perches.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nm@ti.com \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).