* [PATCH] thermal: ti-soc-thermal: ti-bandgap.c: Cleaning up wrong address is checked
@ 2014-06-02 21:25 Rickard Strandqvist
2014-07-01 1:54 ` Zhang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-06-02 21:25 UTC (permalink / raw)
To: Eduardo Valentin, Zhang Rui
Cc: Rickard Strandqvist, Grant Likely, Rob Herring, linux-pm,
linux-kernel, devicetree
Wrong address is checked after memory allocation.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
index 3ab12ee..43c0f83 100644
--- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
+++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
@@ -1155,7 +1155,7 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
/* register shadow for context save and restore */
bgp->regval = devm_kzalloc(&pdev->dev, sizeof(*bgp->regval) *
bgp->conf->sensor_count, GFP_KERNEL);
- if (!bgp) {
+ if (!bgp->regval) {
dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
return ERR_PTR(-ENOMEM);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] thermal: ti-soc-thermal: ti-bandgap.c: Cleaning up wrong address is checked
2014-06-02 21:25 [PATCH] thermal: ti-soc-thermal: ti-bandgap.c: Cleaning up wrong address is checked Rickard Strandqvist
@ 2014-07-01 1:54 ` Zhang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Zhang Rui @ 2014-07-01 1:54 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Eduardo Valentin, Grant Likely, Rob Herring, linux-pm,
linux-kernel, devicetree
On Mon, 2014-06-02 at 23:25 +0200, Rickard Strandqvist wrote:
> Wrong address is checked after memory allocation.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
applied, thanks.
-rui
> ---
> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index 3ab12ee..43c0f83 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -1155,7 +1155,7 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
> /* register shadow for context save and restore */
> bgp->regval = devm_kzalloc(&pdev->dev, sizeof(*bgp->regval) *
> bgp->conf->sensor_count, GFP_KERNEL);
> - if (!bgp) {
> + if (!bgp->regval) {
> dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
> return ERR_PTR(-ENOMEM);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-01 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-02 21:25 [PATCH] thermal: ti-soc-thermal: ti-bandgap.c: Cleaning up wrong address is checked Rickard Strandqvist
2014-07-01 1:54 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).