From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document Date: Fri, 04 Jul 2014 10:13:17 +0200 Message-ID: <1404461597.21830.2.camel@AMDC1943> References: <1404198121-22989-1-git-send-email-k.kozlowski@samsung.com> <1404198121-22989-6-git-send-email-k.kozlowski@samsung.com> <20140703113236.GA28504@leverpostej> <1404387874.21377.8.camel@AMDC1943> <20140704080702.GA31812@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <20140704080702.GA31812@leverpostej> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland Cc: Dmitry Eremin-Solenikov , David Woodhouse , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Samuel Ortiz , Lee Jones , Liam Girdwood , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Tomasz Figa , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On pi=C4=85, 2014-07-04 at 09:07 +0100, Mark Rutland wrote: > On Thu, Jul 03, 2014 at 12:44:34PM +0100, Krzysztof Kozlowski wrote: > > On czw, 2014-07-03 at 12:32 +0100, Mark Rutland wrote: > > > Hi, > > >=20 > > > On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wro= te: > > > > Add document describing device tree bindings for MAX14577 MFD > > > > drivers: MFD core, extcon, regulator and charger. > > > >=20 > > > > Both MAX14577 and MAX77836 chipsets are documented. > > > >=20 > > > > Signed-off-by: Krzysztof Kozlowski > > > > Cc: Kyungmin Park > > > > Cc: Tomasz Figa > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > > > Cc: Rob Herring > > > > Cc: Pawel Moll > > > > Cc: Mark Rutland > > > > Cc: Ian Campbell > > > > Cc: Kumar Gala > > > > Reviewed-by: Tomasz Figa > > > > --- > > > > Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++= ++++++++++++++++ > > > > 1 file changed, 152 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/mfd/max14= 577.txt > > > >=20 > > > > diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt= b/Documentation/devicetree/bindings/mfd/max14577.txt > > > > new file mode 100644 > > > > index 000000000000..b235250a7b41 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mfd/max14577.txt > > > > @@ -0,0 +1,152 @@ > > > > +Maxim MAX14577/77836 Multi-Function Device > > > > + > > > > +MAX14577 is a Multi-Function Device with Micro-USB Interface C= ircuit, Li+ > > > > +Battery Charger and SFOUT LDO output for powering USB devices.= It is > > > > +interfaced to host controller using I2C. > > > > + > > > > +MAX77836 additionally contains PMIC (with two LDO regulators) = and Fuel Gauge. > > > > + > > > > + > > > > +Required properties: > > > > +- compatible : Must be "maxim,max14577" or "maxim,max77836". > > > > +- reg : I2C slave address for the max14577 chip (0x25 for max1= 4577/max77836) > > > > +- interrupts : IRQ line for the chip. > > > > +- interrupt-parent : The parent interrupt controller. > > > > + > > > > + > > > > +Required nodes: > > > > + - charger : > > > > + Node for configuring the charger driver. > > > > + Required properties: > > > > + - compatible : "maxim,max14577-charger" > > > > + or "maxim,max77836-charger" > > > > + - maxim,fast-charge-timer : Timer in hours to trigger the > > > > + INT3/MBCCHGERR interrupt; Valid values: > > > > + - 5, 6 or 7 (hours), > > > > + - 0 to disable. > > >=20 > > > I'm not sure I follow what this is any why it should be in the DT= =2E > > >=20 > > > Could you explain what this is used for? > >=20 > > Hi, > >=20 > > These are settings for max14577 battery charger. Actually this > > particular setting does not look like board-specific but other (lik= e > > battery voltage) do. > >=20 > > The timer above is used by device to stop charging and to trigger > > interrupt. >=20 > Ok. What I don't get is why this should be in the DT, it sounds like = a > configuration option that would better be set at run time. I understand. I'll add this as sysfs entry and re-spin with version 3 o= f patchset. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html