From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Lee Jones <lee.jones@linaro.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Mike Turquette <mturquette@linaro.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
devicetree@vger.kernel.org,
Yadwinder Singh Brar <yadi.brar01@gmail.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Doug Anderson <dianders@chromium.org>,
Tushar Behera <trblinux@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Olof Johansson <olof@lixom.net>,
Andreas Farber <afaerber@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 10/13] rtc: max77686: Allow the max77686 rtc to wakeup the system
Date: Mon, 14 Jul 2014 13:36:06 +0200 [thread overview]
Message-ID: <1405337769-3741-11-git-send-email-javier.martinez@collabora.co.uk> (raw)
In-Reply-To: <1405337769-3741-1-git-send-email-javier.martinez@collabora.co.uk>
From: Doug Anderson <dianders@chromium.org>
The max77686 includes an RTC that keeps power during suspend. It's
convenient to be able to use it as a wakeup source.
NOTE: due to wakeup ordering problems this patch alone doesn't work so
well on exynos5250-snow. You also need something that brings the i2c
bus up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
Changes since v6: None
Changes since v5:
- Fix $SUBJECT since the patch does not actually touch the mfd subsys.
Suggested by Lee Jones.
Changes since v4: None
Changes since v3:
- Keep the note that this patch needs another change due wakeup
ordering problems.
---
drivers/rtc/rtc-max77686.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index d20a7f0..c1c6055 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -583,6 +583,33 @@ static void max77686_rtc_shutdown(struct platform_device *pdev)
#endif /* MAX77686_RTC_WTSR_SMPL */
}
+#ifdef CONFIG_PM_SLEEP
+static int max77686_rtc_suspend(struct device *dev)
+{
+ if (device_may_wakeup(dev)) {
+ struct max77686_rtc_info *info = dev_get_drvdata(dev);
+
+ return enable_irq_wake(info->virq);
+ }
+
+ return 0;
+}
+
+static int max77686_rtc_resume(struct device *dev)
+{
+ if (device_may_wakeup(dev)) {
+ struct max77686_rtc_info *info = dev_get_drvdata(dev);
+
+ return disable_irq_wake(info->virq);
+ }
+
+ return 0;
+}
+#endif
+
+static SIMPLE_DEV_PM_OPS(max77686_rtc_pm_ops,
+ max77686_rtc_suspend, max77686_rtc_resume);
+
static const struct platform_device_id rtc_id[] = {
{ "max77686-rtc", 0 },
{},
@@ -592,6 +619,7 @@ static struct platform_driver max77686_rtc_driver = {
.driver = {
.name = "max77686-rtc",
.owner = THIS_MODULE,
+ .pm = &max77686_rtc_pm_ops,
},
.probe = max77686_rtc_probe,
.shutdown = max77686_rtc_shutdown,
--
2.0.0.rc2
next prev parent reply other threads:[~2014-07-14 11:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 11:35 [PATCH v8 00/13] Add Maxim 77802 PMIC support Javier Martinez Canillas
2014-07-14 11:35 ` [PATCH v8 01/13] mfd: max77686: " Javier Martinez Canillas
2014-07-14 11:35 ` [PATCH v8 02/13] mfd: max77802: Add DT binding documentation Javier Martinez Canillas
2014-07-14 11:35 ` [PATCH v8 03/13] regulator: Add driver for Maxim 77802 PMIC regulators Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 04/13] clk: max77686: Add DT include for MAX77686 PMIC clock Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 05/13] clk: Add generic driver for Maxim PMIC clocks Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 06/13] clk: max77686: Convert to the generic max clock driver Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 07/13] clk: max77686: Improve Maxim 77686 PMIC clocks binding Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 08/13] clk: Add driver for Maxim 77802 PMIC clocks Javier Martinez Canillas
2014-07-14 11:36 ` Javier Martinez Canillas [this message]
2014-07-14 11:36 ` [PATCH v8 11/13] rtc: max77686: Remove dead code for SMPL and WTSR Javier Martinez Canillas
[not found] ` <1405337769-3741-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-07-14 11:36 ` [PATCH v8 09/13] clk: max77802: Add DT binding documentation Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 12/13] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 13/13] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi Javier Martinez Canillas
2014-07-21 12:44 ` [PATCH v8 00/13] Add Maxim 77802 PMIC support Javier Martinez Canillas
2014-07-22 0:10 ` Mark Brown
2014-07-22 0:46 ` Javier Martinez Canillas
2014-07-25 22:31 ` Mike Turquette
2014-07-28 9:29 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405337769-3741-11-git-send-email-javier.martinez@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=a.zummo@towertech.it \
--cc=afaerber@suse.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=tomeu.vizoso@collabora.com \
--cc=trblinux@gmail.com \
--cc=yadi.brar01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).