From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Lee Jones <lee.jones@linaro.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Mike Turquette <mturquette@linaro.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
devicetree@vger.kernel.org,
Yadwinder Singh Brar <yadi.brar01@gmail.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Doug Anderson <dianders@chromium.org>,
Tushar Behera <trblinux@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Olof Johansson <olof@lixom.net>,
Andreas Farber <afaerber@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 07/13] clk: max77686: Improve Maxim 77686 PMIC clocks binding
Date: Mon, 14 Jul 2014 13:36:03 +0200 [thread overview]
Message-ID: <1405337769-3741-8-git-send-email-javier.martinez@collabora.co.uk> (raw)
In-Reply-To: <1405337769-3741-1-git-send-email-javier.martinez@collabora.co.uk>
Like most clock drivers, the Maxim 77686 PMIC clock binding
follows the convention that the "#clock-cells" property is
used to specify the number of cells in a clock provider.
But the binding document is not clear enough that it shall
be set to 1 since the PMIC support multiple clocks outputs.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Finally, add "clock-output-names" as an optional property
since now is supported by the clock driver.
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Mike Turquette <mturquette@linaro.org>
---
Changes since v6: None
Changes since v5:
- Fix generic driver changes merged into max77802 clock patch by mistake.
Suggested by Yadwinder Singh Brar.
- Register clock lookups using clk_register_clkdev() instead of doing manually.
- Use the managed devm_clk_register() function and remove clk un-registration.
- Add "clock-output-names" property support. Suggested by Yadwinder Singh Brar.
- Return the rate unconditionally in recalc_rate. Suggested by Mike Turquette.
Changes since v4: None
Changes since v3:
- Don't change clock-names property to make clear that it's
the consumer clock name and should not match the producer clock.
Suggested by Doug Anderson.
---
.../devicetree/bindings/clock/maxim,max77686.txt | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/maxim,max77686.txt b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
index 96ce71b..9c40739 100644
--- a/Documentation/devicetree/bindings/clock/maxim,max77686.txt
+++ b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
@@ -9,13 +9,21 @@ The MAX77686 contains three 32.768khz clock outputs that can be controlled
Following properties should be presend in main device node of the MFD chip.
Required properties:
-- #clock-cells: simple one-cell clock specifier format is used, where the
- only cell is used as an index of the clock inside the provider. Following
- indices are allowed:
+
+- #clock-cells: from common clock binding; shall be set to 1.
+
+Optional properties:
+- clock-output-names: From common clock binding.
+
+Each clock is assigned an identifier and client nodes can use this identifier
+to specify the clock which they consume. Following indices are allowed:
- 0: 32khz_ap clock,
- 1: 32khz_cp clock,
- 2: 32khz_pmic clock.
+Clocks are defined as preprocessor macros in dt-bindings/clock/maxim,max77686.h
+header and can be used in device tree sources.
+
Example: Node of the MFD chip
max77686: max77686@09 {
@@ -34,5 +42,5 @@ Example: Clock consumer node
compatible = "bar,foo";
/* ... */
clock-names = "my-clock";
- clocks = <&max77686 2>;
+ clocks = <&max77686 MAX77686_CLK_PMIC>;
};
--
2.0.0.rc2
next prev parent reply other threads:[~2014-07-14 11:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 11:35 [PATCH v8 00/13] Add Maxim 77802 PMIC support Javier Martinez Canillas
2014-07-14 11:35 ` [PATCH v8 01/13] mfd: max77686: " Javier Martinez Canillas
2014-07-14 11:35 ` [PATCH v8 02/13] mfd: max77802: Add DT binding documentation Javier Martinez Canillas
2014-07-14 11:35 ` [PATCH v8 03/13] regulator: Add driver for Maxim 77802 PMIC regulators Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 04/13] clk: max77686: Add DT include for MAX77686 PMIC clock Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 05/13] clk: Add generic driver for Maxim PMIC clocks Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 06/13] clk: max77686: Convert to the generic max clock driver Javier Martinez Canillas
2014-07-14 11:36 ` Javier Martinez Canillas [this message]
2014-07-14 11:36 ` [PATCH v8 08/13] clk: Add driver for Maxim 77802 PMIC clocks Javier Martinez Canillas
[not found] ` <1405337769-3741-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-07-14 11:36 ` [PATCH v8 09/13] clk: max77802: Add DT binding documentation Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 12/13] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 10/13] rtc: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 11/13] rtc: max77686: Remove dead code for SMPL and WTSR Javier Martinez Canillas
2014-07-14 11:36 ` [PATCH v8 13/13] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi Javier Martinez Canillas
2014-07-21 12:44 ` [PATCH v8 00/13] Add Maxim 77802 PMIC support Javier Martinez Canillas
2014-07-22 0:10 ` Mark Brown
2014-07-22 0:46 ` Javier Martinez Canillas
2014-07-25 22:31 ` Mike Turquette
2014-07-28 9:29 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405337769-3741-8-git-send-email-javier.martinez@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=a.zummo@towertech.it \
--cc=afaerber@suse.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=tomeu.vizoso@collabora.com \
--cc=trblinux@gmail.com \
--cc=yadi.brar01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).