From: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
To: linux-arm-kernel@lists.infradead.org,
spi-devel-general@lists.sourceforge.net,
linux-samsung-soc@vger.kernel.org
Cc: naveenkrishna.ch@gmail.com, broonie@kernel.org,
grant.likely@secretlab.ca, jaswinder.singh@linaro.org,
kgene.kim@samsung.com, cpgs@samsung.com,
devicetree@vger.kernel.org
Subject: [PATCH 0/3] spi: s3c64xx: fix the driver to use "cs-gpios" property
Date: Tue, 15 Jul 2014 17:50:57 +0530 [thread overview]
Message-ID: <1405426860-18404-1-git-send-email-ch.naveen@samsung.com> (raw)
Current SPI core has generic implementation for configuring
the Chip select gpios during .setup() & .cleanup(). By modifying
the spi-s3c64xx.c driver to expect the "cs-gpios" property in SPI
device node instead of the subnode "controller-data".
This way we can avoid parsing the "cs-gpios" in the driver.
This patch set also does the following
1. Validate the "struct s3c64xx_spi_csinfo *cs" object and the
CS gpio for both DT and NON-DT before using them.
2. Correct the dt-bindings for exynos4210-smdkv310.dts, exynos4412-trats2.dts
and exynos5250-smdk5250.dts
3. Updates the DT bindings.
Note:
This patchset is a rework of the changes under review @
http://www.mail-archive.com/devicetree@vger.kernel.org/msg34501.html
Tested on Exynos5420 and Exynos5250 based Peach PIT, PI and Snow boards
respectively using the flashrom utility to access SPI flash.
This patchset is needed by the changes
http://www.gossamer-threads.com/lists/linux/kernel/1951607
Tested-by on boards based on Exynos4, S5P, S3C series SoCs
would be appreciated.
Naveen Krishna Chatradhi (3):
spi: s3c64xx: move property "cs-gpio" from controller_data subnode
to SPI DT node
spi: s3c64xx: validate s3c64xx_spi_csinfo before using
ARM: DTS: fix the chip select gpios definition in the SPI nodes
.../devicetree/bindings/spi/spi-samsung.txt | 10 ++++----
arch/arm/boot/dts/exynos4210-smdkv310.dts | 2 +-
arch/arm/boot/dts/exynos4412-trats2.dts | 2 +-
arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 +-
drivers/spi/spi-s3c64xx.c | 27 +++++++-------------
5 files changed, 17 insertions(+), 26 deletions(-)
--
1.7.9.5
next reply other threads:[~2014-07-15 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 12:20 Naveen Krishna Chatradhi [this message]
2014-07-15 12:20 ` [PATCH 1/3] spi: s3c64xx: move "cs-gpio" from subnode to SPI DT node Naveen Krishna Chatradhi
2014-07-15 17:30 ` Tomasz Figa
2014-07-16 17:09 ` Mark Brown
2014-07-15 12:20 ` [PATCH 2/3] spi: s3c64xx: validate s3c64xx_spi_csinfo before using Naveen Krishna Chatradhi
2014-07-15 17:49 ` Tomasz Figa
2014-07-15 20:00 ` Javier Martinez Canillas
2014-07-15 12:21 ` [PATCH 3/3] ARM: DTS: fix the chip select gpios definition in the SPI nodes Naveen Krishna Chatradhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405426860-18404-1-git-send-email-ch.naveen@samsung.com \
--to=ch.naveen@samsung.com \
--cc=broonie@kernel.org \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=jaswinder.singh@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).