* [PATCH] ARM: dts: DRA7: fix interrupt-cells for GPIO
@ 2014-07-30 19:20 Nishanth Menon
[not found] ` <1406748032-19417-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2014-07-30 19:20 UTC (permalink / raw)
To: tony; +Cc: devicetree, inux-arm-kernel, linux-kernel, linux-omap,
Nishanth Menon
GPIO modules are also interrupt sources. However, they require both the
GPIO number and IRQ type to function properly.
By declaring that GPIO uses interrupt-cells=<1>, we essentially do not
allow users of the nodes to use the interrupt property appropritely.
With this change, the following now works:
interrupt-parent = <&gpio6>;
interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
Fixes: 6e58b8f1daaf ('ARM: dts: DRA7: Add the dts files for dra7 SoC and dra7-evm board')
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Based on v3.16-rc7
arch/arm/boot/dts/dra7.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 8012763..f21ef39 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -172,7 +172,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
};
gpio2: gpio@48055000 {
@@ -183,7 +183,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
};
gpio3: gpio@48057000 {
@@ -194,7 +194,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
};
gpio4: gpio@48059000 {
@@ -205,7 +205,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
};
gpio5: gpio@4805b000 {
@@ -216,7 +216,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
};
gpio6: gpio@4805d000 {
@@ -227,7 +227,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
};
gpio7: gpio@48051000 {
@@ -238,7 +238,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
};
gpio8: gpio@48053000 {
@@ -249,7 +249,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
};
uart1: serial@4806a000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: DRA7: fix interrupt-cells for GPIO
[not found] ` <1406748032-19417-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
@ 2014-08-18 18:46 ` Nishanth Menon
[not found] ` <53F249F3.9070402-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2014-08-18 18:46 UTC (permalink / raw)
To: tony-4v6yS6AI5VpBDgjK7y7TUQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
inux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA
On 07/30/2014 02:20 PM, Nishanth Menon wrote:
> GPIO modules are also interrupt sources. However, they require both the
> GPIO number and IRQ type to function properly.
>
> By declaring that GPIO uses interrupt-cells=<1>, we essentially do not
> allow users of the nodes to use the interrupt property appropritely.
>
> With this change, the following now works:
>
> interrupt-parent = <&gpio6>;
> interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
>
> Fixes: 6e58b8f1daaf ('ARM: dts: DRA7: Add the dts files for dra7 SoC and dra7-evm board')
> Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
> ---
> Based on v3.16-rc7
>
> arch/arm/boot/dts/dra7.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Tony,
Gentle ping. we still have this issue on 3.17-rc1. any suggestions on
if we can pick this up during RC?
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 8012763..f21ef39 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -172,7 +172,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> };
>
> gpio2: gpio@48055000 {
> @@ -183,7 +183,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> };
>
> gpio3: gpio@48057000 {
> @@ -194,7 +194,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> };
>
> gpio4: gpio@48059000 {
> @@ -205,7 +205,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> };
>
> gpio5: gpio@4805b000 {
> @@ -216,7 +216,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> };
>
> gpio6: gpio@4805d000 {
> @@ -227,7 +227,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> };
>
> gpio7: gpio@48051000 {
> @@ -238,7 +238,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> };
>
> gpio8: gpio@48053000 {
> @@ -249,7 +249,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> };
>
> uart1: serial@4806a000 {
>
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: DRA7: fix interrupt-cells for GPIO
[not found] ` <53F249F3.9070402-l0cyMroinI0@public.gmane.org>
@ 2014-08-22 23:02 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2014-08-22 23:02 UTC (permalink / raw)
To: Nishanth Menon
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
inux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA
* Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> [140818 11:49]:
> On 07/30/2014 02:20 PM, Nishanth Menon wrote:
> > GPIO modules are also interrupt sources. However, they require both the
> > GPIO number and IRQ type to function properly.
> >
> > By declaring that GPIO uses interrupt-cells=<1>, we essentially do not
> > allow users of the nodes to use the interrupt property appropritely.
> >
> > With this change, the following now works:
> >
> > interrupt-parent = <&gpio6>;
> > interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
> >
> > Fixes: 6e58b8f1daaf ('ARM: dts: DRA7: Add the dts files for dra7 SoC and dra7-evm board')
> > Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
> > ---
> > Based on v3.16-rc7
> >
> > arch/arm/boot/dts/dra7.dtsi | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
>
> Tony,
> Gentle ping. we still have this issue on 3.17-rc1. any suggestions on
> if we can pick this up during RC?
Yes thanks applying into omap-for-v3.17/fixes.
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-22 23:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-30 19:20 [PATCH] ARM: dts: DRA7: fix interrupt-cells for GPIO Nishanth Menon
[not found] ` <1406748032-19417-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-08-18 18:46 ` Nishanth Menon
[not found] ` <53F249F3.9070402-l0cyMroinI0@public.gmane.org>
2014-08-22 23:02 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).