* [PATCH 1/2] ARM: pxa: dts: fix mmc controller compatible string
@ 2014-08-14 9:46 Daniel Mack
[not found] ` <1408009573-24523-1-git-send-email-zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Mack @ 2014-08-14 9:46 UTC (permalink / raw)
To: haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
grant.likely-QSEj5FYQhm4dnm+yROfE0A,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, arnd-r2nGTMty4D4, Daniel Mack
The vendor prefix was renamed from "mrvl" to "marvell". Follow this
change in the dts file.
Signed-off-by: Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/pxa2xx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi
index febd391..f188f8c 100644
--- a/arch/arm/boot/dts/pxa2xx.dtsi
+++ b/arch/arm/boot/dts/pxa2xx.dtsi
@@ -128,7 +128,7 @@
};
mmc0: mmc@41100000 {
- compatible = "mrvl,pxa-mmc";
+ compatible = "marvell,pxa-mmc";
reg = <0x41100000 0x1000>;
interrupts = <23>;
dmas = <&dma 21
--
2.0.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1408009573-24523-1-git-send-email-zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCH 2/2] ARM: pxa: dts: fix ohci controller compatible string [not found] ` <1408009573-24523-1-git-send-email-zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-08-14 9:46 ` Daniel Mack 2014-08-25 6:53 ` [PATCH 1/2] ARM: pxa: dts: fix mmc " Haojian Zhuang 2014-08-27 22:01 ` Olof Johansson 2 siblings, 0 replies; 5+ messages in thread From: Daniel Mack @ 2014-08-14 9:46 UTC (permalink / raw) To: haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, grant.likely-QSEj5FYQhm4dnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, arnd-r2nGTMty4D4, Daniel Mack The vendor prefix was renamed from "mrvl" to "marvell". Follow this change in the dts file. Signed-off-by: Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- arch/arm/boot/dts/pxa2xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index f188f8c..6d52a72 100644 --- a/arch/arm/boot/dts/pxa2xx.dtsi +++ b/arch/arm/boot/dts/pxa2xx.dtsi @@ -121,7 +121,7 @@ }; usb0: ohci@4c000000 { - compatible = "mrvl,pxa-ohci"; + compatible = "marvell,pxa-ohci"; reg = <0x4c000000 0x10000>; interrupts = <3>; status = "disabled"; -- 2.0.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: pxa: dts: fix mmc controller compatible string [not found] ` <1408009573-24523-1-git-send-email-zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-08-14 9:46 ` [PATCH 2/2] ARM: pxa: dts: fix ohci " Daniel Mack @ 2014-08-25 6:53 ` Haojian Zhuang 2014-08-27 22:01 ` Olof Johansson 2 siblings, 0 replies; 5+ messages in thread From: Haojian Zhuang @ 2014-08-25 6:53 UTC (permalink / raw) To: Daniel Mack Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA, Grant Likely, Rob Herring, Bergmann Arnd On Thu, Aug 14, 2014 at 5:46 PM, Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > The vendor prefix was renamed from "mrvl" to "marvell". Follow this > change in the dts file. > > Signed-off-by: Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > arch/arm/boot/dts/pxa2xx.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi > index febd391..f188f8c 100644 > --- a/arch/arm/boot/dts/pxa2xx.dtsi > +++ b/arch/arm/boot/dts/pxa2xx.dtsi > @@ -128,7 +128,7 @@ > }; > > mmc0: mmc@41100000 { > - compatible = "mrvl,pxa-mmc"; > + compatible = "marvell,pxa-mmc"; > reg = <0x41100000 0x1000>; > interrupts = <23>; > dmas = <&dma 21 > -- > 2.0.4 > Applied these 2 patches. Regards Haojian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: pxa: dts: fix mmc controller compatible string [not found] ` <1408009573-24523-1-git-send-email-zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-08-14 9:46 ` [PATCH 2/2] ARM: pxa: dts: fix ohci " Daniel Mack 2014-08-25 6:53 ` [PATCH 1/2] ARM: pxa: dts: fix mmc " Haojian Zhuang @ 2014-08-27 22:01 ` Olof Johansson [not found] ` <CAOesGMh6sc7U6XRjGWBUPszaD9K66Ek=3xdMyGdh7bEAMXVG4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2 siblings, 1 reply; 5+ messages in thread From: Olof Johansson @ 2014-08-27 22:01 UTC (permalink / raw) To: Daniel Mack Cc: Haojian Zhuang, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Grant Likely, Rob Herring, Arnd Bergmann On Thu, Aug 14, 2014 at 2:46 AM, Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > The vendor prefix was renamed from "mrvl" to "marvell". Follow this > change in the dts file. > > Signed-off-by: Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > arch/arm/boot/dts/pxa2xx.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi > index febd391..f188f8c 100644 > --- a/arch/arm/boot/dts/pxa2xx.dtsi > +++ b/arch/arm/boot/dts/pxa2xx.dtsi > @@ -128,7 +128,7 @@ > }; > > mmc0: mmc@41100000 { > - compatible = "mrvl,pxa-mmc"; > + compatible = "marvell,pxa-mmc"; It seems that the driver was changed without consideration to backwards compatibility. The driver should still handle both the old and the new prefix (since we keep this a stable ABI). The old one should be deprecated but still accepted. I.e. this is an OK change, but it's fine to hold off as a cleanup until 3.18. The driver has a regression though, that needs to be fixed for 3.17. -Olof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CAOesGMh6sc7U6XRjGWBUPszaD9K66Ek=3xdMyGdh7bEAMXVG4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 1/2] ARM: pxa: dts: fix mmc controller compatible string [not found] ` <CAOesGMh6sc7U6XRjGWBUPszaD9K66Ek=3xdMyGdh7bEAMXVG4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-09-06 15:55 ` Daniel Mack 0 siblings, 0 replies; 5+ messages in thread From: Daniel Mack @ 2014-09-06 15:55 UTC (permalink / raw) To: Olof Johansson Cc: Haojian Zhuang, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Grant Likely, Rob Herring, Arnd Bergmann Hi Olof, Sorry for the late reply. On 08/28/2014 12:01 AM, Olof Johansson wrote: > On Thu, Aug 14, 2014 at 2:46 AM, Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: >> The vendor prefix was renamed from "mrvl" to "marvell". Follow this >> change in the dts file. >> >> Signed-off-by: Daniel Mack <zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> --- >> arch/arm/boot/dts/pxa2xx.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi >> index febd391..f188f8c 100644 >> --- a/arch/arm/boot/dts/pxa2xx.dtsi >> +++ b/arch/arm/boot/dts/pxa2xx.dtsi >> @@ -128,7 +128,7 @@ >> }; >> >> mmc0: mmc@41100000 { >> - compatible = "mrvl,pxa-mmc"; >> + compatible = "marvell,pxa-mmc"; > > It seems that the driver was changed without consideration to > backwards compatibility. The driver should still handle both the old > and the new prefix (since we keep this a stable ABI). The old one > should be deprecated but still accepted. > > I.e. this is an OK change, but it's fine to hold off as a cleanup > until 3.18. The driver has a regression though, that needs to be fixed > for 3.17. Hmm, no. The driver never actuall supported that string. It was my bad when I submitted the original version of pxa2xx.dtsi. Still, given that it went unnoticed for so long, it can well wait for 3.18. Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-06 15:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-14 9:46 [PATCH 1/2] ARM: pxa: dts: fix mmc controller compatible string Daniel Mack
[not found] ` <1408009573-24523-1-git-send-email-zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-14 9:46 ` [PATCH 2/2] ARM: pxa: dts: fix ohci " Daniel Mack
2014-08-25 6:53 ` [PATCH 1/2] ARM: pxa: dts: fix mmc " Haojian Zhuang
2014-08-27 22:01 ` Olof Johansson
[not found] ` <CAOesGMh6sc7U6XRjGWBUPszaD9K66Ek=3xdMyGdh7bEAMXVG4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-06 15:55 ` Daniel Mack
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).