From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kevin Hilman <khilman@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Philipp Zabel <philipp.zabel@gmail.com>,
Mark Brown <broonie@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
Chris Ball <chris@printf.net>,
Russell King <linux@arm.linux.org.uk>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: [PATCH 1/9] ACPI / PM: Let acpi_dev_pm_detach() return an error code
Date: Tue, 26 Aug 2014 14:07:09 +0200 [thread overview]
Message-ID: <1409054837-5667-2-git-send-email-ulf.hansson@linaro.org> (raw)
In-Reply-To: <1409054837-5667-1-git-send-email-ulf.hansson@linaro.org>
To give callers the option of acting on a errors while removing the
pm_domain ops for the device in the ACPI power domain, let
acpi_dev_pm_detach() return an int to provide the error code.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/acpi/device_pm.c | 4 ++++
include/linux/acpi.h | 7 +++++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c
index 67075f8..fa78abb 100644
--- a/drivers/acpi/device_pm.c
+++ b/drivers/acpi/device_pm.c
@@ -1087,6 +1087,8 @@ EXPORT_SYMBOL_GPL(acpi_dev_pm_attach);
*
* Callers must ensure proper synchronization of this function with power
* management callbacks.
+ *
+ * Returns 0 on successfully detached power domain or negative error code.
*/
void acpi_dev_pm_detach(struct device *dev, bool power_off)
{
@@ -1107,7 +1109,9 @@ void acpi_dev_pm_detach(struct device *dev, bool power_off)
acpi_device_wakeup(adev, ACPI_STATE_S0, false);
acpi_dev_pm_low_power(dev, adev, ACPI_STATE_S0);
}
+ return 0;
}
+ return -ENODEV;
}
EXPORT_SYMBOL_GPL(acpi_dev_pm_detach);
#endif /* CONFIG_PM */
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 5320153..a7bfdf6 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -576,7 +576,7 @@ static inline int acpi_subsys_freeze(struct device *dev) { return 0; }
#if defined(CONFIG_ACPI) && defined(CONFIG_PM)
struct acpi_device *acpi_dev_pm_get_node(struct device *dev);
int acpi_dev_pm_attach(struct device *dev, bool power_on);
-void acpi_dev_pm_detach(struct device *dev, bool power_off);
+int acpi_dev_pm_detach(struct device *dev, bool power_off);
#else
static inline struct acpi_device *acpi_dev_pm_get_node(struct device *dev)
{
@@ -586,7 +586,10 @@ static inline int acpi_dev_pm_attach(struct device *dev, bool power_on)
{
return -ENODEV;
}
-static inline void acpi_dev_pm_detach(struct device *dev, bool power_off) {}
+static inline int acpi_dev_pm_detach(struct device *dev, bool power_off)
+{
+ return -ENODEV;
+}
#endif
#ifdef CONFIG_ACPI
--
1.9.1
next prev parent reply other threads:[~2014-08-26 12:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 12:07 [PATCH 0/9] PM / Domains: Generic OF-based support Ulf Hansson
2014-08-26 12:07 ` Ulf Hansson [this message]
2014-08-27 0:16 ` [PATCH 1/9] ACPI / PM: Let acpi_dev_pm_detach() return an error code Rafael J. Wysocki
2014-08-27 7:25 ` Ulf Hansson
2014-08-27 5:43 ` Zheng, Lv
2014-08-27 7:26 ` Ulf Hansson
2014-08-26 12:07 ` [PATCH 2/9] PM / Domains: Add generic OF-based power domain look-up Ulf Hansson
2014-08-26 13:15 ` Philipp Zabel
2014-08-26 12:07 ` [PATCH 3/9] PM / Domains: Add APIs to attach/detach a power domain for a device Ulf Hansson
2014-08-27 0:20 ` Rafael J. Wysocki
2014-08-27 7:37 ` Ulf Hansson
2014-08-27 7:38 ` Ulf Hansson
2014-08-26 12:07 ` [PATCH 4/9] drivercore / platform: Convert to dev_pm_domain_attach|detach() Ulf Hansson
[not found] ` <1409054837-5667-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-08-26 12:07 ` [PATCH 5/9] i2c: core: " Ulf Hansson
2014-08-26 12:07 ` [PATCH 6/9] mmc: sdio: " Ulf Hansson
2014-08-26 12:07 ` [PATCH 7/9] spi: core: " Ulf Hansson
2014-08-26 12:07 ` [PATCH 8/9] amba: Add support for attach/detach of power domains Ulf Hansson
2014-08-26 12:07 ` [PATCH 9/9] ARM: exynos: Move to generic power domain bindings Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409054837-5667-2-git-send-email-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=chris@printf.net \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=kgene.kim@samsung.com \
--cc=khilman@linaro.org \
--cc=len.brown@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=pavel@ucw.cz \
--cc=philipp.zabel@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=stern@rowland.harvard.edu \
--cc=tomasz.figa@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).