* [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 @ 2014-08-28 19:36 Doug Anderson 2014-08-28 19:36 ` [PATCH 2/2] soc/rockchip: io-domain: add driver handling io domains Doug Anderson 2014-08-28 21:26 ` [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 Santosh Shilimkar 0 siblings, 2 replies; 8+ messages in thread From: Doug Anderson @ 2014-08-28 19:36 UTC (permalink / raw) To: Mark Brown, Heiko Stuebner, olof-nZhT3qVonbNeoWH0uzbU5w, Arnd Bergmann Cc: Addy Ke, Sonny Rao, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Doug Anderson, mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, swarren-DDmLM1+adcrQT0dZR+AlfA, pawel.moll-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA, agross-sgV2jX0FEOL9JmXXK+q4OQ, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, linux-kernel-u79uwXL29TY76Z2rM5mHXA, santosh.shilimkar-l0cyMroinI0, sandeep_n-l0cyMroinI0, galak-sgV2jX0FEOL9JmXXK+q4OQ, grant.likely-QSEj5FYQhm4dnm+yROfE0A, treding-DDmLM1+adcrQT0dZR+AlfA These two patches add support for automatically configuring the IO voltage domains on rk3188 and rk3288 SoCs. The first patch adds some new notification types to the regulator code. It's used by the second patch which actually implements the IO voltage domain driver. These two patches were co-developed by Heiko Stübner and Doug Anderson (proof of concept patches were written by Heiko). They were tested in a private branch on an rk3288 board using rk808 instead of mainline since rk808 support isn't finalized in mainline yet. (sorry if you got this series twice; my mailer seems unhappy with me) Heiko Stübner (2): regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) soc/rockchip: io-domain: add driver handling io domains .../devicetree/bindings/arm/rockchip/io-domain.txt | 60 ++++ drivers/regulator/core.c | 63 +++- drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/rockchip/Kconfig | 10 + drivers/soc/rockchip/Makefile | 1 + drivers/soc/rockchip/io-domain.c | 333 +++++++++++++++++++++ include/linux/regulator/consumer.h | 20 ++ 8 files changed, 482 insertions(+), 7 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/rockchip/io-domain.txt create mode 100644 drivers/soc/rockchip/Kconfig create mode 100644 drivers/soc/rockchip/Makefile create mode 100644 drivers/soc/rockchip/io-domain.c -- 2.1.0.rc2.206.gedb03e5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] soc/rockchip: io-domain: add driver handling io domains 2014-08-28 19:36 [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 Doug Anderson @ 2014-08-28 19:36 ` Doug Anderson 2014-08-28 21:26 ` [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 Santosh Shilimkar 1 sibling, 0 replies; 8+ messages in thread From: Doug Anderson @ 2014-08-28 19:36 UTC (permalink / raw) To: Mark Brown, Heiko Stuebner, olof, Arnd Bergmann Cc: Addy Ke, Sonny Rao, linux-arm-kernel, Doug Anderson, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, grant.likely, agross, santosh.shilimkar, sandeep_n, treding, swarren, pdeschrijver, devicetree, linux-kernel From: Heiko Stübner <heiko@sntech.de> IO domain voltages on some Rockchip SoCs are variable but need to be kept in sync between the regulators and a special register. Signed-off-by: Heiko Stübner <heiko@sntech.de> Signed-off-by: Doug Anderson <dianders@chromium.org> --- .../devicetree/bindings/arm/rockchip/io-domain.txt | 60 ++++ drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/rockchip/Kconfig | 10 + drivers/soc/rockchip/Makefile | 1 + drivers/soc/rockchip/io-domain.c | 333 +++++++++++++++++++++ 6 files changed, 406 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/rockchip/io-domain.txt create mode 100644 drivers/soc/rockchip/Kconfig create mode 100644 drivers/soc/rockchip/Makefile create mode 100644 drivers/soc/rockchip/io-domain.c diff --git a/Documentation/devicetree/bindings/arm/rockchip/io-domain.txt b/Documentation/devicetree/bindings/arm/rockchip/io-domain.txt new file mode 100644 index 0000000..20b4965 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/rockchip/io-domain.txt @@ -0,0 +1,60 @@ +Rockchip SRAM for IO Voltage Domains: +------------------------------------- + +IO domain voltages on some Rockchip SoCs are variable but need to be +kept in sync between the regulators and a special register. + +We can specify which regulator is associated with which IO Voltage +Domain and then we can automatically adjust the register to match +what's actually being provided on the rails. + +Required properties: +- compatible: should be one of: + - "rockchip,rk3188-iodomain" for rk3188 + - "rockchip,rk3288-iodomain" for rk3288 + +You specify supplies using the standard regulator bindings by including +a phandle the the relevant regulator. All specified supplies must be able +to report their voltage. The IO Voltage Domain for any non-specified +supplies will be not be touched. + +Possible supplies for rk3188: +- ap0-supply: The supply connected to AP0_VCC. +- ap1-supply: The supply connected to AP1_VCC. +- cif-supply: The supply connected to CIF_VCC. +- flash-supply: The supply connected to FLASH_VCC. +- lcdc0-supply: The supply connected to LCD0_VCC. +- lcdc1-supply: The supply connected to LCD1_VCC. +- vccio0-supply: The supply connected to VCCIO0. +- vccio1-supply: The supply connected to VCCIO1. + Sometimes also labeled VCCIO1 and VCCIO2. + +Possible supplies for rk3288: +- audio-supply: The supply connected to APIO4_VDD. +- bb-supply: The supply connected to APIO5_VDD. +- dvp-supply: The supply connected to DVPIO_VDD. +- flash0-supply: The supply connected to FLASH0_VDD. Typically for eMMC +- flash1-supply: The supply connected to FLASH1_VDD. Also known as SDIO1. +- gpio30-supply: The supply connected to APIO1_VDD. +- gpio1830 The supply connected to APIO2_VDD. +- lcdc-supply: The supply connected to LCDC_VDD. +- sdcard-supply: The supply connected to SDMMC0_VDD. +- wifi-supply: The supply connected to APIO3_VDD. Also known as SDIO0. + + +Example: + + io-domains { + compatible = "rockchip,rk3288-iodomain"; + rockchip,grf = <&grf>; + + audio-supply = <&vcc18_codec>; + bb-supply = <&vcc33_io>; + dvp-supply = <&vcc_18>; + flash0-supply = <&vcc18_flashio>; + gpio1830-supply = <&vcc33_io>; + gpio30-supply = <&vcc33_pmuio>; + lcdc-supply = <&vcc33_lcd>; + sdcard-supply = <&vccio_sd>; + wifi-supply = <&vcc18_wl>; + }; diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig index c854385..443d946 100644 --- a/drivers/soc/Kconfig +++ b/drivers/soc/Kconfig @@ -1,5 +1,6 @@ menu "SOC (System On Chip) specific Drivers" source "drivers/soc/qcom/Kconfig" +source "drivers/soc/rockchip/Kconfig" endmenu diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index 3b1b95d..52808bf 100644 --- a/drivers/soc/Makefile +++ b/drivers/soc/Makefile @@ -3,4 +3,5 @@ # obj-$(CONFIG_ARCH_QCOM) += qcom/ +obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ obj-$(CONFIG_ARCH_TEGRA) += tegra/ diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig new file mode 100644 index 0000000..d25cb53 --- /dev/null +++ b/drivers/soc/rockchip/Kconfig @@ -0,0 +1,10 @@ +# +# Rockchip Soc drivers +# +config ROCKCHIP_IODOMAIN + tristate "Rockchip IO domain support" + depends on ARCH_ROCKCHIP && OF + help + Say y here to enable support io domains on Rockchip SoCs. It is + necessary for the io domain setting of the SoC to match the + voltage supplied by the regulators. diff --git a/drivers/soc/rockchip/Makefile b/drivers/soc/rockchip/Makefile new file mode 100644 index 0000000..dbf6da9 --- /dev/null +++ b/drivers/soc/rockchip/Makefile @@ -0,0 +1 @@ +obj-$(CONFIG_ROCKCHIP_IODOMAIN) += io-domain.o diff --git a/drivers/soc/rockchip/io-domain.c b/drivers/soc/rockchip/io-domain.c new file mode 100644 index 0000000..f4e0ebc --- /dev/null +++ b/drivers/soc/rockchip/io-domain.c @@ -0,0 +1,333 @@ +/* + * Rockchip IO Voltage Domain driver + * + * Copyright 2014 MundoReader S.L. + * Copyright 2014 Google, Inc. + * + * This software is licensed under the terms of the GNU General Public + * License version 2, as published by the Free Software Foundation, and + * may be copied, distributed, and modified under those terms. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/err.h> +#include <linux/mfd/syscon.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> +#include <linux/regulator/consumer.h> + +#define MAX_SUPPLIES 16 + +#define MAX_VOLTAGE_1_8 1980000 +#define MAX_VOLTAGE_3_3 3600000 + +struct rockchip_iodomain; + +/** + * @supplies: voltage settings matching the register bits. + */ +struct rockchip_iodomain_soc_data { + int grf_offset; + const char *supply_names[MAX_SUPPLIES]; + void (*init)(struct rockchip_iodomain *iod); +}; + +struct rockchip_iodomain_supply { + struct rockchip_iodomain *iod; + struct regulator *reg; + struct notifier_block nb; + int idx; +}; + +struct rockchip_iodomain { + struct device *dev; + struct regmap *grf; + struct rockchip_iodomain_soc_data *soc_data; + struct rockchip_iodomain_supply supplies[MAX_SUPPLIES]; +}; + +static int rockchip_iodomain_write(struct rockchip_iodomain_supply *supply, + int uV) +{ + struct rockchip_iodomain *iod = supply->iod; + u32 val; + int ret; + + /* set value bit */ + val = (uV > MAX_VOLTAGE_1_8) ? 0 : 1; + val <<= supply->idx; + + /* apply hiword-mask */ + val |= (BIT(supply->idx) << 16); + + ret = regmap_write(iod->grf, iod->soc_data->grf_offset, val); + if (ret) + dev_err(iod->dev, "Couldn't write to GRF\n"); + + return ret; +} + +static int rockchip_iodomain_notify(struct notifier_block *nb, + unsigned long event, + void *data) +{ + struct rockchip_iodomain_supply *supply = + container_of(nb, struct rockchip_iodomain_supply, nb); + int uV; + int ret; + + /* + * According to Rockchip it's important to keep the SoC IO domain + * higher than (or equal to) the external voltage. That means we need + * to change it before external voltage changes happen in the case + * of an increase. + */ + if (event & REGULATOR_EVENT_PRE_VOLTAGE_CHANGE) { + struct pre_voltage_change_data *pvc_data = data; + + uV = max_t(unsigned long, pvc_data->old_uV, pvc_data->max_uV); + } else if (event & (REGULATOR_EVENT_VOLTAGE_CHANGE | + REGULATOR_EVENT_ABORT_VOLTAGE_CHANGE)) { + uV = (unsigned long)data; + } else { + return NOTIFY_OK; + } + + dev_dbg(supply->iod->dev, "Setting to %d\n", uV); + + if (uV > MAX_VOLTAGE_3_3) { + dev_err(supply->iod->dev, "Voltage too high: %d\n", uV); + + if (event == REGULATOR_EVENT_PRE_VOLTAGE_CHANGE) + return NOTIFY_BAD; + } + + ret = rockchip_iodomain_write(supply, uV); + if (ret && event == REGULATOR_EVENT_PRE_VOLTAGE_CHANGE) + return NOTIFY_BAD; + + dev_info(supply->iod->dev, "Setting to %d done\n", uV); + return NOTIFY_OK; +} + +#define RK3288_SOC_CON2 0x24c +#define RK3288_SOC_CON2_FLASH0 BIT(7) +#define RK3288_SOC_FLASH_SUPPLY_NUM 2 + +static void rk3288_iodomain_init(struct rockchip_iodomain *iod) +{ + int ret; + u32 val; + + /* if no flash supply we should leave things alone */ + if (!iod->supplies[RK3288_SOC_FLASH_SUPPLY_NUM].reg) + return; + + /* + * set flash0 iodomain to also use this framework + * instead of a special gpio. + */ + val = RK3288_SOC_CON2_FLASH0 | (RK3288_SOC_CON2_FLASH0 << 16); + ret = regmap_write(iod->grf, RK3288_SOC_CON2, val); + if (ret < 0) + dev_warn(iod->dev, "couldn't update flash0 ctrl\n"); +} + +/* + * On the rk3188 the io-domains are handled by a shared register with the + * lower 8 bits being still being continuing drive-strength settings. + */ +static const struct rockchip_iodomain_soc_data soc_data_rk3188 = { + .grf_offset = 0x104, + .supply_names = { + NULL, + NULL, + NULL, + NULL, + NULL, + NULL, + NULL, + NULL, + "ap0", + "ap1", + "cif", + "flash", + "vccio0", + "vccio1", + "lcdc0", + "lcdc1", + }, +}; + +static const struct rockchip_iodomain_soc_data soc_data_rk3288 = { + .grf_offset = 0x380, + .supply_names = { + "lcdc", /* LCDC_VDD */ + "dvp", /* DVPIO_VDD */ + "flash0", /* FLASH0_VDD (emmc) */ + "flash1", /* FLASH1_VDD (sdio1) */ + "wifi", /* APIO3_VDD (sdio0) */ + "bb", /* APIO5_VDD */ + "audio", /* APIO4_VDD */ + "sdcard", /* SDMMC0_VDD (sdmmc) */ + "gpio30", /* APIO1_VDD */ + "gpio1830", /* APIO2_VDD */ + }, + .init = rk3288_iodomain_init, +}; + +static const struct of_device_id rockchip_iodomain_match[] = { + { + .compatible = "rockchip,rk3188-iodomain", + .data = (void *)&soc_data_rk3188 + }, + { + .compatible = "rockchip,rk3288-iodomain", + .data = (void *)&soc_data_rk3288 + }, + { /* sentinel */ }, +}; + +static int rockchip_iodomain_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev->dev.of_node; + const struct of_device_id *match; + struct rockchip_iodomain *iod; + int i, ret; + + if (!np) + return -ENODEV; + + iod = devm_kzalloc(&pdev->dev, sizeof(*iod), GFP_KERNEL); + if (!iod) + return -ENOMEM; + + iod->dev = &pdev->dev; + platform_set_drvdata(pdev, iod); + + match = of_match_node(rockchip_iodomain_match, np); + iod->soc_data = (struct rockchip_iodomain_soc_data *)match->data; + + iod->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf"); + if (IS_ERR(iod->grf)) { + dev_err(&pdev->dev, "couldn't find grf regmap\n"); + return PTR_ERR(iod->grf); + } + + for (i = 0; i < MAX_SUPPLIES; i++) { + const char *supply_name = iod->soc_data->supply_names[i]; + struct rockchip_iodomain_supply *supply = &iod->supplies[i]; + struct regulator *reg; + int uV; + + if (!supply_name) + continue; + + reg = devm_regulator_get_optional(iod->dev, supply_name); + if (IS_ERR(reg)) { + ret = PTR_ERR(reg); + + /* If a supply wasn't specified, that's OK */ + if (ret == -ENODEV) + continue; + else if (ret != -EPROBE_DEFER) + dev_err(iod->dev, "couldn't get regulator %s\n", + supply_name); + goto unreg_notify; + } + + /* set initial correct value */ + uV = regulator_get_voltage(reg); + + /* must be a regulator we can get the voltage of */ + if (uV < 0) { + dev_err(iod->dev, "Can't determine voltage: %s\n", + supply_name); + goto unreg_notify; + } + + if (uV > MAX_VOLTAGE_3_3) { + dev_crit(iod->dev, + "%d uV is too high. May damage SoC!\n", + uV); + ret = -EINVAL; + goto unreg_notify; + } + + /* setup our supply */ + supply->idx = i; + supply->iod = iod; + supply->reg = reg; + supply->nb.notifier_call = rockchip_iodomain_notify; + + ret = rockchip_iodomain_write(supply, uV); + if (ret) { + supply->reg = NULL; + goto unreg_notify; + } + + /* register regulator notifier */ + ret = regulator_register_notifier(reg, &supply->nb); + if (ret) { + dev_err(&pdev->dev, + "regulator notifier request failed\n"); + supply->reg = NULL; + goto unreg_notify; + } + } + + if (iod->soc_data->init) + iod->soc_data->init(iod); + + return 0; + +unreg_notify: + for (i = MAX_SUPPLIES - 1; i >= 0; i--) { + struct rockchip_iodomain_supply *io_supply = &iod->supplies[i]; + + if (io_supply->reg) + regulator_unregister_notifier(io_supply->reg, + &io_supply->nb); + } + + return ret; +} + +static int rockchip_iodomain_remove(struct platform_device *pdev) +{ + struct rockchip_iodomain *iod = platform_get_drvdata(pdev); + int i; + + for (i = MAX_SUPPLIES - 1; i >= 0; i--) { + struct rockchip_iodomain_supply *io_supply = &iod->supplies[i]; + + if (io_supply->reg) + regulator_unregister_notifier(io_supply->reg, + &io_supply->nb); + } + + return 0; +} + +static struct platform_driver rockchip_iodomain_driver = { + .probe = rockchip_iodomain_probe, + .remove = rockchip_iodomain_remove, + .driver = { + .name = "rockchip-iodomain", + .of_match_table = rockchip_iodomain_match, + }, +}; + +module_platform_driver(rockchip_iodomain_driver); + +MODULE_DESCRIPTION("Rockchip IO-domain driver"); +MODULE_AUTHOR("Heiko Stuebner <heiko@sntech.de>"); +MODULE_AUTHOR("Doug Anderson <dianders@chromium.org>"); +MODULE_LICENSE("GPL v2"); -- 2.1.0.rc2.206.gedb03e5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 2014-08-28 19:36 [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 Doug Anderson 2014-08-28 19:36 ` [PATCH 2/2] soc/rockchip: io-domain: add driver handling io domains Doug Anderson @ 2014-08-28 21:26 ` Santosh Shilimkar 2014-08-30 4:51 ` Doug Anderson 1 sibling, 1 reply; 8+ messages in thread From: Santosh Shilimkar @ 2014-08-28 21:26 UTC (permalink / raw) To: Doug Anderson, Mark Brown, Heiko Stuebner, olof, Arnd Bergmann Cc: mark.rutland, devicetree, Addy Ke, swarren, pawel.moll, ijc+devicetree, Nishanth Menon, pdeschrijver, galak, lgirdwood, linux-kernel, robh+dt, sandeep_n, agross, grant.likely, treding, Sonny Rao, linux-arm-kernel On Thursday 28 August 2014 03:36 PM, Doug Anderson wrote: > These two patches add support for automatically configuring the IO > voltage domains on rk3188 and rk3288 SoCs. The first patch adds some > new notification types to the regulator code. It's used by the second > patch which actually implements the IO voltage domain driver. > > These two patches were co-developed by Heiko Stübner and Doug Anderson > (proof of concept patches were written by Heiko). They were tested in > a private branch on an rk3288 board using rk808 instead of mainline > since rk808 support isn't finalized in mainline yet. > > (sorry if you got this series twice; my mailer seems unhappy with me) > > Heiko Stübner (2): > regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) > soc/rockchip: io-domain: add driver handling io domains > Sorry to shot down but your IO domains are nothing but voltage domains and you should really build something in the drivers/power/* Please have a look at the RFC [1]. You should really go on those lines and collaborate to make a generic voltage domain layer instead of throwing the driver under drivers/soc. > .../devicetree/bindings/arm/rockchip/io-domain.txt | 60 ++++ > drivers/regulator/core.c | 63 +++- > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/rockchip/Kconfig | 10 + > drivers/soc/rockchip/Makefile | 1 + > drivers/soc/rockchip/io-domain.c | 333 +++++++++++++++++++++ > include/linux/regulator/consumer.h | 20 ++ > 8 files changed, 482 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/rockchip/io-domain.txt > create mode 100644 drivers/soc/rockchip/Kconfig > create mode 100644 drivers/soc/rockchip/Makefile > create mode 100644 drivers/soc/rockchip/io-domain.c > Regards, Santosh [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/233819.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 2014-08-28 21:26 ` [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 Santosh Shilimkar @ 2014-08-30 4:51 ` Doug Anderson [not found] ` <CAD=FV=Vcj+tAno92c38Prviyi-v2CmuGSzak1ppETL033KAF4w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: Doug Anderson @ 2014-08-30 4:51 UTC (permalink / raw) To: Santosh Shilimkar Cc: Mark Brown, Heiko Stuebner, Olof Johansson, Arnd Bergmann, Addy Ke, Sonny Rao, linux-arm-kernel@lists.infradead.org, Mark Rutland, devicetree@vger.kernel.org, Stephen Warren, Pawel Moll, Ian Campbell, Peter De Schrijver, agross, Liam Girdwood, Rob Herring, linux-kernel@vger.kernel.org, sandeep_n, Kumar Gala, Grant Likely, Thierry Reding, Nishanth Menon, Linus Walleij <linus.wal> Santosh, On Thu, Aug 28, 2014 at 2:26 PM, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote: > On Thursday 28 August 2014 03:36 PM, Doug Anderson wrote: >> These two patches add support for automatically configuring the IO >> voltage domains on rk3188 and rk3288 SoCs. The first patch adds some >> new notification types to the regulator code. It's used by the second >> patch which actually implements the IO voltage domain driver. >> >> These two patches were co-developed by Heiko Stübner and Doug Anderson >> (proof of concept patches were written by Heiko). They were tested in >> a private branch on an rk3288 board using rk808 instead of mainline >> since rk808 support isn't finalized in mainline yet. >> >> (sorry if you got this series twice; my mailer seems unhappy with me) >> >> Heiko Stübner (2): >> regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) >> soc/rockchip: io-domain: add driver handling io domains >> > Sorry to shot down but your IO domains are nothing but voltage domains > and you should really build something in the drivers/power/* If everyone agrees that this belongs in drivers/power that's totally OK. Neither Heiko nor I was confident that it should be in drivers/soc. I had even though that the code wouldn't be totally out of place in the Rockchip pinctrl driver (adding Linus W since I think some SoCs did add code to handle 3.3V vs. 1.8V in pinctrl). > Please have a look at the RFC [1]. You should really go on those > lines and collaborate to make a generic voltage domain layer instead of throwing > the driver under drivers/soc. Trying to base things on a 7-month old RFC that hasn't been touched is not something I'm going to do. Maybe that makes me a bad person... I would also say that I'm not convinced that we really need a complicated framework here. Maybe when we're talking about things like ABB and DevFreq and the like then having a nice framework is a good idea. Really here we're just setting properties associated with IO pins. There's no decisions about latency, power tradeoffs, etc. If the pin is connected to 1.8V we need to set the 1.8V bit. If it's connected to 3.3V we need to set the 3.3V bit. The end. The only remotely complicated thing (and why this isn't just a pinctrl property) is what happens with dynamic voltages. SD Card IO lines can change voltage depending on UHS negotiation. In that case the SD Card Driver will request that its regulator change from 3.3V to 1.8V. The bit in the IO domain register needs to update in tandem. The driver is really quite tiny (333 lines). If we find that lots of people copy it and they have code that's nearly the same then we should try to abstract things out then. I'd be interested in hearing other opinions, though. -Doug ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAD=FV=Vcj+tAno92c38Prviyi-v2CmuGSzak1ppETL033KAF4w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 [not found] ` <CAD=FV=Vcj+tAno92c38Prviyi-v2CmuGSzak1ppETL033KAF4w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-08-30 11:27 ` Heiko Stübner 2014-09-04 16:51 ` Linus Walleij 0 siblings, 1 reply; 8+ messages in thread From: Heiko Stübner @ 2014-08-30 11:27 UTC (permalink / raw) To: Doug Anderson Cc: Santosh Shilimkar, Mark Brown, Olof Johansson, Arnd Bergmann, Addy Ke, Sonny Rao, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren, Pawel Moll, Ian Campbell, Peter De Schrijver, agross-sgV2jX0FEOL9JmXXK+q4OQ, Liam Girdwood, Rob Herring, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sandeep_n-l0cyMroinI0, Kumar Gala, Grant Likely, Thierry Reding, Nishanth Menon, Linus Am Freitag, 29. August 2014, 21:51:46 schrieb Doug Anderson: > Santosh, > > On Thu, Aug 28, 2014 at 2:26 PM, Santosh Shilimkar > > <santosh.shilimkar-l0cyMroinI0@public.gmane.org> wrote: > > On Thursday 28 August 2014 03:36 PM, Doug Anderson wrote: > >> These two patches add support for automatically configuring the IO > >> voltage domains on rk3188 and rk3288 SoCs. The first patch adds some > >> new notification types to the regulator code. It's used by the second > >> patch which actually implements the IO voltage domain driver. > >> > >> These two patches were co-developed by Heiko Stübner and Doug Anderson > >> (proof of concept patches were written by Heiko). They were tested in > >> a private branch on an rk3288 board using rk808 instead of mainline > >> since rk808 support isn't finalized in mainline yet. > >> > >> (sorry if you got this series twice; my mailer seems unhappy with me) > >> > >> Heiko Stübner (2): > >> regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) > >> soc/rockchip: io-domain: add driver handling io domains > > > > Sorry to shot down but your IO domains are nothing but voltage domains > > and you should really build something in the drivers/power/* > > If everyone agrees that this belongs in drivers/power that's totally > OK. Neither Heiko nor I was confident that it should be in > drivers/soc. I had even though that the code wouldn't be totally out > of place in the Rockchip pinctrl driver (adding Linus W since I think > some SoCs did add code to handle 3.3V vs. 1.8V in pinctrl). a bit of context for Linus ... This is essentially the continuation of the thread "io-domain voltages as regulators?" from the beginning of august. After more discussions we found out that the io voltage selection I asked about is not an independent supply, but instead has to reflect the voltage of the real supplying regulator. And setting the io-voltage setting to 1.8V while the regulator is supplying 3.3V for example may actually damage the chip. So in our current approach here, we added a driver that tracks voltage changes of the supplying regulator via a notifier and sets the register bits accordingly. > > > Please have a look at the RFC [1]. You should really go on those > > lines and collaborate to make a generic voltage domain layer instead of > > throwing the driver under drivers/soc. > > Trying to base things on a 7-month old RFC that hasn't been touched is > not something I'm going to do. Maybe that makes me a bad person... > > I would also say that I'm not convinced that we really need a > complicated framework here. Maybe when we're talking about things > like ABB and DevFreq and the like then having a nice framework is a > good idea. Really here we're just setting properties associated with > IO pins. There's no decisions about latency, power tradeoffs, etc. > If the pin is connected to 1.8V we need to set the 1.8V bit. If it's > connected to 3.3V we need to set the 3.3V bit. The end. > > The only remotely complicated thing (and why this isn't just a pinctrl > property) is what happens with dynamic voltages. SD Card IO lines can > change voltage depending on UHS negotiation. In that case the SD Card > Driver will request that its regulator change from 3.3V to 1.8V. The > bit in the IO domain register needs to update in tandem. > > > The driver is really quite tiny (333 lines). If we find that lots of > people copy it and they have code that's nearly the same then we > should try to abstract things out then. > > > I'd be interested in hearing other opinions, though. > > -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 2014-08-30 11:27 ` Heiko Stübner @ 2014-09-04 16:51 ` Linus Walleij 2014-09-10 23:12 ` Kevin Hilman 0 siblings, 1 reply; 8+ messages in thread From: Linus Walleij @ 2014-09-04 16:51 UTC (permalink / raw) To: Heiko Stübner, Rafael J. Wysocki, Kevin Hilman, Ulf Hansson Cc: Doug Anderson, Santosh Shilimkar, Mark Brown, Olof Johansson, Arnd Bergmann, Addy Ke, Sonny Rao, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren, Pawel Moll, Ian Campbell, Peter De Schrijver, Andy Gross, Liam Girdwood, Rob Herring, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sandeep Nair, Kumar Gala, Grant Likely, Thierry On Sat, Aug 30, 2014 at 1:27 PM, Heiko Stübner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> wrote: > Am Freitag, 29. August 2014, 21:51:46 schrieb Doug Anderson: >> On Thu, Aug 28, 2014 at 2:26 PM, Santosh Shilimkar >> >> <santosh.shilimkar-l0cyMroinI0@public.gmane.org> wrote: >> > On Thursday 28 August 2014 03:36 PM, Doug Anderson wrote: >> >> These two patches add support for automatically configuring the IO >> >> voltage domains on rk3188 and rk3288 SoCs. The first patch adds some >> >> new notification types to the regulator code. It's used by the second >> >> patch which actually implements the IO voltage domain driver. >> >> >> >> These two patches were co-developed by Heiko Stübner and Doug Anderson >> >> (proof of concept patches were written by Heiko). They were tested in >> >> a private branch on an rk3288 board using rk808 instead of mainline >> >> since rk808 support isn't finalized in mainline yet. >> >> >> >> (sorry if you got this series twice; my mailer seems unhappy with me) >> >> >> >> Heiko Stübner (2): >> >> regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) >> >> soc/rockchip: io-domain: add driver handling io domains >> > >> > Sorry to shot down but your IO domains are nothing but voltage domains >> > and you should really build something in the drivers/power/* >> >> If everyone agrees that this belongs in drivers/power that's totally >> OK. Neither Heiko nor I was confident that it should be in >> drivers/soc. I had even though that the code wouldn't be totally out >> of place in the Rockchip pinctrl driver (adding Linus W since I think >> some SoCs did add code to handle 3.3V vs. 1.8V in pinctrl). > > a bit of context for Linus ... > > This is essentially the continuation of the thread "io-domain voltages as > regulators?" from the beginning of august. After more discussions we found out > that the io voltage selection I asked about is not an independent supply, but > instead has to reflect the voltage of the real supplying regulator. > > And setting the io-voltage setting to 1.8V while the regulator is supplying > 3.3V for example may actually damage the chip. > > > So in our current approach here, we added a driver that tracks voltage changes > of the supplying regulator via a notifier and sets the register bits > accordingly. I feel I'm not smart enough for this. You need the PM people to look at this stuff, like Rafael Wysocki, Kevin Hilman and Ulf Hansson. Since it is also MMC/SD UHS-related, Ulf should know better than most what is needed, plus he's working on generic power domains right now. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 2014-09-04 16:51 ` Linus Walleij @ 2014-09-10 23:12 ` Kevin Hilman 0 siblings, 0 replies; 8+ messages in thread From: Kevin Hilman @ 2014-09-10 23:12 UTC (permalink / raw) To: Linus Walleij Cc: Heiko Stübner, Rafael J. Wysocki, Ulf Hansson, Doug Anderson, Santosh Shilimkar, Mark Brown, Olof Johansson, Arnd Bergmann, Addy Ke, Sonny Rao, linux-arm-kernel@lists.infradead.org, Mark Rutland, devicetree@vger.kernel.org, Stephen Warren, Pawel Moll, Ian Campbell, Peter De Schrijver, Andy Gross, Liam Girdwood, Rob Herring Linus Walleij <linus.walleij@linaro.org> writes: > On Sat, Aug 30, 2014 at 1:27 PM, Heiko Stübner <heiko@sntech.de> wrote: >> Am Freitag, 29. August 2014, 21:51:46 schrieb Doug Anderson: >>> On Thu, Aug 28, 2014 at 2:26 PM, Santosh Shilimkar >>> >>> <santosh.shilimkar@ti.com> wrote: >>> > On Thursday 28 August 2014 03:36 PM, Doug Anderson wrote: >>> >> These two patches add support for automatically configuring the IO >>> >> voltage domains on rk3188 and rk3288 SoCs. The first patch adds some >>> >> new notification types to the regulator code. It's used by the second >>> >> patch which actually implements the IO voltage domain driver. >>> >> >>> >> These two patches were co-developed by Heiko Stübner and Doug Anderson >>> >> (proof of concept patches were written by Heiko). They were tested in >>> >> a private branch on an rk3288 board using rk808 instead of mainline >>> >> since rk808 support isn't finalized in mainline yet. >>> >> >>> >> (sorry if you got this series twice; my mailer seems unhappy with me) >>> >> >>> >> Heiko Stübner (2): >>> >> regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) >>> >> soc/rockchip: io-domain: add driver handling io domains >>> > >>> > Sorry to shot down but your IO domains are nothing but voltage domains >>> > and you should really build something in the drivers/power/* >>> >>> If everyone agrees that this belongs in drivers/power that's totally >>> OK. Neither Heiko nor I was confident that it should be in >>> drivers/soc. I had even though that the code wouldn't be totally out >>> of place in the Rockchip pinctrl driver (adding Linus W since I think >>> some SoCs did add code to handle 3.3V vs. 1.8V in pinctrl). >> >> a bit of context for Linus ... >> >> This is essentially the continuation of the thread "io-domain voltages as >> regulators?" from the beginning of august. After more discussions we found out >> that the io voltage selection I asked about is not an independent supply, but >> instead has to reflect the voltage of the real supplying regulator. >> >> And setting the io-voltage setting to 1.8V while the regulator is supplying >> 3.3V for example may actually damage the chip. >> >> >> So in our current approach here, we added a driver that tracks voltage changes >> of the supplying regulator via a notifier and sets the register bits >> accordingly. > > I feel I'm not smart enough for this. You need the PM people to look > at this stuff, like Rafael Wysocki, Kevin Hilman and Ulf Hansson. I think the best fit for this is along with the Adaptive Voltage Scaling (AVS) stuff we currently have in drivers/power/avs. It's not exactly adaptive in the same sense as the TI/SmartReflex is because there's no hardware being configured to dynamically make micro-adjustments to the regulators. But, it is adaptive in the sense that there's SoC-specific "stuff" to do right around the same time the voltage is scaled. So I would suggest drivers/power/avs. Kevin ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 @ 2014-08-28 19:19 Doug Anderson 0 siblings, 0 replies; 8+ messages in thread From: Doug Anderson @ 2014-08-28 19:19 UTC (permalink / raw) To: Mark Brown, Heiko Stuebner, olof-nZhT3qVonbNeoWH0uzbU5w Cc: Addy Ke, Sonny Rao, Doug Anderson, mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, swarren-DDmLM1+adcrQT0dZR+AlfA, pawel.moll-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA, agross-sgV2jX0FEOL9JmXXK+q4OQ, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, linux-kernel-u79uwXL29TY76Z2rM5mHXA, santosh.shilimkar-l0cyMroinI0, sandeep_n-l0cyMroinI0, galak-sgV2jX0FEOL9JmXXK+q4OQ, grant.likely-QSEj5FYQhm4dnm+yROfE0A, treding-DDmLM1+adcrQT0dZR+AlfA These two patches add support for automatically configuring the IO voltage domains on rk3188 and rk3288 SoCs. The first patch adds some new notification types to the regulator code. It's used by the second patch which actually implements the IO voltage domain driver. These two patches were co-developed by Heiko Stübner and Doug Anderson (proof of concept patches were written by Heiko). They were tested in a private branch on an rk3288 board using rk808 instead of mainline since rk808 support isn't finalized in mainline yet. Heiko Stübner (2): regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) soc/rockchip: io-domain: add driver handling io domains .../devicetree/bindings/arm/rockchip/io-domain.txt | 60 ++++ drivers/regulator/core.c | 63 +++- drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/rockchip/Kconfig | 10 + drivers/soc/rockchip/Makefile | 1 + drivers/soc/rockchip/io-domain.c | 333 +++++++++++++++++++++ include/linux/regulator/consumer.h | 20 ++ 8 files changed, 482 insertions(+), 7 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/rockchip/io-domain.txt create mode 100644 drivers/soc/rockchip/Kconfig create mode 100644 drivers/soc/rockchip/Makefile create mode 100644 drivers/soc/rockchip/io-domain.c -- 2.1.0.rc2.206.gedb03e5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-09-10 23:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-28 19:36 [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 Doug Anderson
2014-08-28 19:36 ` [PATCH 2/2] soc/rockchip: io-domain: add driver handling io domains Doug Anderson
2014-08-28 21:26 ` [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 Santosh Shilimkar
2014-08-30 4:51 ` Doug Anderson
[not found] ` <CAD=FV=Vcj+tAno92c38Prviyi-v2CmuGSzak1ppETL033KAF4w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-30 11:27 ` Heiko Stübner
2014-09-04 16:51 ` Linus Walleij
2014-09-10 23:12 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2014-08-28 19:19 Doug Anderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).