* [PATCH 0/3] SPI Fixes for spi-rockchip
@ 2014-09-03 20:44 Doug Anderson
2014-09-03 20:44 ` [PATCH 3/3] dt-bindings: spi/rockchip: Mark DMA as optional Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2014-09-03 20:44 UTC (permalink / raw)
To: Mark Brown, Addy Ke, Heiko Stuebner
Cc: Alexandru Stan, Sonny Rao,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Doug Anderson,
mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
pawel.moll-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
broonie-QSEj5FYQhm4dnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, linux-spi-u79uwXL29TY76Z2rM5mHXA,
galak-sgV2jX0FEOL9JmXXK+q4OQ
These three patches are random SPI fixes for spi-rockchip. They are
unrelated and can be applied / NAKed separately. They've been tested
in PIO mode on an rk3288 board (since SPI DMA isn't currently working
for some unknown reason).
Doug Anderson (3):
spi/rockchip: Fix the wait_for_idle() timeout
spi/rockchip: Don't warn if SPI is busy but disabled
dt-bindings: spi/rockchip: Mark DMA as optional
Documentation/devicetree/bindings/spi/spi-rockchip.txt | 8 ++++++--
drivers/spi/spi-rockchip.c | 5 +++--
2 files changed, 9 insertions(+), 4 deletions(-)
--
2.1.0.rc2.206.gedb03e5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 3/3] dt-bindings: spi/rockchip: Mark DMA as optional
2014-09-03 20:44 [PATCH 0/3] SPI Fixes for spi-rockchip Doug Anderson
@ 2014-09-03 20:44 ` Doug Anderson
[not found] ` <1409777067-17422-4-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2014-09-03 20:44 UTC (permalink / raw)
To: Mark Brown, Addy Ke, Heiko Stuebner
Cc: Alexandru Stan, Sonny Rao, linux-rockchip, linux-arm-kernel,
Doug Anderson, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, broonie, devicetree, linux-kernel
The Rockchip SPI controller works fine without DMA (aside from a few
warnings). The DMA property even implies this, saying:
DMA request names should include "tx" and "rx" if present.
Officially mark the properties as optional.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Documentation/devicetree/bindings/spi/spi-rockchip.txt | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
index 7bab355..467dec4 100644
--- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt
+++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
@@ -16,11 +16,15 @@ Required Properties:
- clocks: Must contain an entry for each entry in clock-names.
- clock-names: Shall be "spiclk" for the transfer-clock, and "apb_pclk" for
the peripheral clock.
+- #address-cells: should be 1.
+- #size-cells: should be 0.
+
+Optional Properties:
+
- dmas: DMA specifiers for tx and rx dma. See the DMA client binding,
Documentation/devicetree/bindings/dma/dma.txt
- dma-names: DMA request names should include "tx" and "rx" if present.
-- #address-cells: should be 1.
-- #size-cells: should be 0.
+
Example:
--
2.1.0.rc2.206.gedb03e5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] dt-bindings: spi/rockchip: Mark DMA as optional
[not found] ` <1409777067-17422-4-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
@ 2014-09-04 22:54 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-09-04 22:54 UTC (permalink / raw)
To: Doug Anderson
Cc: Addy Ke, Heiko Stuebner, Alexandru Stan, Sonny Rao,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
On Wed, Sep 03, 2014 at 01:44:27PM -0700, Doug Anderson wrote:
> The Rockchip SPI controller works fine without DMA (aside from a few
> warnings). The DMA property even implies this, saying:
Applied all, thanks. Please use subject bindings matching the style for
the subsystem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-04 22:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-03 20:44 [PATCH 0/3] SPI Fixes for spi-rockchip Doug Anderson
2014-09-03 20:44 ` [PATCH 3/3] dt-bindings: spi/rockchip: Mark DMA as optional Doug Anderson
[not found] ` <1409777067-17422-4-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-04 22:54 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).