* [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver
[not found] <1409841592-18890-1-git-send-email-lee.jones@linaro.org>
@ 2014-09-04 14:39 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2014-09-04 14:39 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: lee.jones, kernel, wim, linux-watchdog, devicetree, David Paris
Cc: devicetree@vger.kernel.org
Signed-off-by: David Paris <david.paris@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../devicetree/bindings/watchdog/st-lpc-wdt.txt | 27 ++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
diff --git a/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
new file mode 100644
index 0000000..f0e57ba
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
@@ -0,0 +1,27 @@
+STMicroelectronics LPC Watchdog
+===============================
+
+Required properties
+
+- compatible : "st,<soc>-watchdog"
+- reg : LPC registers base address + range
+- reg-names : Register map "base" and "syscfg-en" are compulsory "type" is
+ platform dependent and not required for the STiH407.
+- clock-names : Should be "lpc_wdt"
+- clocks : Clock used by LPC device
+- timeout-sec : Qatchdog timeout in seconds
+- st,syscfg : Syscfg node used to configure cpu reset type and mask
+- st,warm_reset : If present, reset type will be 'warm'. If not, it will be cold
+
+Example:
+ watchdog@fde05000 {
+ compatible = "st,stih416-lpc-watchdog";
+ reg = <0xfde05000 0x1000> <0x204 0x4>;
+ reg-names = "base", "syscfg-en"
+ clock-names = "lpc_wdt";
+ clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
+ timeout-sec = <600>;
+ st,syscfg = <&syscfg_core>;
+ st,warm_reset;
+ };
+
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver
[not found] <1412692572-14031-1-git-send-email-lee.jones@linaro.org>
@ 2014-10-07 14:36 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2014-10-07 14:36 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: lee.jones, kernel, wim, linux-watchdog, linux, devicetree,
David Paris
Cc: devicetree@vger.kernel.org
Signed-off-by: David Paris <david.paris@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../devicetree/bindings/watchdog/st-lpc-wdt.txt | 30 ++++++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
diff --git a/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
new file mode 100644
index 0000000..520ce90
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
@@ -0,0 +1,30 @@
+STMicroelectronics LPC Watchdog
+===============================
+
+Required properties
+
+- compatible : Must be one of:
+ "st,stih407-watchdog"
+ "st,stih416-watchdog"
+ "st,stih415-watchdog"
+ "st,stid127-watchdog"
+- reg : LPC registers base address + range
+- reg-names : Register map "base" and "syscfg-en" are compulsory. "type" is
+ platform dependent and not required for the STiH407
+- clock-names : Should be "lpc_wdt"
+- clocks : Clock used by LPC device
+- timeout-sec : Watchdog timeout in seconds
+- st,syscfg : Syscfg node used to configure CPU reset type and mask
+- st,warm_reset : If present, reset type will be 'warm'. If not, it will be cold
+
+Example:
+ watchdog@fde05000 {
+ compatible = "st,stih416-lpc-watchdog";
+ reg = <0xfde05000 0x1000> <0x204 0x4>;
+ reg-names = "base", "syscfg-en"
+ clock-names = "lpc_wdt";
+ clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
+ timeout-sec = <600>;
+ st,syscfg = <&syscfg_core>;
+ st,warm_reset;
+ };
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver
[not found] <1412760810-23199-1-git-send-email-lee.jones@linaro.org>
@ 2014-10-08 9:33 ` Lee Jones
[not found] ` <1412760810-23199-4-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2014-10-08 9:33 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: lee.jones, kernel, wim, linux-watchdog, linux, devicetree,
David Paris
Cc: devicetree@vger.kernel.org
Signed-off-by: David Paris <david.paris@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../devicetree/bindings/watchdog/st-lpc-wdt.txt | 30 ++++++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
diff --git a/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
new file mode 100644
index 0000000..520ce90
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
@@ -0,0 +1,30 @@
+STMicroelectronics LPC Watchdog
+===============================
+
+Required properties
+
+- compatible : Must be one of:
+ "st,stih407-watchdog"
+ "st,stih416-watchdog"
+ "st,stih415-watchdog"
+ "st,stid127-watchdog"
+- reg : LPC registers base address + range
+- reg-names : Register map "base" and "syscfg-en" are compulsory. "type" is
+ platform dependent and not required for the STiH407
+- clock-names : Should be "lpc_wdt"
+- clocks : Clock used by LPC device
+- timeout-sec : Watchdog timeout in seconds
+- st,syscfg : Syscfg node used to configure CPU reset type and mask
+- st,warm_reset : If present, reset type will be 'warm'. If not, it will be cold
+
+Example:
+ watchdog@fde05000 {
+ compatible = "st,stih416-lpc-watchdog";
+ reg = <0xfde05000 0x1000> <0x204 0x4>;
+ reg-names = "base", "syscfg-en"
+ clock-names = "lpc_wdt";
+ clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
+ timeout-sec = <600>;
+ st,syscfg = <&syscfg_core>;
+ st,warm_reset;
+ };
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver
[not found] ` <1412760810-23199-4-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2014-10-09 9:56 ` Mark Rutland
2014-10-23 15:02 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Mark Rutland @ 2014-10-09 9:56 UTC (permalink / raw)
To: Lee Jones
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Paris
On Wed, Oct 08, 2014 at 10:33:29AM +0100, Lee Jones wrote:
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Signed-off-by: David Paris <david.paris-qxv4g6HH51o@public.gmane.org>
> Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> .../devicetree/bindings/watchdog/st-lpc-wdt.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> new file mode 100644
> index 0000000..520ce90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> @@ -0,0 +1,30 @@
> +STMicroelectronics LPC Watchdog
> +===============================
> +
> +Required properties
> +
> +- compatible : Must be one of:
> + "st,stih407-watchdog"
> + "st,stih416-watchdog"
> + "st,stih415-watchdog"
> + "st,stid127-watchdog"
> +- reg : LPC registers base address + range
s/range/size/
Please append something like "one entryfor each entry in reg-names".
> +- reg-names : Register map "base" and "syscfg-en" are compulsory. "type" is
> + platform dependent and not required for the STiH407
I don't understand the mention of "type".
Additionally, "syscfg-en" looks to be a portion of another device
(shared system controller?), and probably should be described by
reference.
> +- clock-names : Should be "lpc_wdt"
> +- clocks : Clock used by LPC device
> +- timeout-sec : Watchdog timeout in seconds
> +- st,syscfg : Syscfg node used to configure CPU reset type and mask
Does this relate to the syscfg-en entry in the reg proeprty?
> +- st,warm_reset : If present, reset type will be 'warm'. If not, it will be cold
s/_/-/ in property names.
Why does this need to be in the binding? It seems like a choice rather
than a property of the system.
Mark.
> +
> +Example:
> + watchdog@fde05000 {
> + compatible = "st,stih416-lpc-watchdog";
> + reg = <0xfde05000 0x1000> <0x204 0x4>;
> + reg-names = "base", "syscfg-en"
> + clock-names = "lpc_wdt";
> + clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
> + timeout-sec = <600>;
> + st,syscfg = <&syscfg_core>;
> + st,warm_reset;
> + };
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver
2014-10-09 9:56 ` Mark Rutland
@ 2014-10-23 15:02 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2014-10-23 15:02 UTC (permalink / raw)
To: Mark Rutland
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com, wim@iguana.be,
linux-watchdog@vger.kernel.org, linux@roeck-us.net,
devicetree@vger.kernel.org, David Paris
On Thu, 09 Oct 2014, Mark Rutland wrote:
> On Wed, Oct 08, 2014 at 10:33:29AM +0100, Lee Jones wrote:
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: David Paris <david.paris@st.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > .../devicetree/bindings/watchdog/st-lpc-wdt.txt | 30 ++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> > new file mode 100644
> > index 0000000..520ce90
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> > @@ -0,0 +1,30 @@
> > +STMicroelectronics LPC Watchdog
> > +===============================
> > +
> > +Required properties
> > +
> > +- compatible : Must be one of:
> > + "st,stih407-watchdog"
> > + "st,stih416-watchdog"
> > + "st,stih415-watchdog"
> > + "st,stid127-watchdog"
> > +- reg : LPC registers base address + range
>
> s/range/size/
>
> Please append something like "one entryfor each entry in reg-names".
>
> > +- reg-names : Register map "base" and "syscfg-en" are compulsory. "type" is
> > + platform dependent and not required for the STiH407
>
> I don't understand the mention of "type".
This is a typo. It should be "syscfg-type".
> Additionally, "syscfg-en" looks to be a portion of another device
> (shared system controller?), and probably should be described by
> reference.
Answer below.
> > +- clock-names : Should be "lpc_wdt"
> > +- clocks : Clock used by LPC device
> > +- timeout-sec : Watchdog timeout in seconds
> > +- st,syscfg : Syscfg node used to configure CPU reset type and mask
>
> Does this relate to the syscfg-en entry in the reg proeprty?
Yes. We map these registers with regmap and use the read-in register
values of syscfg-en and syscfg-type to manipulate them. It's either
that or supplying a property for each read-in, which I like less.
> > +- st,warm_reset : If present, reset type will be 'warm'. If not, it will be cold
>
> s/_/-/ in property names.
You're right. This slipped my gaze.
> Why does this need to be in the binding? It seems like a choice rather
> than a property of the system.
What do you mean? It's something which needs to be configured at
initialisation time. If we provide it here, it means that we don't
have to re-complie to change the config.
> > +Example:
> > + watchdog@fde05000 {
> > + compatible = "st,stih416-lpc-watchdog";
> > + reg = <0xfde05000 0x1000> <0x204 0x4>;
> > + reg-names = "base", "syscfg-en"
> > + clock-names = "lpc_wdt";
> > + clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
> > + timeout-sec = <600>;
> > + st,syscfg = <&syscfg_core>;
> > + st,warm_reset;
> > + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver
[not found] ` <1414077524-6469-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2014-10-23 15:18 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2014-10-23 15:18 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, wim-IQzOog9fTRqzQB+pC5nmwQ,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA,
linux-0h96xk9xTtrk1uMJSBkQmQ
Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
devicetree-u79uwXL29TY76Z2rM5mHXA, David Paris
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: David Paris <david.paris-qxv4g6HH51o@public.gmane.org>
Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
.../devicetree/bindings/watchdog/st-lpc-wdt.txt | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
diff --git a/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
new file mode 100644
index 0000000..2d0328b
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
@@ -0,0 +1,31 @@
+STMicroelectronics LPC Watchdog
+===============================
+
+Required properties
+
+- compatible : Must be one of:
+ "st,stih407-watchdog"
+ "st,stih416-watchdog"
+ "st,stih415-watchdog"
+ "st,stid127-watchdog"
+- reg : LPC registers base address + size
+- reg-names : Register map "base" and "syscfg-en" are compulsory.
+ "syscfg-type" is platform dependent and not required for the
+ STiH407
+- clock-names : Should be "lpc_wdt"
+- clocks : Clock used by LPC device
+- timeout-sec : Watchdog timeout in seconds
+- st,syscfg : Syscfg node used to configure CPU reset type and mask
+- st,warm_reset : If present, reset type will be 'warm'. If not, it will be cold
+
+Example:
+ watchdog@fde05000 {
+ compatible = "st,stih416-lpc-watchdog";
+ reg = <0xfde05000 0x1000> <0x204 0x4>;
+ reg-names = "base", "syscfg-en"
+ clock-names = "lpc_wdt";
+ clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
+ timeout-sec = <600>;
+ st,syscfg = <&syscfg_core>;
+ st,warm_reset;
+ };
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-23 15:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1409841592-18890-1-git-send-email-lee.jones@linaro.org>
2014-09-04 14:39 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
[not found] <1412692572-14031-1-git-send-email-lee.jones@linaro.org>
2014-10-07 14:36 ` Lee Jones
[not found] <1412760810-23199-1-git-send-email-lee.jones@linaro.org>
2014-10-08 9:33 ` Lee Jones
[not found] ` <1412760810-23199-4-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-10-09 9:56 ` Mark Rutland
2014-10-23 15:02 ` Lee Jones
[not found] <1414077524-6469-1-git-send-email-lee.jones@linaro.org>
[not found] ` <1414077524-6469-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-10-23 15:18 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).