From: Andrew Bresticker <abrestic@chromium.org>
To: Ralf Baechle <ralf@linux-mips.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Bresticker <abrestic@chromium.org>,
Jeffrey Deans <jeffrey.deans@imgtec.com>,
Markos Chandras <markos.chandras@imgtec.com>,
Paul Burton <paul.burton@imgtec.com>,
Arnd Bergmann <arnd@arndb.de>, John Crispin <blogic@openwrt.org>,
David Daney <ddaney.cavm@gmail.com>,
linux-mips@linux-mips.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 12/16] irqchip: mips-gic: Add device-tree support
Date: Fri, 5 Sep 2014 10:30:14 -0700 [thread overview]
Message-ID: <1409938218-9026-13-git-send-email-abrestic@chromium.org> (raw)
In-Reply-To: <1409938218-9026-1-git-send-email-abrestic@chromium.org>
Add device-tree support for the MIPS GIC. With DT, no per-platform
static device interrupt mapping is supplied and instead all device
interrupts are specified through the DT. The GIC-to-CPU interrupts
must also be specified in the DT.
Platforms using DT-based probing of the GIC need only supply the
GIC_NUM_INTRS and, if necessary, MIPS_GIC_IRQ_BASE values and
call of_irq_init() with an of_device_id table including the GIC.
Currenlty only legacy and vecotred interrupt modes are supported.
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
---
Changes from v1:
- updated for change in bindings
- set base address and enable bit in GCR_GIC_BASE
---
arch/mips/include/asm/gic.h | 15 ++++++
drivers/irqchip/irq-mips-gic.c | 102 ++++++++++++++++++++++++++++++++++++++++-
2 files changed, 116 insertions(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/gic.h b/arch/mips/include/asm/gic.h
index 3beb4eb..3853c15 100644
--- a/arch/mips/include/asm/gic.h
+++ b/arch/mips/include/asm/gic.h
@@ -348,6 +348,10 @@ struct gic_shared_intr_map {
#define GIC_CPU_INT3 3 /* . */
#define GIC_CPU_INT4 4 /* . */
#define GIC_CPU_INT5 5 /* Core Interrupt 7 */
+#define GIC_NUM_CPU_INT 6
+
+/* Add 2 to convert GIC CPU pin to core interrupt */
+#define GIC_CPU_PIN_OFFSET 2
/* Local GIC interrupts. */
#define GIC_INT_TMR (GIC_CPU_INT5)
@@ -390,4 +394,15 @@ extern void gic_disable_interrupt(int irq_vec);
extern void gic_irq_ack(struct irq_data *d);
extern void gic_finish_irq(struct irq_data *d);
extern void gic_platform_init(int irqs, struct irq_chip *irq_controller);
+
+#ifdef CONFIG_IRQ_DOMAIN
+extern int gic_of_init(struct device_node *node, struct device_node *parent);
+#else
+static inline int gic_of_init(struct device_node *node,
+ struct device_node *parent)
+{
+ return 0;
+}
+#endif
+
#endif /* _ASM_GICREGS_H */
diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index c0ff749..d885749 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -8,17 +8,23 @@
*/
#include <linux/bitmap.h>
#include <linux/init.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
#include <linux/smp.h>
-#include <linux/irq.h>
+#include <linux/interrupt.h>
#include <linux/clocksource.h>
#include <asm/io.h>
+#include <asm/irq_cpu.h>
#include <asm/gic.h>
#include <asm/setup.h>
+#include <asm/mips-cm.h>
#include <asm/traps.h>
#include <linux/hardirq.h>
#include <asm-generic/bitops/find.h>
+#include "irqchip.h"
+
unsigned int gic_frequency;
unsigned int gic_present;
unsigned long _gic_base;
@@ -467,3 +473,97 @@ void __init gic_init(unsigned long gic_base_addr,
gic_platform_init(numintrs, &gic_irq_controller);
}
+
+#ifdef CONFIG_IRQ_DOMAIN
+/* CPU core IRQs used by GIC */
+static int gic_cpu_pin[GIC_NUM_CPU_INT];
+static int num_gic_cpu_pins;
+
+static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,
+ irq_hw_number_t hw)
+{
+ int pin = gic_cpu_pin[0] - GIC_CPU_PIN_OFFSET;
+
+ irq_set_chip_and_handler(irq, &gic_irq_controller, handle_level_irq);
+
+ GICWRITE(GIC_REG_ADDR(SHARED, GIC_SH_MAP_TO_PIN(hw)),
+ GIC_MAP_TO_PIN_MSK | pin);
+ /* Map to VPE 0 by default */
+ GIC_SH_MAP_TO_VPE_SMASK(hw, 0);
+ set_bit(hw, pcpu_masks[0].pcpu_mask);
+
+ return 0;
+}
+
+static const struct irq_domain_ops gic_irq_domain_ops = {
+ .map = gic_irq_domain_map,
+ .xlate = irq_domain_xlate_twocell,
+};
+
+static void gic_irq_dispatch(unsigned int irq, struct irq_desc *desc)
+{
+ struct irq_domain *domain = irq_get_handler_data(irq);
+ unsigned int hwirq;
+
+ while ((hwirq = gic_get_int()) != GIC_NUM_INTRS) {
+ irq = irq_linear_revmap(domain, hwirq);
+ generic_handle_irq(irq);
+ }
+}
+
+void __weak __init gic_platform_init(int irqs, struct irq_chip *irq_controller)
+{
+}
+
+int __init gic_of_init(struct device_node *node, struct device_node *parent)
+{
+ struct irq_domain *domain;
+ struct resource res;
+ int i;
+
+ if (cpu_has_veic) {
+ pr_err("GIC EIC mode not supported with DT yet\n");
+ return -ENODEV;
+ }
+
+ for (i = 0; i < ARRAY_SIZE(gic_cpu_pin); i++) {
+ if (of_property_read_u32_index(node,
+ "mti,available-cpu-vectors",
+ i, &gic_cpu_pin[i]))
+ break;
+ num_gic_cpu_pins++;
+ }
+ if (!num_gic_cpu_pins) {
+ pr_err("No available CPU interrupt vectors for GIC\n");
+ return -ENODEV;
+ }
+
+ if (of_address_to_resource(node, 0, &res)) {
+ pr_err("Failed to get GIC memory range\n");
+ return -ENODEV;
+ }
+
+ if (mips_cm_present())
+ write_gcr_gic_base(res.start | CM_GCR_GIC_BASE_GICEN_MSK);
+
+ gic_init(res.start, resource_size(&res), NULL, 0, MIPS_GIC_IRQ_BASE);
+
+ domain = irq_domain_add_legacy(node, GIC_NUM_INTRS, MIPS_GIC_IRQ_BASE,
+ 0, &gic_irq_domain_ops, NULL);
+ if (!domain) {
+ pr_err("Failed to add GIC IRQ domain\n");
+ return -ENOMEM;
+ }
+
+ for (i = 0; i < num_gic_cpu_pins; i++) {
+ int irq;
+
+ irq = irq_create_mapping(mips_intc_domain, gic_cpu_pin[i]);
+ irq_set_chained_handler(irq, gic_irq_dispatch);
+ irq_set_handler_data(irq, domain);
+ }
+
+ return 0;
+}
+IRQCHIP_DECLARE(mips_gic, "mti,global-interrupt-controller", gic_of_init);
+#endif
--
2.1.0.rc2.206.gedb03e5
next prev parent reply other threads:[~2014-09-05 17:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:30 [PATCH v2 00/16] MIPS: GIC device-tree support Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 02/16] MIPS: Set vint handler when mapping CPU interrupts Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 03/16] MIPS: Export CPU IRQ domain Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 04/16] MIPS: smp-cps: Enable all hardware interrupts on secondary CPUs Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 05/16] MIPS: Move GIC to drivers/irqchip/ Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 06/16] MIPS: Move MIPS_GIC_IRQ_BASE into platform irq.h Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 07/16] irqchip: mips-gic: Implement irq_set_type callback Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 08/16] irqchip: mips-gic: Implement generic irq_ack/irq_eoi callbacks Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 10/16] of: Add vendor prefix for MIPS Technologies, Inc Andrew Bresticker
[not found] ` <1409938218-9026-11-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-22 14:23 ` Rob Herring
2014-09-22 16:28 ` Andrew Bresticker
2014-09-22 19:01 ` Kumar Gala
2014-09-22 19:30 ` Andrew Bresticker
[not found] ` <CAL1qeaEd2L8NUugh27hkGMa1aqaxviupRJnBd2+aru1wq6KKGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-22 19:36 ` Kumar Gala
[not found] ` <C73B2A63-4396-462B-8172-F9CA32E573F1-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-09-22 19:43 ` Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 11/16] of: Add binding document for MIPS GIC Andrew Bresticker
2014-09-05 17:30 ` Andrew Bresticker [this message]
[not found] ` <1409938218-9026-1-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-05 17:30 ` [PATCH v2 01/16] MIPS: Provide a generic plat_irq_dispatch Andrew Bresticker
[not found] ` <1409938218-9026-2-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-05 18:51 ` Thomas Gleixner
2014-09-05 21:02 ` Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 09/16] irqchip: mips-gic: Fix gic_set_affinity() return value Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 13/16] irqchip: mips-gic: Add generic IPI support when using DT Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 14/16] irqchip: mips-gic: Support local interrupts Andrew Bresticker
2014-09-05 19:05 ` Thomas Gleixner
2014-09-05 21:50 ` Andrew Bresticker
2014-09-05 17:30 ` [PATCH v2 15/16] MIPS: GIC: Use local interrupts for timer Andrew Bresticker
[not found] ` <1409938218-9026-16-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-09-05 19:08 ` Thomas Gleixner
2014-09-05 17:30 ` [PATCH v2 16/16] MIPS: Malta: Map GIC local interrupts Andrew Bresticker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409938218-9026-13-git-send-email-abrestic@chromium.org \
--to=abrestic@chromium.org \
--cc=arnd@arndb.de \
--cc=blogic@openwrt.org \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=jeffrey.deans@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=markos.chandras@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=pawel.moll@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).