* Re: [PATCH] powerpc: dts: t208x: Change T208x USB controller version [not found] ` <1408617090-29692-1-git-send-email-nikhil.badola-KZfg59tc24xl57MIdRCFDg@public.gmane.org> @ 2014-08-21 22:36 ` Scott Wood 2014-09-10 4:45 ` nikhil.badola 0 siblings, 1 reply; 3+ messages in thread From: Scott Wood @ 2014-08-21 22:36 UTC (permalink / raw) To: Nikhil Badola Cc: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ, devicetree-u79uwXL29TY76Z2rM5mHXA On Thu, 2014-08-21 at 16:01 +0530, Nikhil Badola wrote: > Change USB controller version to 2.5 in compatible string for T2080/T2081 > > Signed-off-by: Nikhil Badola <nikhil.badola-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > --- > Checkpatch warnings handled by commit 61a8c2c6fe71082de3ea8629589dcdd0cc5c3f02 That checkpatch warning is known to have false positives in cases where the binding says "<CHIPNAME>-device" or "device-<VERSION>". If you want to update the binding to give an example with a version, that's fine, but checkpatch shouldn't be why. We're not going to update the binding example again to match a different version the next time one is added to a device tree... > Documentation: dts: fsl-usb: Document USB node compatible string for IP version > > arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi > index 97479f0..aecee96 100644 > --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi > +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi > @@ -410,7 +410,7 @@ > /include/ "qoriq-gpio-3.dtsi" > /include/ "qoriq-usb2-mph-0.dtsi" > usb0: usb@210000 { > - compatible = "fsl-usb2-mph-v2.4", "fsl-usb2-mph"; > + compatible = "fsl-usb2-mph-v2.5", "fsl-usb2-mph"; This is an example of why it's better to rely on version registers when present. -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] powerpc: dts: t208x: Change T208x USB controller version 2014-08-21 22:36 ` [PATCH] powerpc: dts: t208x: Change T208x USB controller version Scott Wood @ 2014-09-10 4:45 ` nikhil.badola 2014-09-10 5:16 ` Scott Wood 0 siblings, 1 reply; 3+ messages in thread From: nikhil.badola @ 2014-09-10 4:45 UTC (permalink / raw) To: Scott Wood; +Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org >-----Original Message----- >From: Wood Scott-B07421 >Sent: Friday, August 22, 2014 4:07 AM >To: Badola Nikhil-B46172 >Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org >Subject: Re: [PATCH] powerpc: dts: t208x: Change T208x USB controller version > >On Thu, 2014-08-21 at 16:01 +0530, Nikhil Badola wrote: >> Change USB controller version to 2.5 in compatible string for >> T2080/T2081 >> >> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com> >> --- >> Checkpatch warnings handled by commit >> 61a8c2c6fe71082de3ea8629589dcdd0cc5c3f02 > >That checkpatch warning is known to have false positives in cases where the >binding says "<CHIPNAME>-device" or "device-<VERSION>". If you want to >update the binding to give an example with a version, that's fine, but >checkpatch shouldn't be why. We're not going to update the binding example >again to match a different version the next time one is added to a device tree... > >> Documentation: dts: fsl-usb: Document USB node compatible string for >IP version >> >> arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi >> b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi >> index 97479f0..aecee96 100644 >> --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi >> +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi >> @@ -410,7 +410,7 @@ >> /include/ "qoriq-gpio-3.dtsi" >> /include/ "qoriq-usb2-mph-0.dtsi" >> usb0: usb@210000 { >> - compatible = "fsl-usb2-mph-v2.4", "fsl-usb2-mph"; >> + compatible = "fsl-usb2-mph-v2.5", "fsl-usb2-mph"; > >This is an example of why it's better to rely on version registers when present. > >-Scott > Hi scott, I can see this patch in "superseded" state in patchwork. As per our discussion the IP version checking is to be done by compatible string only, so can I proceed to send this patch again? _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: dts: t208x: Change T208x USB controller version 2014-09-10 4:45 ` nikhil.badola @ 2014-09-10 5:16 ` Scott Wood 0 siblings, 0 replies; 3+ messages in thread From: Scott Wood @ 2014-09-10 5:16 UTC (permalink / raw) To: Badola Nikhil-B46172 Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On Tue, 2014-09-09 at 23:45 -0500, Badola Nikhil-B46172 wrote: > >-----Original Message----- > >From: Wood Scott-B07421 > >Sent: Friday, August 22, 2014 4:07 AM > >To: Badola Nikhil-B46172 > >Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org > >Subject: Re: [PATCH] powerpc: dts: t208x: Change T208x USB controller version > > > >On Thu, 2014-08-21 at 16:01 +0530, Nikhil Badola wrote: > >> Change USB controller version to 2.5 in compatible string for > >> T2080/T2081 > >> > >> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com> > >> --- > >> Checkpatch warnings handled by commit > >> 61a8c2c6fe71082de3ea8629589dcdd0cc5c3f02 > > > >That checkpatch warning is known to have false positives in cases where the > >binding says "<CHIPNAME>-device" or "device-<VERSION>". If you want to > >update the binding to give an example with a version, that's fine, but > >checkpatch shouldn't be why. We're not going to update the binding example > >again to match a different version the next time one is added to a device tree... > > > >> Documentation: dts: fsl-usb: Document USB node compatible string for > >IP version > >> > >> arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi > >> b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi > >> index 97479f0..aecee96 100644 > >> --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi > >> +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi > >> @@ -410,7 +410,7 @@ > >> /include/ "qoriq-gpio-3.dtsi" > >> /include/ "qoriq-usb2-mph-0.dtsi" > >> usb0: usb@210000 { > >> - compatible = "fsl-usb2-mph-v2.4", "fsl-usb2-mph"; > >> + compatible = "fsl-usb2-mph-v2.5", "fsl-usb2-mph"; > > > >This is an example of why it's better to rely on version registers when present. > > > >-Scott > > > Hi scott, > > I can see this patch in "superseded" state in patchwork. As per our discussion the IP version checking is to be done by compatible string only, so can I proceed to send this patch again? Sorry, apparently I thought that http://patchwork.ozlabs.org/patch/383670/ was a newer version of the patch, and didn't notice they were for different chips. No need to resend. Thanks for pointing this out. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-10 5:16 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <1408617090-29692-1-git-send-email-nikhil.badola@freescale.com> [not found] ` <1408617090-29692-1-git-send-email-nikhil.badola-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2014-08-21 22:36 ` [PATCH] powerpc: dts: t208x: Change T208x USB controller version Scott Wood 2014-09-10 4:45 ` nikhil.badola 2014-09-10 5:16 ` Scott Wood
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).