* [PATCH reword] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC
@ 2014-09-10 8:55 klightspeed-aslSrjg9ejhWX4hkXwHRhw
[not found] ` <1410339341-3372-1-git-send-email-klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: klightspeed-aslSrjg9ejhWX4hkXwHRhw @ 2014-09-10 8:55 UTC (permalink / raw)
To: Jason Cooper, Ezequiel Garcia, Brian Norris, Russell King
Cc: Ben Peddell, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Arnaud Ebalard, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Thomas Petazzoni, Gregory Clement,
devicetree-u79uwXL29TY76Z2rM5mHXA
The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC
(strength = 4), while the pxa3xx NAND driver by default uses
Hamming ECC (strength = 1).
This patch changes the ECC mode on these machines to match that
of the bootloader and of the stock firmware. That way, it is
now possible to update the kernel from userland (e.g. using
standard tools from mtd-utils package); u-boot will happily
load and boot it.
Fixes: 92beaccd8b49 ("ARM: mvebu: Enable NAND controller in ReadyNAS 102 .dts file")
Signed-off-by: Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
Acked-by: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Tested-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
---
arch/arm/boot/dts/armada-370-netgear-rn102.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/armada-370-netgear-rn102.dts b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
index d6d572e..285524f 100644
--- a/arch/arm/boot/dts/armada-370-netgear-rn102.dts
+++ b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
@@ -143,6 +143,10 @@
marvell,nand-enable-arbiter;
nand-on-flash-bbt;
+ /* Use Hardware BCH ECC */
+ nand-ecc-strength = <4>;
+ nand-ecc-step-size = <512>;
+
partition@0 {
label = "u-boot";
reg = <0x0000000 0x180000>; /* 1.5MB */
--
1.8.5.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1410339341-3372-1-git-send-email-klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>]
* Re: [PATCH reword] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC [not found] ` <1410339341-3372-1-git-send-email-klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org> @ 2014-09-13 21:08 ` Jason Cooper [not found] ` <20140913210829.GI30828-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Jason Cooper @ 2014-09-13 21:08 UTC (permalink / raw) To: klightspeed-aslSrjg9ejhWX4hkXwHRhw Cc: Ezequiel Garcia, Brian Norris, Russell King, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Arnaud Ebalard, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thomas Petazzoni, Gregory Clement, devicetree-u79uwXL29TY76Z2rM5mHXA On Wed, Sep 10, 2014 at 06:55:41PM +1000, klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org wrote: > The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC > (strength = 4), while the pxa3xx NAND driver by default uses > Hamming ECC (strength = 1). > > This patch changes the ECC mode on these machines to match that > of the bootloader and of the stock firmware. That way, it is > now possible to update the kernel from userland (e.g. using > standard tools from mtd-utils package); u-boot will happily > load and boot it. > > Fixes: 92beaccd8b49 ("ARM: mvebu: Enable NAND controller in ReadyNAS 102 .dts file") > Signed-off-by: Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org> > Acked-by: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > Tested-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> > --- > arch/arm/boot/dts/armada-370-netgear-rn102.dts | 4 ++++ > 1 file changed, 4 insertions(+) I've already applied this the mvebu/fixes: 500abb6ccb9e ARM: mvebu: Netgear RN2120: Use Hardware BCH ECC thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20140913210829.GI30828-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>]
* Re: [PATCH reword] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC [not found] ` <20140913210829.GI30828-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> @ 2014-09-14 2:54 ` Ben Peddell [not found] ` <54150349.7050503-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Ben Peddell @ 2014-09-14 2:54 UTC (permalink / raw) To: Jason Cooper Cc: Ezequiel Garcia, Brian Norris, Russell King, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Arnaud Ebalard, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thomas Petazzoni, Gregory Clement, devicetree-u79uwXL29TY76Z2rM5mHXA On 14/09/14 07:08, Jason Cooper wrote: > On Wed, Sep 10, 2014 at 06:55:41PM +1000, klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org wrote: >> The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC >> (strength = 4), while the pxa3xx NAND driver by default uses >> Hamming ECC (strength = 1). >> >> This patch changes the ECC mode on these machines to match that >> of the bootloader and of the stock firmware. That way, it is >> now possible to update the kernel from userland (e.g. using >> standard tools from mtd-utils package); u-boot will happily >> load and boot it. >> >> Fixes: 92beaccd8b49 ("ARM: mvebu: Enable NAND controller in ReadyNAS 102 .dts file") >> Signed-off-by: Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org> >> Acked-by: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> >> Tested-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> >> --- >> arch/arm/boot/dts/armada-370-netgear-rn102.dts | 4 ++++ >> 1 file changed, 4 insertions(+) > > I've already applied this the mvebu/fixes: > > 500abb6ccb9e ARM: mvebu: Netgear RN2120: Use Hardware BCH ECC That patch only affects arch/arm/boot/dts/armada-xp-netgear-rn2120.dts The patch I posted affects arch/arm/boot/dts/armada-370-netgear-rn102.dts -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <54150349.7050503-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>]
* Re: [PATCH reword] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC [not found] ` <54150349.7050503-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org> @ 2014-09-14 4:18 ` Jason Cooper 0 siblings, 0 replies; 4+ messages in thread From: Jason Cooper @ 2014-09-14 4:18 UTC (permalink / raw) To: Ben Peddell Cc: Ezequiel Garcia, Brian Norris, Russell King, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Arnaud Ebalard, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thomas Petazzoni, Gregory Clement, devicetree-u79uwXL29TY76Z2rM5mHXA On Sun, Sep 14, 2014 at 12:54:01PM +1000, Ben Peddell wrote: > On 14/09/14 07:08, Jason Cooper wrote: > > On Wed, Sep 10, 2014 at 06:55:41PM +1000, klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org wrote: > >> The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC > >> (strength = 4), while the pxa3xx NAND driver by default uses > >> Hamming ECC (strength = 1). > >> > >> This patch changes the ECC mode on these machines to match that > >> of the bootloader and of the stock firmware. That way, it is > >> now possible to update the kernel from userland (e.g. using > >> standard tools from mtd-utils package); u-boot will happily > >> load and boot it. > >> > >> Fixes: 92beaccd8b49 ("ARM: mvebu: Enable NAND controller in ReadyNAS 102 .dts file") > >> Signed-off-by: Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org> > >> Acked-by: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > >> Tested-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> > >> --- > >> arch/arm/boot/dts/armada-370-netgear-rn102.dts | 4 ++++ > >> 1 file changed, 4 insertions(+) > > > > I've already applied this the mvebu/fixes: > > > > 500abb6ccb9e ARM: mvebu: Netgear RN2120: Use Hardware BCH ECC > > That patch only affects arch/arm/boot/dts/armada-xp-netgear-rn2120.dts > > The patch I posted affects arch/arm/boot/dts/armada-370-netgear-rn102.dts Gah! You're right. Applied to mvebu/fixes and Cc'd the stable v3.14+ thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-14 4:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-10 8:55 [PATCH reword] ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC klightspeed-aslSrjg9ejhWX4hkXwHRhw
[not found] ` <1410339341-3372-1-git-send-email-klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
2014-09-13 21:08 ` Jason Cooper
[not found] ` <20140913210829.GI30828-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-09-14 2:54 ` Ben Peddell
[not found] ` <54150349.7050503-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
2014-09-14 4:18 ` Jason Cooper
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).