Re: [PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

["Ivan T. Ivanov" <iivanov@mm-sol.com>]

Hi,

On Tue, 2014-09-09 at 15:49 +0300, Stanimir Varbanov wrote:
> On 09/09/2014 01:32 PM, Arnd Bergmann wrote:
> > On Monday 08 September 2014 18:30:00 Stanimir Varbanov wrote:
> >>>>> These numbers all look hardware specific, so why put macros into the
> >>>>> device tree rather than using them directly?
> >>>>
> >>>> The idea was to use #defines in DT nodes when we need to overwrite the
> >>>> adc channel parameters, see example in 2/2 how it will be used.
> >>>
> >>> I don't understand. The node in the example has
> >>>
> >>> +               /* Channel node */
> >>> +               usb_id_nopull@39 {
> >>> +                       qcom,channel = <VADC_LR_MUX10_USB_ID>;
> >>> ...
> >>> +               };
> >>>
> >>>
> >>> And VADC_LR_MUX10_USB_ID is defined to 0x39.  How is this helping anything?
> >>> You just introduce an artificial dependency on the header file, which makes
> >>> it a mess to merge the patches or do updates, and anybody who needs to
> >>> make updates to this now has to go through the same pain, to update the
> >>> dts files, the driver and the binding document in lockstep.
> >>>
> >>> Why not remove the qcom,channel property completely and use a 'reg'
> >>> property with #address-cells=<1>, #size-cells=<0> and put the number
> >>> directly in there, with no need for obfuscation macros?
> >>
> >> OK thanks for the remarks. I will fix this mess.
> >>
> >> I hope you are expecting to see this:
> >>
> >> pmic_vadc: vadc@3100 {
> >>         #address-cells = <1>;
> >>         #size-cells = <0>;
> >>         #io-channel-cells = <1>;
> >>         io-channel-ranges;
> >>
> >>         usb_id_nopull@39 {
> >>                 reg = <0x39>;
> >>         };
> >> };
> >>
> >> and use the vadc channel from usb device node
> >>
> >> usb {
> >>         ...
> >>         io-channels = <&pmic_vadc 0x39>;

I believe this will be more readable and clear.

	     io-channels = <&pmic_vadc VADC_LR_MUX10_USB_ID>;

I would like to keep channels definitions macros in DT header.

Regards,
Ivan