* [PATCH] ARM: dts: Add Maxim 77693 PMIC to the Trats2 board
@ 2014-09-12 12:03 Krzysztof Kozlowski
2014-09-15 14:36 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2014-09-12 12:03 UTC (permalink / raw)
To: Ben Dooks, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, linux-arm-kernel,
linux-samsung-soc, devicetree, linux-kernel
Cc: Kyungmin Park, Marek Szyprowski, Bartlomiej Zolnierkiewicz,
Tomasz Figa, Krzysztof Kozlowski
The MAX77693 is a companion power management IC for smart phones and tablets.
The MAX77693 contains input over-voltage protection (OVP),
a fully-integrated 2.5A switching charger for Lithium Ion battery with
integrated battery disconnect, OTG/accessory 5V output power,
a high-current white LED driver for camera flash, two safeout LDOs,
a haptic motor driver, Model Gauge m3 battery fuel gauge and MicroUSB
Interface Controller (MUIC). I2C serial interface is used for
communicating.
Add MAX77693 node to the Trats2 board. This allows using:
- charger regulator,
- 2 safeout LDO regulators (for USB OTG),
- extcon.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/boot/dts/exynos4412-trats2.dts | 34 +++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 11967f4561e0..0b641513a23d 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -22,6 +22,7 @@
aliases {
i2c9 = &i2c_ak8975;
i2c10 = &i2c_cm36651;
+ i2c11 = &i2c_max77693;
};
memory {
@@ -518,6 +519,39 @@
};
};
+ i2c_max77693: i2c-gpio-1 {
+ compatible = "i2c-gpio";
+ gpios = <&gpm2 0 0>, <&gpm2 1 0 >;
+ i2c-gpio,delay-us = <2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ max77693@66 {
+ compatible = "maxim,max77693";
+ interrupt-parent = <&gpx1>;
+ interrupts = <5 2>;
+ reg = <0x66>;
+
+ regulators {
+ esafeout1_reg: esafeout@1 {
+ regulator-compatible = "ESAFEOUT1";
+ regulator-name = "ESAFEOUT1";
+ };
+ esafeout2_reg: esafeout@2 {
+ regulator-compatible = "ESAFEOUT2";
+ regulator-name = "ESAFEOUT2";
+ };
+ charger_reg: charger@0 {
+ regulator-compatible = "CHARGER";
+ regulator-name = "CHARGER";
+ regulator-min-microamp = <60000>;
+ regulator-max-microamp = <2580000>;
+ };
+ };
+ };
+ };
+
mmc@12550000 {
num-slots = <1>;
supports-highspeed;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: Add Maxim 77693 PMIC to the Trats2 board
2014-09-12 12:03 [PATCH] ARM: dts: Add Maxim 77693 PMIC to the Trats2 board Krzysztof Kozlowski
@ 2014-09-15 14:36 ` Javier Martinez Canillas
2014-09-15 14:56 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2014-09-15 14:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ben Dooks, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Linux Kernel, Kyungmin Park, Marek Szyprowski,
Bartlomiej Zolnierkiewicz, Tomasz Figa
Hello Krzysztof,
On Fri, Sep 12, 2014 at 2:03 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> + i2c_max77693: i2c-gpio-1 {
> + compatible = "i2c-gpio";
> + gpios = <&gpm2 0 0>, <&gpm2 1 0 >;
Can you please include <dt-bindings/gpio/gpio.h> and use
GPIO_ACTIVE_HIGH instead of 0 here for the type/level flags?
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + max77693@66 {
> + compatible = "maxim,max77693";
> + interrupt-parent = <&gpx1>;
> + interrupts = <5 2>;
> + reg = <0x66>;
> +
> + regulators {
> + esafeout1_reg: esafeout@1 {
> + regulator-compatible = "ESAFEOUT1";
According to Documentation/devicetree/bindings/regulator/regulator.txt,
the "regulator-compatible" DT property has been deprecated in favor of
just using the regulator node's name.
> + regulator-name = "ESAFEOUT1";
> + };
> + esafeout2_reg: esafeout@2 {
> + regulator-compatible = "ESAFEOUT2";
> + regulator-name = "ESAFEOUT2";
> + };
> + charger_reg: charger@0 {
> + regulator-compatible = "CHARGER";
> + regulator-name = "CHARGER";
> + regulator-min-microamp = <60000>;
> + regulator-max-microamp = <2580000>;
> + };
> + };
> + };
> + };
> +
> mmc@12550000 {
> num-slots = <1>;
> supports-highspeed;
>
Once those two issues are addressed, feel free to add my
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: Add Maxim 77693 PMIC to the Trats2 board
2014-09-15 14:36 ` Javier Martinez Canillas
@ 2014-09-15 14:56 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2014-09-15 14:56 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Ben Dooks, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Linux Kernel, Kyungmin Park, Marek Szyprowski,
Bartlomiej Zolnierkiewicz, Tomasz Figa
On pon, 2014-09-15 at 16:36 +0200, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On Fri, Sep 12, 2014 at 2:03 PM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
> > + i2c_max77693: i2c-gpio-1 {
> > + compatible = "i2c-gpio";
> > + gpios = <&gpm2 0 0>, <&gpm2 1 0 >;
>
> Can you please include <dt-bindings/gpio/gpio.h> and use
> GPIO_ACTIVE_HIGH instead of 0 here for the type/level flags?
Sure!
>
> > + i2c-gpio,delay-us = <2>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + status = "okay";
> > +
> > + max77693@66 {
> > + compatible = "maxim,max77693";
> > + interrupt-parent = <&gpx1>;
> > + interrupts = <5 2>;
> > + reg = <0x66>;
> > +
> > + regulators {
> > + esafeout1_reg: esafeout@1 {
> > + regulator-compatible = "ESAFEOUT1";
>
> According to Documentation/devicetree/bindings/regulator/regulator.txt,
> the "regulator-compatible" DT property has been deprecated in favor of
> just using the regulator node's name.
OK
>
> > + regulator-name = "ESAFEOUT1";
> > + };
> > + esafeout2_reg: esafeout@2 {
> > + regulator-compatible = "ESAFEOUT2";
> > + regulator-name = "ESAFEOUT2";
> > + };
> > + charger_reg: charger@0 {
> > + regulator-compatible = "CHARGER";
> > + regulator-name = "CHARGER";
> > + regulator-min-microamp = <60000>;
> > + regulator-max-microamp = <2580000>;
> > + };
> > + };
> > + };
> > + };
> > +
> > mmc@12550000 {
> > num-slots = <1>;
> > supports-highspeed;
> >
>
> Once those two issues are addressed, feel free to add my
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Thank you for feedback!
Best regards,
Krzysztof
>
> Best regards,
> Javier
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-15 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-12 12:03 [PATCH] ARM: dts: Add Maxim 77693 PMIC to the Trats2 board Krzysztof Kozlowski
2014-09-15 14:36 ` Javier Martinez Canillas
2014-09-15 14:56 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).