From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Georgi Djakov <gdjakov@mm-sol.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
David Collins <collinsd@codeaurora.org>
Subject: Re: [PATCH RESEND] thermal: Add QPNP PMIC temperature alarm driver
Date: Tue, 16 Sep 2014 10:53:30 +0300 [thread overview]
Message-ID: <1410854010.30351.17.camel@iivanov-dev> (raw)
In-Reply-To: <54170DA6.6050001@mm-sol.com>
On Mon, 2014-09-15 at 19:02 +0300, Georgi Djakov wrote:
<snip>
> > +Example:
> > +
> > + thermal-alarm@2400 {
> > + compatible = "qcom,qpnp-temp-alarm";
> > + reg = <0x2400>;
> > + interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>;
> > + label = "pm8941_tz";
> > + io-channels = <&pm8941_vadc VADC_DIE_TEMP>;
> > + io-channel-names = "thermal";
> > + };
>
> Maybe describe the trip points in the DT?
I am not sure. Trip points are not arbitrary selectable. Hardware
have 4 predefined operating modes, if I could say.
0 = {105 C, 125 C, 145 C}
1 = {110 C, 130 C, 150 C}
2 = {115 C, 135 C, 155 C}
3 = {120 C, 140 C, 160 C}
Everything which driver could select is one of 0...3.
Rest of the comments will be fixed in next version.
Thanks,
Ivan
prev parent reply other threads:[~2014-09-16 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 15:03 [PATCH RESEND] thermal: Add QPNP PMIC temperature alarm driver Ivan T. Ivanov
2014-09-15 15:30 ` Eduardo Valentin
2014-09-16 7:46 ` Ivan T. Ivanov
2014-09-24 14:56 ` Ivan T. Ivanov
2014-09-24 18:24 ` Eduardo Valentin
2014-09-24 20:30 ` Ivan T. Ivanov
2014-09-15 16:02 ` Georgi Djakov
2014-09-16 7:53 ` Ivan T. Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410854010.30351.17.camel@iivanov-dev \
--to=iivanov@mm-sol.com \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=galak@codeaurora.org \
--cc=gdjakov@mm-sol.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).