[PATCH 0/3 v3] Fix Exynos USB on kernels with USB Gadget support

[PATCH 0/3 v3] Fix Exynos USB on kernels with USB Gadget support

[Sjoerd Simons]

When building a kernel with support for both USB host and USB Gadget support on
the dwc3 controller on the Exynos5 soc will go into USB OTG mode unless
otherwise specified in the dtb, which is unhelpful for boards hooked up to run
as USB host.

First patch in this set explicitely set the dual-role mode for the dwc3
controller on Peach pi and Peach pit boards to host mode. Second patch adds
similar updates for Arndale Octa as reported by Andreas Färber. Last patch
enables gadget mode in the default exynos config to more easily catch/trigger
issues like these.

I suspect the Samsung SMDK5420 DTS might need similar changes, so it would be
great if users of those board could verify this.

Changes in v2: alphabetically sort the dts entries
Changes in v3: Add DTS updates for arndale octa

Sjoerd Simons (3):
  ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi
  ARM: dts: exynos: Explicitly set dr_mode on arndale-octa
  ARM: exynos_defconfig: enable USB gadget support

 arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts    | 8 ++++++++
 arch/arm/boot/dts/exynos5420.dtsi             | 4 ++--
 arch/arm/boot/dts/exynos5800-peach-pi.dts     | 8 ++++++++
 arch/arm/configs/exynos_defconfig             | 1 +
 5 files changed, 23 insertions(+), 2 deletions(-)

-- 
2.1.0

[PATCH 1/3 v3] ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi

[Sjoerd Simons]

In case the optional dr_mode property isn't set in the dwc3 nodes the
the controller will go into OTG mode iff both USB host and USB gadget
functionality are enabled in the kernel configuration. Unfortunately this
results in USB not working on exynos5420-peach-pit and
exynos5800-peach-pi with such a kernel configuration unless manually
change the mode. To resolve that explicitly configure the dual role
mode as host

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Andreas Färber <afaerber@suse.de>
---
 Changes in v2: alphabetically sort the dts entries
 Changes in v3: Fix typo in commit message

 arch/arm/boot/dts/exynos5420-peach-pit.dts | 8 ++++++++
 arch/arm/boot/dts/exynos5420.dtsi          | 4 ++--
 arch/arm/boot/dts/exynos5800-peach-pi.dts  | 8 ++++++++
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..29d3a59 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -427,6 +427,14 @@
 	status = "okay";
 };
 
+&usbdrd_dwc3_0 {
+	dr_mode = "host";
+};
+
+&usbdrd_dwc3_1 {
+	dr_mode = "host";
+};
+
 &usbdrd_phy0 {
 	vbus-supply = <&usb300_vbus_reg>;
 };
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index bfe056d..8617a03 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -815,7 +815,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		dwc3 {
+		usbdrd_dwc3_0: dwc3 {
 			compatible = "snps,dwc3";
 			reg = <0x12000000 0x10000>;
 			interrupts = <0 72 0>;
@@ -841,7 +841,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		dwc3 {
+		usbdrd_dwc3_1: dwc3 {
 			compatible = "snps,dwc3";
 			reg = <0x12400000 0x10000>;
 			interrupts = <0 73 0>;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..2064550 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -425,6 +425,14 @@
 	status = "okay";
 };
 
+&usbdrd_dwc3_0 {
+	dr_mode = "host";
+};
+
+&usbdrd_dwc3_1 {
+	dr_mode = "host";
+};
+
 &usbdrd_phy0 {
 	vbus-supply = <&usb300_vbus_reg>;
 };
-- 
2.1.0

[PATCH 2/3 v3] ARM: dts: exynos: Explicitly set dr_mode on arndale-octa

[Sjoerd Simons]

Explicitly set the dr_mode for the second dwc3 controller on the
Arndale Octa board to host mode. This is required to ensure the
controller is initialized in the right mode if the kernel is build with
USB gadget support

Reported-By: Andreas Färber <afaerber@suse.de>
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 Changes in v3: new patch

 arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index 434fd9d..fc2e983 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -375,3 +375,7 @@
 		};
 	};
 };
+
+&usbdrd_dwc3_1 {
+	dr_mode = "host";
+};
-- 
2.1.0

[PATCH 3/3 v3] ARM: exynos_defconfig: enable USB gadget support

[Sjoerd Simons]

Enable USB gadget support without support for any specific gadgets to
more easily catch cases where a devices dts doesn't specify the usb
controllers dr_mode while it should.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 arch/arm/configs/exynos_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index fc7d168..3664120 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -54,6 +54,7 @@ CONFIG_SMSC911X=y
 CONFIG_USB_USBNET=y
 CONFIG_USB_NET_SMSC75XX=y
 CONFIG_USB_NET_SMSC95XX=y
+CONFIG_USB_GADGET=y
 CONFIG_INPUT_EVDEV=y
 CONFIG_KEYBOARD_GPIO=y
 CONFIG_KEYBOARD_CROS_EC=y
-- 
2.1.0

Re: [PATCH 0/3 v3] Fix Exynos USB on kernels with USB Gadget support

[Sjoerd Simons]

[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]

Hey Kukjin,

It's been almost a month since I posted the first iteration of this
patchset on the list, with only trivial cosmetic changes and an addition
of a similar fix for Arndale Octa boards. Do you feel it needs more
review from specific folks before pulling it in or ?

Seems a bit of a shame if this would fail to make it for 3.18 (one could
even argue the dt patches are 3.17 RC material!) as it fixes USB
functionality being broken depending on the kernel configuration used.


On Mon, 2014-09-15 at 12:52 +0200, Sjoerd Simons wrote:
> When building a kernel with support for both USB host and USB Gadget support on
> the dwc3 controller on the Exynos5 soc will go into USB OTG mode unless
> otherwise specified in the dtb, which is unhelpful for boards hooked up to run
> as USB host.
> 
> First patch in this set explicitely set the dual-role mode for the dwc3
> controller on Peach pi and Peach pit boards to host mode. Second patch adds
> similar updates for Arndale Octa as reported by Andreas Färber. Last patch
> enables gadget mode in the default exynos config to more easily catch/trigger
> issues like these.
> 
> I suspect the Samsung SMDK5420 DTS might need similar changes, so it would be
> great if users of those board could verify this.
> 
> Changes in v2: alphabetically sort the dts entries
> Changes in v3: Add DTS updates for arndale octa
> 
> Sjoerd Simons (3):
>   ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi
>   ARM: dts: exynos: Explicitly set dr_mode on arndale-octa
>   ARM: exynos_defconfig: enable USB gadget support
> 
>  arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
>  arch/arm/boot/dts/exynos5420-peach-pit.dts    | 8 ++++++++
>  arch/arm/boot/dts/exynos5420.dtsi             | 4 ++--
>  arch/arm/boot/dts/exynos5800-peach-pi.dts     | 8 ++++++++
>  arch/arm/configs/exynos_defconfig             | 1 +
>  5 files changed, 23 insertions(+), 2 deletions(-)
> 



[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6170 bytes --]

Re: [PATCH 0/3 v3] Fix Exynos USB on kernels with USB Gadget support

[Kukjin Kim]

On 09/19/14 16:43, Sjoerd Simons wrote:
> Hey Kukjin,
>
Hi,

Sorry for late response...

> It's been almost a month since I posted the first iteration of this
> patchset on the list, with only trivial cosmetic changes and an addition
> of a similar fix for Arndale Octa boards. Do you feel it needs more
> review from specific folks before pulling it in or ?
>
> Seems a bit of a shame if this would fail to make it for 3.18 (one could
> even argue the dt patches are 3.17 RC material!) as it fixes USB
> functionality being broken depending on the kernel configuration used.
>
>
> On Mon, 2014-09-15 at 12:52 +0200, Sjoerd Simons wrote:
>> When building a kernel with support for both USB host and USB Gadget support on
>> the dwc3 controller on the Exynos5 soc will go into USB OTG mode unless
>> otherwise specified in the dtb, which is unhelpful for boards hooked up to run
>> as USB host.
>>
>> First patch in this set explicitely set the dual-role mode for the dwc3
>> controller on Peach pi and Peach pit boards to host mode. Second patch adds
>> similar updates for Arndale Octa as reported by Andreas Färber. Last patch
>> enables gadget mode in the default exynos config to more easily catch/trigger
>> issues like these.
>>
>> I suspect the Samsung SMDK5420 DTS might need similar changes, so it would be
>> great if users of those board could verify this.
>>
>> Changes in v2: alphabetically sort the dts entries
>> Changes in v3: Add DTS updates for arndale octa
>>
>> Sjoerd Simons (3):
>>    ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi
>>    ARM: dts: exynos: Explicitly set dr_mode on arndale-octa
>>    ARM: exynos_defconfig: enable USB gadget support
>>
>>   arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
>>   arch/arm/boot/dts/exynos5420-peach-pit.dts    | 8 ++++++++
>>   arch/arm/boot/dts/exynos5420.dtsi             | 4 ++--
>>   arch/arm/boot/dts/exynos5800-peach-pi.dts     | 8 ++++++++
>>   arch/arm/configs/exynos_defconfig             | 1 +
>>   5 files changed, 23 insertions(+), 2 deletions(-)
>>
I have no objection on this series but needs to be rebased on my tree, 
can you please respin on top of my tree?

Thanks,
Kukjin
-- 
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 0/3 v4] Fix Exynos USB on kernels with USB Gadget support

[Sjoerd Simons]

Same patches as v3 but rebased on
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/log/?h=for-next

When building a kernel with support for both USB host and USB Gadget support on
the dwc3 controller on the Exynos5 soc will go into USB OTG mode unless
otherwise specified in the dtb, which is unhelpful for boards hooked up to run
as USB host.

First patch in this set explicitely set the dual-role mode for the dwc3
controller on Peach pi and Peach pit boards to host mode. Second patch adds
similar updates for Arndale Octa as reported by Andreas Färber. Last patch
enables gadget mode in the default exynos config to more easily catch/trigger
issues like these.

I suspect the Samsung SMDK5420 DTS might need similar changes, so it would be
great if users of those board could verify this.

Changes in v2: alphabetically sort the dts entries
Changes in v3: Add DTS updates for arndale octa
Changes in v4: Rebased on todays linux-samsungs for-next branch

Sjoerd Simons (3):
  ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi
  ARM: dts: exynos: Explicitly set dr_mode on arndale-octa
  ARM: exynos_defconfig: enable USB gadget support

 arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts    | 8 ++++++++
 arch/arm/boot/dts/exynos5420.dtsi             | 4 ++--
 arch/arm/boot/dts/exynos5800-peach-pi.dts     | 8 ++++++++
 arch/arm/configs/exynos_defconfig             | 1 +
 5 files changed, 23 insertions(+), 2 deletions(-)

-- 
2.1.0



Sjoerd Simons (3):
  ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi
  ARM: dts: exynos: Explicitly set dr_mode on arndale-octa
  ARM: exynos_defconfig: enable USB gadget support

 arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts    | 8 ++++++++
 arch/arm/boot/dts/exynos5420.dtsi             | 4 ++--
 arch/arm/boot/dts/exynos5800-peach-pi.dts     | 8 ++++++++
 arch/arm/configs/exynos_defconfig             | 1 +
 5 files changed, 23 insertions(+), 2 deletions(-)

-- 
2.1.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/3 v4] ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi

[Sjoerd Simons]

In case the optional dr_mode property isn't set in the dwc3 nodes the
the controller will go into OTG mode iff both USB host and USB gadget
functionality are enabled in the kernel configuration. Unfortunately this
results in USB not working on exynos5420-peach-pit and
exynos5800-peach-pi with such a kernel configuration unless manually
change the mode. To resolve that explicitly configure the dual role
mode as host

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Andreas Färber <afaerber@suse.de>
---
Changes in v2: alphabetically sort the dts entries
Changes in v3: Fix typo in commit message
Changes in v4: Rebased on linux-samsung for-next

 arch/arm/boot/dts/exynos5420-peach-pit.dts | 8 ++++++++
 arch/arm/boot/dts/exynos5420.dtsi          | 4 ++--
 arch/arm/boot/dts/exynos5800-peach-pi.dts  | 8 ++++++++
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 17dae508..9a050e1 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -841,6 +841,14 @@
 	status = "okay";
 };
 
+&usbdrd_dwc3_0 {
+	dr_mode = "host";
+};
+
+&usbdrd_dwc3_1 {
+	dr_mode = "host";
+};
+
 &usbdrd_phy0 {
 	vbus-supply = <&usb300_vbus_reg>;
 };
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index bfe056d..8617a03 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -815,7 +815,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		dwc3 {
+		usbdrd_dwc3_0: dwc3 {
 			compatible = "snps,dwc3";
 			reg = <0x12000000 0x10000>;
 			interrupts = <0 72 0>;
@@ -841,7 +841,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		dwc3 {
+		usbdrd_dwc3_1: dwc3 {
 			compatible = "snps,dwc3";
 			reg = <0x12400000 0x10000>;
 			interrupts = <0 73 0>;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 4d1492e..e8fdda8 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -829,6 +829,14 @@
 	status = "okay";
 };
 
+&usbdrd_dwc3_0 {
+	dr_mode = "host";
+};
+
+&usbdrd_dwc3_1 {
+	dr_mode = "host";
+};
+
 &usbdrd_phy0 {
 	vbus-supply = <&usb300_vbus_reg>;
 };
-- 
2.1.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/3] ARM: dts: exynos: Explicitly set dr_mode on arndale-octa

[Sjoerd Simons]

Explicitly set the dr_mode for the second dwc3 controller on the
Arndale Octa board to host mode. This is required to ensure the
controller is initialized in the right mode if the kernel is build with
USB gadget support

Reported-By: Andreas Färber <afaerber@suse.de>
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 Changes in v3: new patch
 Changes in v4: Rebased on linux-samsung for-next

 arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index 70a559c..7508099 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -367,3 +367,7 @@
 		};
 	};
 };
+
+&usbdrd_dwc3_1 {
+	dr_mode = "host";
+};
-- 
2.1.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 3/3] ARM: exynos_defconfig: enable USB gadget support

[Sjoerd Simons]

Enable USB gadget support without support for any specific gadgets to
more easily catch cases where a devices dts doesn't specify the usb
controllers dr_mode while it should.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 Changes in v4: Rebased on linux-samsung for-next

 arch/arm/configs/exynos_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index b14d8c3..2cf22bb 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -54,6 +54,7 @@ CONFIG_SMSC911X=y
 CONFIG_USB_USBNET=y
 CONFIG_USB_NET_SMSC75XX=y
 CONFIG_USB_NET_SMSC95XX=y
+CONFIG_USB_GADGET=y
 CONFIG_INPUT_EVDEV=y
 CONFIG_KEYBOARD_GPIO=y
 CONFIG_KEYBOARD_CROS_EC=y
-- 
2.1.0

Re: [PATCH 0/3 v4] Fix Exynos USB on kernels with USB Gadget support

[Kukjin Kim]

On 09/24/14 16:57, Sjoerd Simons wrote:
> Same patches as v3 but rebased on
> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/log/?h=for-next
>
Thanks, applied.

- Kukjin

> When building a kernel with support for both USB host and USB Gadget support on
> the dwc3 controller on the Exynos5 soc will go into USB OTG mode unless
> otherwise specified in the dtb, which is unhelpful for boards hooked up to run
> as USB host.
>
> First patch in this set explicitely set the dual-role mode for the dwc3
> controller on Peach pi and Peach pit boards to host mode. Second patch adds
> similar updates for Arndale Octa as reported by Andreas Färber. Last patch
> enables gadget mode in the default exynos config to more easily catch/trigger
> issues like these.
>
> I suspect the Samsung SMDK5420 DTS might need similar changes, so it would be
> great if users of those board could verify this.
>
> Changes in v2: alphabetically sort the dts entries
> Changes in v3: Add DTS updates for arndale octa
> Changes in v4: Rebased on todays linux-samsungs for-next branch
>
> Sjoerd Simons (3):
>    ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi
>    ARM: dts: exynos: Explicitly set dr_mode on arndale-octa
>    ARM: exynos_defconfig: enable USB gadget support
>
>   arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
>   arch/arm/boot/dts/exynos5420-peach-pit.dts    | 8 ++++++++
>   arch/arm/boot/dts/exynos5420.dtsi             | 4 ++--
>   arch/arm/boot/dts/exynos5800-peach-pi.dts     | 8 ++++++++
>   arch/arm/configs/exynos_defconfig             | 1 +
>   5 files changed, 23 insertions(+), 2 deletions(-)