From: Joe.C <yingjoe.chen@mediatek.com>
To: srv_hongzhou.yang@mediatek.com
Cc: Mark Rutland <mark.rutland@arm.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Russell King <linux@arm.linux.org.uk>,
srv_heupstream@mediatek.com, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Hongzhou Yang <hongzhou.yang@mediatek.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
=Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: mediatek: Add Pinctrl/GPIO driver for mt8135.
Date: Fri, 19 Sep 2014 21:47:40 +0800 [thread overview]
Message-ID: <1411134460.27173.8.camel@mtksdaap41> (raw)
In-Reply-To: <1411127306-13677-3-git-send-email-srv_hongzhou.yang@mediatek.com>
On Fri, 2014-09-19 at 19:48 +0800, srv_hongzhou.yang@mediatek.com wrote:
> +
> +static const struct pinmux_ops mt_pmx_ops = {
> + .get_functions_count = mt_pmx_get_funcs_cnt,
> + .get_function_name = mt_pmx_get_func_name,
> + .get_function_groups = mt_pmx_get_func_groups,
> + .enable = mt_pmx_enable,
> + .disable = mt_pmx_disable,
> + .gpio_set_direction = mt_pmx_gpio_set_direction,
> +};
> +
It seems pinmux_ops.disable is removed in commit commit
2243a87d90b42eb38bc281957df3e57c712b5e56. So this will cause build
error. This should be fixed in next version.
../drivers/pinctrl/mediatek/pinctrl-mtk-common.c:566:2: error: unknown
field 'disable' specified in initializer
../drivers/pinctrl/mediatek/pinctrl-mtk-common.c:566:2: warning:
initialization from incompatible pointer type [enabled by default]
../drivers/pinctrl/mediatek/pinctrl-mtk-common.c:566:2: warning: (near
initialization for 'mt_pmx_ops.gpio_request_enable') [enabled by
default]
Joe.C
next prev parent reply other threads:[~2014-09-19 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 11:48 [PATCH 0/4] Add Mediatek SoC Pinctrl/GPIO driver for MT8135 srv_hongzhou.yang
2014-09-19 11:48 ` [PATCH 1/4] arm: mediatek: Add config option for mediatek SoCs srv_hongzhou.yang
2014-09-19 11:48 ` [PATCH 2/4] ARM: mediatek: Add Pinctrl/GPIO driver for mt8135 srv_hongzhou.yang
2014-09-19 13:47 ` Joe.C [this message]
2014-09-19 14:33 ` Matthias Brugger
2014-09-19 11:48 ` [PATCH 3/4] ARM: dts: mt8135: Add pinctrl node " srv_hongzhou.yang
2014-09-19 11:48 ` [PATCH 4/4] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx srv_hongzhou.yang
2014-09-19 13:48 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411134460.27173.8.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=ashwin.chaugule@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=hongzhou.yang@mediatek.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=srv_hongzhou.yang@mediatek.com \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).