From: Heiko Stuebner <heiko@sntech.de>
To: sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
dianders@chromium.org, heiko@sntech.de,
Heiko Stuebner <heiko.stuebner@bq.com>
Subject: [PATCH v2 3/3] power: gpio-charger: do not use gpio value directly
Date: Sun, 21 Sep 2014 22:05:23 +0200 [thread overview]
Message-ID: <1411329923-15912-4-git-send-email-heiko@sntech.de> (raw)
In-Reply-To: <1411329923-15912-1-git-send-email-heiko@sntech.de>
From: Heiko Stuebner <heiko.stuebner@bq.com>
Some gpio implementations return interesting values for gpio_get_value when
the value is not 0 - as seen on a imx6sl board. Therefore do not use the
value returned from gpio_get_value directly but simply check for 0 or not 0.
Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com>
---
drivers/power/gpio-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c
index 5fe6879..ce99a29 100644
--- a/drivers/power/gpio-charger.c
+++ b/drivers/power/gpio-charger.c
@@ -57,7 +57,7 @@ static int gpio_charger_get_property(struct power_supply *psy,
switch (psp) {
case POWER_SUPPLY_PROP_ONLINE:
- val->intval = gpio_get_value_cansleep(pdata->gpio);
+ val->intval = gpio_get_value_cansleep(pdata->gpio) ? 1 : 0;
val->intval ^= pdata->gpio_active_low;
break;
default:
--
1.9.0
next prev parent reply other threads:[~2014-09-21 20:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 20:05 [PATCH v2 0/3] gpio-charger: add devicetree support Heiko Stuebner
2014-09-21 20:05 ` [PATCH v2 1/3] dt-bindings: document gpio-charger bindings Heiko Stuebner
2014-09-22 16:51 ` Doug Anderson
2014-09-21 20:05 ` [PATCH v2 2/3] power: gpio-charger: add device tree support Heiko Stuebner
2014-09-22 16:48 ` Doug Anderson
2014-09-23 12:03 ` Heiko Stübner
2014-09-23 15:59 ` Doug Anderson
2014-09-21 20:05 ` Heiko Stuebner [this message]
2014-09-22 16:50 ` [PATCH v2 3/3] power: gpio-charger: do not use gpio value directly Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411329923-15912-4-git-send-email-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=heiko.stuebner@bq.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).