From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH v3 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver Date: Thu, 25 Sep 2014 22:27:57 +0300 Message-ID: <1411673277.28648.5.camel@mm-sol.com> References: <1411563415-11933-1-git-send-email-svarbanov@mm-sol.com> <1411563415-11933-2-git-send-email-svarbanov@mm-sol.com> <1411649225.18580.134.camel@iivanov-dev> <54243533.7080809@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54243533.7080809-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stanimir Varbanov Cc: Ian Campbell , Pawel Moll , Rob Herring , Kumar Gala , Mark Rutland , Grant Likely , Jonathan Cameron , Arnd Bergmann , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg Kroah-Hartman , Lars-Peter Clausen , Hartmut Knaack , Angelo Compagnucci , Doug Anderson , Fugang Duan , Johannes Thumshirn , Jean Delvare , Philippe Reynes , Lee Jones , Josh Cartwright , Stephen Boyd List-Id: devicetree@vger.kernel.org On Thu, 2014-09-25 at 18:30 +0300, Stanimir Varbanov wrote: > Hi Ivan, > > On 09/25/2014 03:47 PM, Ivan T. Ivanov wrote: > > > > Hi Stan, few comment bellow. > > > > On Wed, 2014-09-24 at 15:56 +0300, Stanimir Varbanov wrote: > >> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has > >> 15bits resolution and register space inside PMIC accessible across > >> SPMI bus. > >> > >> The vadc driver registers itself through IIO interface. > >> > >> Signed-off-by: Stanimir Varbanov > >> Signed-off-by: Ivan T. Ivanov > >> --- > >> drivers/iio/adc/Kconfig | 10 + > >> drivers/iio/adc/Makefile | 1 + > >> drivers/iio/adc/qcom-spmi-vadc.c | 1029 +++++++++++++++++++++++++ > >> include/dt-bindings/iio/qcom,spmi-pmic-vadc.h | 119 +++ > >> 4 files changed, 1159 insertions(+), 0 deletions(-) > >> create mode 100644 drivers/iio/adc/qcom-spmi-vadc.c > >> create mode 100644 include/dt-bindings/iio/qcom,spmi-pmic-vadc.h > >> > >> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > >> index 11b048a..ec48360 100644 > >> --- a/drivers/iio/adc/Kconfig > >> +++ b/drivers/iio/adc/Kconfig > >> @@ -206,6 +206,16 @@ config NAU7802 > >> To compile this driver as a module, choose M here: the > >> module will be called nau7802. > >> > >> +config QCOM_SPMI_VADC > >> + tristate "Qualcomm SPMI PMIC voltage ADC" > >> + depends on SPMI > > > > + select REGMAP_SPMI > > I'd suggest MFD_SPMI_PMIC symbol of the parent driver instead? The > parent MFD PMIC driver already selects REGMAP_SPMI and depends on SPMI. +1 for depends on MFD_SPMI_PMIC. > > > > > > > > >> + > >> +static int vadc_read(struct vadc_priv *vadc, u16 offset, u8 *data) > >> +{ > >> + return regmap_bulk_read(vadc->regmap, vadc->base + offset, data, 1); > > > > just regmap_read() ? > > No, regmap_read() expects unsigned int *val as an argument hence I will > need temporary variable. I had a comment to rework this on the first > version of the patchset. Oops, So I should expect the same comment on my IADC driver :-) > > > > >> +} > >> + > > > > General comment, most of the dev_dbg looks like legitimate dev_err's to me. > > I've decided to not flood console with messages. If someone wants to > debug why the driver doesn't probed he can define DEBUG. Ok, is up to you. Regards, Ivan