From: Ankit Jindal <ankit.jindal@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: "Hans J. Koch" <hjk@hansjkoch.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
patches@apm.com, linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Tushar Jagad <tushar.jagad@linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org,
Ankit Jindal <ankit.jindal@linaro.org>
Subject: [PATCH v2 2/6] uio: Add new UIO_MEM_PHYS_CACHE type for mem regions
Date: Tue, 30 Sep 2014 09:56:05 +0530 [thread overview]
Message-ID: <1412051169-9142-3-git-send-email-ankit.jindal@linaro.org> (raw)
In-Reply-To: <1412051169-9142-1-git-send-email-ankit.jindal@linaro.org>
Currently, three types of mem regions are supported: UIO_MEM_PHYS,
UIO_MEM_LOGICAL and UIO_MEM_VIRTUAL. Among these UIO_MEM_PHYS helps
UIO driver export physcial memory to user space as non-cacheable
user memory. Typcially memory-mapped registers of a device are exported
to user space as UIO_MEM_PHYS type mem region. The UIO_MEM_PHYS type
is not efficient if dma-capable devices are capable of maintaining coherency
with CPU caches.
This patch adds new type UIO_MEM_PHYS_CACHE for mem regions to enable
cacheable access to physical memory from user space.
Signed-off-by: Ankit Jindal <ankit.jindal@linaro.org>
Signed-off-by: Tushar Jagad <tushar.jagad@linaro.org>
---
drivers/uio/uio.c | 11 ++++++++---
include/linux/uio_driver.h | 1 +
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 97e6444..120a84b 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -644,7 +644,7 @@ static const struct vm_operations_struct uio_physical_vm_ops = {
#endif
};
-static int uio_mmap_physical(struct vm_area_struct *vma)
+static int uio_mmap_physical(struct vm_area_struct *vma, bool cacheable)
{
struct uio_device *idev = vma->vm_private_data;
int mi = uio_find_mem_index(vma);
@@ -659,7 +659,9 @@ static int uio_mmap_physical(struct vm_area_struct *vma)
return -EINVAL;
vma->vm_ops = &uio_physical_vm_ops;
- vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
+
+ if (!cacheable)
+ vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
/*
* We cannot use the vm_iomap_memory() helper here,
@@ -707,10 +709,13 @@ static int uio_mmap(struct file *filep, struct vm_area_struct *vma)
switch (idev->info->mem[mi].memtype) {
case UIO_MEM_PHYS:
- return uio_mmap_physical(vma);
+ return uio_mmap_physical(vma, false);
case UIO_MEM_LOGICAL:
case UIO_MEM_VIRTUAL:
return uio_mmap_logical(vma);
+ case UIO_MEM_PHYS_CACHE:
+ return uio_mmap_physical(vma, true);
+
default:
return -EINVAL;
}
diff --git a/include/linux/uio_driver.h b/include/linux/uio_driver.h
index 1ad4724..40ca3f3 100644
--- a/include/linux/uio_driver.h
+++ b/include/linux/uio_driver.h
@@ -118,6 +118,7 @@ extern void uio_event_notify(struct uio_info *info);
#define UIO_MEM_PHYS 1
#define UIO_MEM_LOGICAL 2
#define UIO_MEM_VIRTUAL 3
+#define UIO_MEM_PHYS_CACHE 4
/* defines for uio_port->porttype */
#define UIO_PORT_NONE 0
--
1.7.9.5
next prev parent reply other threads:[~2014-09-30 4:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 4:26 [PATCH v2 0/6] UIO driver for APM X-Gene QMTM Ankit Jindal
2014-09-30 4:26 ` [PATCH v2 1/6] uio: code style cleanup Ankit Jindal
2014-09-30 4:26 ` Ankit Jindal [this message]
2014-09-30 4:26 ` [PATCH v2 3/6] Documentation: Update documentation for UIO_MEM_PHYS_CACHE Ankit Jindal
2014-09-30 4:26 ` [PATCH v2 4/6] drivers: uio: Add X-Gene QMTM UIO driver Ankit Jindal
2014-09-30 6:05 ` Varka Bhadram
2014-10-21 5:52 ` Ankit Jindal
2014-09-30 4:26 ` [PATCH v2 5/6] Documentation: dt-bindings: Add binding info for " Ankit Jindal
2014-09-30 4:26 ` [PATCH v2 6/6] MAINTAINERS: Add entry for APM " Ankit Jindal
[not found] ` <1412051169-9142-1-git-send-email-ankit.jindal-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-10-09 8:44 ` [PATCH v2 0/6] UIO driver for APM X-Gene QMTM Ankit Jindal
[not found] ` <CAPTm99V-xyXa7WQG2jzDz19gotJ0aQRPk_rb5ukvUpdFyFabfw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-09 12:06 ` Arnd Bergmann
2014-10-09 12:17 ` Ankit Jindal
[not found] ` <CAPTm99WBE7RnGYNZsCfsenYcR3wNSVYOg--90_s1Ji_=Vj5myA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-09 12:22 ` Richard Weinberger
[not found] ` <CAFLxGvxkL33_TVaf6dT9joC8dzU9uvJVG-GJdDKXPsMVAvQhvw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-09 12:30 ` Ankit Jindal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412051169-9142-3-git-send-email-ankit.jindal@linaro.org \
--to=ankit.jindal@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hjk@hansjkoch.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@apm.com \
--cc=robh+dt@kernel.org \
--cc=tushar.jagad@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).