From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 3/5] regulator: dt-bindings: Add regulator-initial-mode support Date: Thu, 09 Oct 2014 10:45:55 +0200 Message-ID: <1412844355.1316.15.camel@AMDC1943> References: <1412775847-15213-1-git-send-email-javier.martinez@collabora.co.uk> <1412775847-15213-4-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <1412775847-15213-4-git-send-email-javier.martinez@collabora.co.uk> Sender: linux-samsung-soc-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Mark Brown , Doug Anderson , Chanwoo Choi , Olof Johansson , Chris Zhong , Abhilash Kesavan , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On =C5=9Bro, 2014-10-08 at 15:44 +0200, Javier Martinez Canillas wrote: > Regulators can run on different operating modes (opmodes). This allow= s > systems to choose the most efficient opmode for each regulator. The > regulator core defines a set of generic modes so each system can defi= ne > the opmode in these generic terms and drivers are responsible to map = the > generic modes to the ones supported by each hardware according to the= ir > data-sheet. >=20 > Signed-off-by: Javier Martinez Canillas > --- > Documentation/devicetree/bindings/regulator/regulator.txt | 8 ++++++= ++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/regulator/regulator.tx= t b/Documentation/devicetree/bindings/regulator/regulator.txt > index ccba90b..a9d6767 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > @@ -23,6 +23,14 @@ Optional properties: > state among following defined suspend states: > <3>: PM_SUSPEND_MEM - Setup regulator according to regulator-state= -mem > <4>: PM_SUSPEND_MAX - Setup regulator according to regulator-state= -disk > +- regulator-initial-mode: initial regulator operating mode. One of f= ollowing: > + <1>: REGULATOR_MODE_FAST - Regulator can handle fast changes. > + <2>: REGULATOR_MODE_NORMAL - Normal regulator power supply mode. > + <4>: REGULATOR_MODE_IDLE - Regulator runs in a more efficient mo= de. > + <8>: REGULATOR_MODE_STANDBY - Regulator runs in the most efficient = mode. > + modes are defined in the dt-bindings/regulator/regulator.h header = and can be > + used in device tree sources files. If no mode is defined, then the= OS will not > + manage the operating mode and the HW default values will be used i= nstead. > - regulator-state-mem sub-root node for Suspend-to-RAM mode > : suspend to memory, the device goes to sleep, but all data stored= in memory, > only some external interrupt can wake the device. I agree with the need and the idea of generic bindings for operating modes for regulators. At least for Exynos-based boards the PMICs have quite similar opmodes. However the regulator mode from consumer.h (and in above doc) does not match well with these opmodes. Example is yours patch 4/5: - idle ("more efficient mode") maps to "low power mode in suspend", - standby ("the most efficient mode") maps to "OFF in suspend". Actually we are not enable "efficient modes" but we configure how the regulator will behave when AP says - I'm suspending. Another issue: is "initial_state" not doing all this already? Best regards, Krzysztof