From: Joe.C <yingjoe.chen@mediatek.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Sricharan R <r.sricharan@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
yh.chen@mediatek.com, arm@kernel.org, nathan.chung@mediatek.com,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
yingjoe.chen@gmail.com, Marc Zyngier <marc.zyngier@arm.com>,
Matt Porter <mporter@linaro.org>,
Marc Carino <marc.ceeeee@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, hc.yen@mediatek.com,
linux-kernel@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Sascha Hauer <kernel@pengutronix.de>,
Ol
Subject: Re: [PATCH v3 4/7] ARM: mediatek: Add sysirq interrupt polarity support
Date: Thu, 9 Oct 2014 22:53:45 +0800 [thread overview]
Message-ID: <1412866425.23455.1.camel@mtksdaap41> (raw)
In-Reply-To: <2076856.iIXavsNzjc@wuerfel>
On Thu, 2014-10-09 at 16:37 +0200, Arnd Bergmann wrote:
> On Thursday 09 October 2014 22:29:37 Joe. C wrote:
>
> > +static int __init mtk_sysirq_of_init(struct device_node *node,
> > + struct device_node *parent)
> > +{
> > + struct device_node *parent_node;
> > + struct irq_domain *domain, *domain_parent = NULL;
> > + struct mt_sysirq_chip_data *chip_data;
> > + int ret = 0;
> > +
> > + parent_node = of_irq_find_parent(node);
> > + if (parent_node) {
> > + domain_parent = irq_find_host(parent_node);
> > + of_node_put(parent_node);
> > + }
>
> Just a small comment: I think the 'parent' argument to the function
> already contains the device node you are looking up here, so
> no need for the second variable or _find_parent call.
>
> This means you can also drop the = NULL assignment for the
> domain.
>
> Arnd
Thanks for point this out. I'll fix this in the next version.
Joe.C
next prev parent reply other threads:[~2014-10-09 14:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 14:29 [PATCH v3 0/7] ARM: mediatek: Add support for interrupt polarity Joe.C
2014-10-09 14:29 ` [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check Joe.C
2014-10-13 12:11 ` Marc Zyngier
[not found] ` <543BC186.2050701-5wv7dgnIgG8@public.gmane.org>
2014-10-13 14:13 ` Jiang Liu
2014-10-09 14:29 ` [PATCH v3 2/7] genirq: Add more helper functions to support stacked irq_chip Joe.C
2014-10-09 14:29 ` [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain Joe.C
2014-10-09 16:59 ` Marc Zyngier
[not found] ` <5436BF0C.1030508-5wv7dgnIgG8@public.gmane.org>
2014-10-09 17:22 ` Arnd Bergmann
2014-10-13 10:43 ` Joe.C
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 8:56 ` Marc Zyngier
[not found] ` <543B93B4.3040404-5wv7dgnIgG8@public.gmane.org>
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:27 ` Arnd Bergmann
2014-10-13 9:44 ` Marc Zyngier
2014-10-09 14:29 ` [PATCH v3 4/7] ARM: mediatek: Add sysirq interrupt polarity support Joe.C
2014-10-09 14:37 ` Arnd Bergmann
2014-10-09 14:53 ` Joe.C [this message]
2014-10-13 13:43 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
2014-10-09 14:29 ` [PATCH v3 5/7] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi Joe.C
2014-10-09 14:29 ` [PATCH v3 6/7] dt-bindings: add irq domain parent binding Joe.C
[not found] ` <1412864980-20273-7-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2014-10-09 14:57 ` Mark Rutland
2014-10-09 14:29 ` [PATCH v3 7/7] dt-bindings: add bindings for mediatek sysirq Joe.C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412866425.23455.1.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=f.fainelli@gmail.com \
--cc=grant.likely@linaro.org \
--cc=hc.yen@mediatek.com \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.ceeeee@gmail.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mporter@linaro.org \
--cc=nathan.chung@mediatek.com \
--cc=pawel.moll@arm.com \
--cc=r.sricharan@ti.com \
--cc=robh+dt@kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
--cc=yh.chen@mediatek.com \
--cc=yingjoe.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).