From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Doug Anderson <dianders@chromium.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Olof Johansson <olof@lixom.net>, Chris Zhong <zyw@rock-chips.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: [PATCH v2 4/7] regulator: max77802: Add header for operating modes
Date: Thu, 16 Oct 2014 18:48:50 +0200 [thread overview]
Message-ID: <1413478133-2577-5-git-send-email-javier.martinez@collabora.co.uk> (raw)
In-Reply-To: <1413478133-2577-1-git-send-email-javier.martinez@collabora.co.uk>
Add a header file for the max77802 constants that could be shared between
the regulator driver and Device Tree source files. Also, remove standby
and off opmodes since only normal and low power are valid operating modes.
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
Changes since v1: None
drivers/regulator/max77802.c | 1 +
include/dt-bindings/regulator/maxim,max77802.h | 18 ++++++++++++++++++
include/linux/mfd/max77686.h | 7 -------
3 files changed, 19 insertions(+), 7 deletions(-)
create mode 100644 include/dt-bindings/regulator/maxim,max77802.h
diff --git a/drivers/regulator/max77802.c b/drivers/regulator/max77802.c
index 3abf99d..5839c45 100644
--- a/drivers/regulator/max77802.c
+++ b/drivers/regulator/max77802.c
@@ -33,6 +33,7 @@
#include <linux/regulator/of_regulator.h>
#include <linux/mfd/max77686.h>
#include <linux/mfd/max77686-private.h>
+#include <dt-bindings/regulator/maxim,max77802.h>
/* Default ramp delay in case it is not manually set */
#define MAX77802_RAMP_DELAY 100000 /* uV/us */
diff --git a/include/dt-bindings/regulator/maxim,max77802.h b/include/dt-bindings/regulator/maxim,max77802.h
new file mode 100644
index 0000000..cf28631
--- /dev/null
+++ b/include/dt-bindings/regulator/maxim,max77802.h
@@ -0,0 +1,18 @@
+/*
+ * Copyright (C) 2014 Google, Inc
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * Device Tree binding constants for the Maxim 77802 PMIC regulators
+ */
+
+#ifndef _DT_BINDINGS_REGULATOR_MAXIM_MAX77802_H
+#define _DT_BINDINGS_REGULATOR_MAXIM_MAX77802_H
+
+/* Regulator operating modes */
+#define MAX77802_OPMODE_LP 1
+#define MAX77802_OPMODE_NORMAL 3
+
+#endif /* _DT_BINDINGS_REGULATOR_MAXIM_MAX77802_H */
diff --git a/include/linux/mfd/max77686.h b/include/linux/mfd/max77686.h
index 7e6dc4b..553f7d0 100644
--- a/include/linux/mfd/max77686.h
+++ b/include/linux/mfd/max77686.h
@@ -131,13 +131,6 @@ enum max77686_opmode {
MAX77686_OPMODE_STANDBY,
};
-enum max77802_opmode {
- MAX77802_OPMODE_OFF,
- MAX77802_OPMODE_STANDBY,
- MAX77802_OPMODE_LP,
- MAX77802_OPMODE_NORMAL,
-};
-
struct max77686_opmode_data {
int id;
int mode;
--
2.1.0
next prev parent reply other threads:[~2014-10-16 16:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 16:48 [PATCH v2 0/7] Add max77802 regulator operating mode support Javier Martinez Canillas
2014-10-16 16:48 ` [PATCH v2 1/7] regulator: max77802: Add .{get,set}_mode callbacks Javier Martinez Canillas
2014-10-17 12:39 ` Mark Brown
2014-10-16 16:48 ` [PATCH v2 2/7] regulator: max77802: Add set suspend mode for BUCKs and simplify code Javier Martinez Canillas
2014-10-17 12:39 ` Mark Brown
2014-10-16 16:48 ` [PATCH v2 3/7] regulator: max77802: Don't treat OFF as an operating mode Javier Martinez Canillas
2014-10-17 12:44 ` Mark Brown
2014-10-16 16:48 ` Javier Martinez Canillas [this message]
[not found] ` <1413478133-2577-5-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-10-17 8:04 ` [PATCH v2 4/7] regulator: max77802: Add header for operating modes Lee Jones
2014-10-17 12:45 ` Mark Brown
2014-10-16 16:48 ` [PATCH v2 5/7] regulator: max77802: Document regulator opmode DT properties Javier Martinez Canillas
2014-10-17 11:57 ` Mark Brown
[not found] ` <20141017115701.GE1820-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-10-17 12:39 ` Javier Martinez Canillas
[not found] ` <54410DF3.5020005-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-10-17 13:54 ` Mark Brown
[not found] ` <20141017135441.GR1820-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-10-17 14:18 ` Javier Martinez Canillas
2014-10-16 16:48 ` [PATCH v2 6/7] regulator: max77802: Parse regulator operating mode properties Javier Martinez Canillas
2014-10-16 16:48 ` [PATCH v2 7/7] ARM: dts: Configure regulators for suspend on exynos Peach boards Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413478133-2577-5-git-send-email-javier.martinez@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=k.kozlowski@samsung.com \
--cc=kesavan.abhilash@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).