From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v3 1/3] ARM: meson: reset: Add reset controller for MesonX SoCs Date: Mon, 20 Oct 2014 17:40:11 +0200 Message-ID: <1413819611.3107.6.camel@pengutronix.de> References: <1413803985-8363-1-git-send-email-carlo@caione.org> <1413803985-8363-2-git-send-email-carlo@caione.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1413803985-8363-2-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Carlo Caione Cc: grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.galvani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jerry.cao-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org, victor.wan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org List-Id: devicetree@vger.kernel.org Am Montag, den 20.10.2014, 13:19 +0200 schrieb Carlo Caione: > Hi Philipp, > from the documentation and the sources I have, it seems that in the register > together with the bits for resetting the ICs there are also bits for turning > the ICs on and off. I really wanted to avoid create a new of_xlate function > just to map the reset IDs to the correct bit in the register so I left the > nr_resets to BITS_PER_LONG and I'm using the default of_xlate. > This way I can also avoid to use obscure reset IDs to be remapped when I can > use directly the bit number in the register as reset ID. I'm fine with reusing of_reset_simple_xlate and using the bit offsets as reset control number. Do you already know what abstraction you'll choose for the IC enable bits? (Are those clock gates, or maybe power domains?) Hopefully the documentation you obtained will help to decide. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html