[PATCH 0/4] ARM: dts: dra72-evm: NAND and USB support

[PATCH 0/4] ARM: dts: dra72-evm: NAND and USB support

[Roger Quadros]

Hi Tony,

These patches add NAND and USB support for DRA72-evm.
Patches are for v3.19 and based on v3.18-rc1.

I've tested that NAND and USB host works fine on DRA72-evm.

I couldn't get USB gadget mode to work. It doesn't work on DRA7-evm either.
There seems to be some issue at the driver level. The dts entries are correct though.

cheers,
-roger

George Cherian (1):
  ARM: dts: dra72-evm: Enable USB support for dra72-evm.

Roger Quadros (3):
  ARM: dts: dra72-evm: Add NAND support
  ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi
  ARM: dts: dra72-evm: Add regulator information to USB2 PHYs

 arch/arm/boot/dts/dra7.dtsi     |  20 ------
 arch/arm/boot/dts/dra72-evm.dts | 147 ++++++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/dra74x.dtsi   |  22 ++++++
 3 files changed, 169 insertions(+), 20 deletions(-)

-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/4] ARM: dts: dra72-evm: Add NAND support

[Roger Quadros]

DRA72-evm has a 256MB 16-bit wide NAND chip. Add
pinmux and NAND node.

The NAND chips 'Chip select' and 'Write protect' can be
controlled using DIP Switch SW5. To use NAND,
the switch must be configured like so:

SW5.1 (NAND_SELn) = ON (LOW)
SW5.9 (GPMC_WPN) = OFF (HIGH)

Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/boot/dts/dra72-evm.dts | 115 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 115 insertions(+)

diff --git a/arch/arm/boot/dts/dra72-evm.dts b/arch/arm/boot/dts/dra72-evm.dts
index 4107428..6f5417a 100644
--- a/arch/arm/boot/dts/dra72-evm.dts
+++ b/arch/arm/boot/dts/dra72-evm.dts
@@ -26,6 +26,33 @@
 			0x404 (PIN_INPUT | MUX_MODE0) /* i2c1_scl.i2c1_scl */
 		>;
 	};
+
+	nand_default: nand_default {
+		pinctrl-single,pins = <
+			0x0	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad0 */
+			0x4	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad1 */
+			0x8	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad2 */
+			0xc	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad3 */
+			0x10	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad4 */
+			0x14	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad5 */
+			0x18	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad6 */
+			0x1c	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad7 */
+			0x20	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad8 */
+			0x24	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad9 */
+			0x28	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad10 */
+			0x2c	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad11 */
+			0x30	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad12 */
+			0x34	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad13 */
+			0x38	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad14 */
+			0x3c	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad15 */
+			0xb4	(PIN_OUTPUT | MUX_MODE0) /* gpmc_cs0 */
+			0xc4	(PIN_OUTPUT | MUX_MODE0) /* gpmc_advn_ale */
+			0xcc	(PIN_OUTPUT | MUX_MODE0) /* gpmc_wen */
+			0xc8	(PIN_OUTPUT | MUX_MODE0) /* gpmc_oen_ren */
+			0xd0	(PIN_OUTPUT | MUX_MODE0) /* gpmc_ben0 */
+			0xd8	(PIN_INPUT  | MUX_MODE0) /* gpmc_wait0 */
+		>;
+	};
 };
 
 &i2c1 {
@@ -142,3 +169,91 @@
 &uart1 {
 	status = "okay";
 };
+
+&elm {
+	status = "okay";
+};
+
+&gpmc {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&nand_default>;
+	ranges = <0 0 0 0x01000000>;	/* minimum GPMC partition = 16MB */
+	nand@0,0 {
+		/* To use NAND, DIP switch SW5 must be set like so:
+		 * SW5.1 (NAND_SELn) = ON (LOW)
+		 * SW5.9 (GPMC_WPN) = OFF (HIGH)
+		 */
+		reg = <0 0 4>;		/* device IO registers */
+		ti,nand-ecc-opt = "bch8";
+		ti,elm-id = <&elm>;
+		nand-bus-width = <16>;
+		gpmc,device-width = <2>;
+		gpmc,sync-clk-ps = <0>;
+		gpmc,cs-on-ns = <0>;
+		gpmc,cs-rd-off-ns = <80>;
+		gpmc,cs-wr-off-ns = <80>;
+		gpmc,adv-on-ns = <0>;
+		gpmc,adv-rd-off-ns = <60>;
+		gpmc,adv-wr-off-ns = <60>;
+		gpmc,we-on-ns = <10>;
+		gpmc,we-off-ns = <50>;
+		gpmc,oe-on-ns = <4>;
+		gpmc,oe-off-ns = <40>;
+		gpmc,access-ns = <40>;
+		gpmc,wr-access-ns = <80>;
+		gpmc,rd-cycle-ns = <80>;
+		gpmc,wr-cycle-ns = <80>;
+		gpmc,bus-turnaround-ns = <0>;
+		gpmc,cycle2cycle-delay-ns = <0>;
+		gpmc,clk-activation-ns = <0>;
+		gpmc,wait-monitoring-ns = <0>;
+		gpmc,wr-data-mux-bus-ns = <0>;
+		/* MTD partition table */
+		/* All SPL-* partitions are sized to minimal length
+		 * which can be independently programmable. For
+		 * NAND flash this is equal to size of erase-block */
+		#address-cells = <1>;
+		#size-cells = <1>;
+		partition@0 {
+			label = "NAND.SPL";
+			reg = <0x00000000 0x000020000>;
+		};
+		partition@1 {
+			label = "NAND.SPL.backup1";
+			reg = <0x00020000 0x00020000>;
+		};
+		partition@2 {
+			label = "NAND.SPL.backup2";
+			reg = <0x00040000 0x00020000>;
+		};
+		partition@3 {
+			label = "NAND.SPL.backup3";
+			reg = <0x00060000 0x00020000>;
+		};
+		partition@4 {
+			label = "NAND.u-boot-spl-os";
+			reg = <0x00080000 0x00040000>;
+		};
+		partition@5 {
+			label = "NAND.u-boot";
+			reg = <0x000c0000 0x00100000>;
+		};
+		partition@6 {
+			label = "NAND.u-boot-env";
+			reg = <0x001c0000 0x00020000>;
+		};
+		partition@7 {
+			label = "NAND.u-boot-env.backup1";
+			reg = <0x001e0000 0x00020000>;
+		};
+		partition@8 {
+			label = "NAND.kernel";
+			reg = <0x00200000 0x00800000>;
+		};
+		partition@9 {
+			label = "NAND.file-system";
+			reg = <0x00a00000 0x0f600000>;
+		};
+	};
+};
-- 
1.8.3.2

[PATCH 2/4] ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi

[Roger Quadros]

The 4th USB controller instance present only on the DRA74x family of
devices so move it there.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/boot/dts/dra7.dtsi   | 20 --------------------
 arch/arm/boot/dts/dra74x.dtsi | 22 ++++++++++++++++++++++
 2 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 9cc9843..ea243e0 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1204,26 +1204,6 @@
 			};
 		};
 
-		omap_dwc3_4@48940000 {
-			compatible = "ti,dwc3";
-			ti,hwmods = "usb_otg_ss4";
-			reg = <0x48940000 0x10000>;
-			interrupts = <GIC_SPI 346 IRQ_TYPE_LEVEL_HIGH>;
-			#address-cells = <1>;
-			#size-cells = <1>;
-			utmi-mode = <2>;
-			ranges;
-			status = "disabled";
-			usb4: usb@48950000 {
-				compatible = "snps,dwc3";
-				reg = <0x48950000 0x17000>;
-				interrupts = <GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>;
-				tx-fifo-resize;
-				maximum-speed = "high-speed";
-				dr_mode = "otg";
-			};
-		};
-
 		elm: elm@48078000 {
 			compatible = "ti,am3352-elm";
 			reg = <0x48078000 0xfc0>;      /* device IO registers */
diff --git a/arch/arm/boot/dts/dra74x.dtsi b/arch/arm/boot/dts/dra74x.dtsi
index 3be544c..5667b92 100644
--- a/arch/arm/boot/dts/dra74x.dtsi
+++ b/arch/arm/boot/dts/dra74x.dtsi
@@ -44,4 +44,26 @@
 		interrupts = <GIC_SPI DIRECT_IRQ(131) IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI DIRECT_IRQ(132) IRQ_TYPE_LEVEL_HIGH>;
 	};
+
+	ocp {
+		omap_dwc3_4@48940000 {
+			compatible = "ti,dwc3";
+			ti,hwmods = "usb_otg_ss4";
+			reg = <0x48940000 0x10000>;
+			interrupts = <GIC_SPI 346 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			utmi-mode = <2>;
+			ranges;
+			status = "disabled";
+			usb4: usb@48950000 {
+				compatible = "snps,dwc3";
+				reg = <0x48950000 0x17000>;
+				interrupts = <GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>;
+				tx-fifo-resize;
+				maximum-speed = "high-speed";
+				dr_mode = "otg";
+			};
+		};
+	};
 };
-- 
1.8.3.2

[PATCH 3/4] ARM: dts: dra72-evm: Enable USB support for dra72-evm.

[Roger Quadros]

From: George Cherian <george.cherian@ti.com>

Add USB data and pinctrl for USB.

Signed-off-by: George Cherian <george.cherian@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/dra72-evm.dts | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/dra72-evm.dts b/arch/arm/boot/dts/dra72-evm.dts
index 6f5417a..ad6ec4a 100644
--- a/arch/arm/boot/dts/dra72-evm.dts
+++ b/arch/arm/boot/dts/dra72-evm.dts
@@ -53,6 +53,18 @@
 			0xd8	(PIN_INPUT  | MUX_MODE0) /* gpmc_wait0 */
 		>;
 	};
+
+	usb1_pins: pinmux_usb1_pins {
+		pinctrl-single,pins = <
+			0x280 (PIN_INPUT_SLEW | MUX_MODE0) /* usb1_drvvbus */
+		>;
+	};
+
+	usb2_pins: pinmux_usb2_pins {
+		pinctrl-single,pins = <
+			0x284 (PIN_INPUT_SLEW | MUX_MODE0) /* usb2_drvvbus */
+		>;
+	};
 };
 
 &i2c1 {
@@ -257,3 +269,15 @@
 		};
 	};
 };
+
+&usb1 {
+	dr_mode = "peripheral";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb1_pins>;
+};
+
+&usb2 {
+	dr_mode = "host";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb2_pins>;
+};
-- 
1.8.3.2

[PATCH 4/4] ARM: dts: dra72-evm: Add regulator information to USB2 PHYs

[Roger Quadros]

The ldo4_reg regulator provides power to the USB1 and USB2
High Speed PHYs.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/dra72-evm.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/dra72-evm.dts b/arch/arm/boot/dts/dra72-evm.dts
index ad6ec4a..b135aab 100644
--- a/arch/arm/boot/dts/dra72-evm.dts
+++ b/arch/arm/boot/dts/dra72-evm.dts
@@ -270,6 +270,14 @@
 	};
 };
 
+&usb2_phy1 {
+	phy-supply = <&ldo4_reg>;
+};
+
+&usb2_phy2 {
+	phy-supply = <&ldo4_reg>;
+};
+
 &usb1 {
 	dr_mode = "peripheral";
 	pinctrl-names = "default";
-- 
1.8.3.2

Re: [PATCH 1/4] ARM: dts: dra72-evm: Add NAND support

[Nishanth Menon]

Roger,

On 10/21/2014 05:41 AM, Roger Quadros wrote:
> DRA72-evm has a 256MB 16-bit wide NAND chip. Add
> pinmux and NAND node.
> 
> The NAND chips 'Chip select' and 'Write protect' can be
> controlled using DIP Switch SW5. To use NAND,
> the switch must be configured like so:
> 
> SW5.1 (NAND_SELn) = ON (LOW)
> SW5.9 (GPMC_WPN) = OFF (HIGH)

Could we move this description to the dts as a comment? it would be
little more easier to refer to than figuring it out from git log. I
recollect trying to figure this out while attempting to test out NAND
previously, never actually thought to check in git log. just a
suggestion..

> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
>  arch/arm/boot/dts/dra72-evm.dts | 115 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 115 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra72-evm.dts b/arch/arm/boot/dts/dra72-evm.dts
> index 4107428..6f5417a 100644
> --- a/arch/arm/boot/dts/dra72-evm.dts
> +++ b/arch/arm/boot/dts/dra72-evm.dts
> @@ -26,6 +26,33 @@
>  			0x404 (PIN_INPUT | MUX_MODE0) /* i2c1_scl.i2c1_scl */
>  		>;
>  	};
> +
> +	nand_default: nand_default {
> +		pinctrl-single,pins = <
> +			0x0	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad0 */
> +			0x4	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad1 */
> +			0x8	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad2 */
> +			0xc	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad3 */
> +			0x10	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad4 */
> +			0x14	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad5 */
> +			0x18	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad6 */
> +			0x1c	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad7 */
> +			0x20	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad8 */
> +			0x24	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad9 */
> +			0x28	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad10 */
> +			0x2c	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad11 */
> +			0x30	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad12 */
> +			0x34	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad13 */
> +			0x38	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad14 */
> +			0x3c	(PIN_INPUT  | MUX_MODE0) /* gpmc_ad15 */
> +			0xb4	(PIN_OUTPUT | MUX_MODE0) /* gpmc_cs0 */
> +			0xc4	(PIN_OUTPUT | MUX_MODE0) /* gpmc_advn_ale */
> +			0xcc	(PIN_OUTPUT | MUX_MODE0) /* gpmc_wen */
> +			0xc8	(PIN_OUTPUT | MUX_MODE0) /* gpmc_oen_ren */
> +			0xd0	(PIN_OUTPUT | MUX_MODE0) /* gpmc_ben0 */
> +			0xd8	(PIN_INPUT  | MUX_MODE0) /* gpmc_wait0 */
> +		>;
> +	};
>  };
>  
>  &i2c1 {
> @@ -142,3 +169,91 @@
>  &uart1 {
>  	status = "okay";
>  };
> +
> +&elm {
> +	status = "okay";
> +};
> +
> +&gpmc {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&nand_default>;
> +	ranges = <0 0 0 0x01000000>;	/* minimum GPMC partition = 16MB */
> +	nand@0,0 {
> +		/* To use NAND, DIP switch SW5 must be set like so:
> +		 * SW5.1 (NAND_SELn) = ON (LOW)
> +		 * SW5.9 (GPMC_WPN) = OFF (HIGH)
> +		 */
> +		reg = <0 0 4>;		/* device IO registers */
> +		ti,nand-ecc-opt = "bch8";
> +		ti,elm-id = <&elm>;
> +		nand-bus-width = <16>;
> +		gpmc,device-width = <2>;
> +		gpmc,sync-clk-ps = <0>;
> +		gpmc,cs-on-ns = <0>;
> +		gpmc,cs-rd-off-ns = <80>;
> +		gpmc,cs-wr-off-ns = <80>;
> +		gpmc,adv-on-ns = <0>;
> +		gpmc,adv-rd-off-ns = <60>;
> +		gpmc,adv-wr-off-ns = <60>;
> +		gpmc,we-on-ns = <10>;
> +		gpmc,we-off-ns = <50>;
> +		gpmc,oe-on-ns = <4>;
> +		gpmc,oe-off-ns = <40>;
> +		gpmc,access-ns = <40>;
> +		gpmc,wr-access-ns = <80>;
> +		gpmc,rd-cycle-ns = <80>;
> +		gpmc,wr-cycle-ns = <80>;
> +		gpmc,bus-turnaround-ns = <0>;
> +		gpmc,cycle2cycle-delay-ns = <0>;
> +		gpmc,clk-activation-ns = <0>;
> +		gpmc,wait-monitoring-ns = <0>;
> +		gpmc,wr-data-mux-bus-ns = <0>;
> +		/* MTD partition table */
> +		/* All SPL-* partitions are sized to minimal length
> +		 * which can be independently programmable. For
> +		 * NAND flash this is equal to size of erase-block */
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		partition@0 {
> +			label = "NAND.SPL";
> +			reg = <0x00000000 0x000020000>;
> +		};
> +		partition@1 {
> +			label = "NAND.SPL.backup1";
> +			reg = <0x00020000 0x00020000>;
> +		};
> +		partition@2 {
> +			label = "NAND.SPL.backup2";
> +			reg = <0x00040000 0x00020000>;
> +		};
> +		partition@3 {
> +			label = "NAND.SPL.backup3";
> +			reg = <0x00060000 0x00020000>;
> +		};
> +		partition@4 {
> +			label = "NAND.u-boot-spl-os";
> +			reg = <0x00080000 0x00040000>;
> +		};
> +		partition@5 {
> +			label = "NAND.u-boot";
> +			reg = <0x000c0000 0x00100000>;
> +		};
> +		partition@6 {
> +			label = "NAND.u-boot-env";
> +			reg = <0x001c0000 0x00020000>;
> +		};
> +		partition@7 {
> +			label = "NAND.u-boot-env.backup1";
> +			reg = <0x001e0000 0x00020000>;
> +		};
> +		partition@8 {
> +			label = "NAND.kernel";
> +			reg = <0x00200000 0x00800000>;
> +		};
> +		partition@9 {
> +			label = "NAND.file-system";
> +			reg = <0x00a00000 0x0f600000>;
> +		};
> +	};
> +};
> 


-- 
Regards,
Nishanth Menon

Re: [PATCH 1/4] ARM: dts: dra72-evm: Add NAND support

[Nishanth Menon]

On Tue, Oct 21, 2014 at 11:43 AM, Nishanth Menon <nm@ti.com> wrote:
> Roger,
>
> On 10/21/2014 05:41 AM, Roger Quadros wrote:
>> DRA72-evm has a 256MB 16-bit wide NAND chip. Add
>> pinmux and NAND node.
>>
>> The NAND chips 'Chip select' and 'Write protect' can be
>> controlled using DIP Switch SW5. To use NAND,
>> the switch must be configured like so:
>>
>> SW5.1 (NAND_SELn) = ON (LOW)
>> SW5.9 (GPMC_WPN) = OFF (HIGH)
>
> Could we move this description to the dts as a comment? it would be
> little more easier to refer to than figuring it out from git log. I
> recollect trying to figure this out while attempting to test out NAND
> previously, never actually thought to check in git log. just a
> suggestion..

[...]

>> +&gpmc {
>> +     status = "okay";
>> +     pinctrl-names = "default";
>> +     pinctrl-0 = <&nand_default>;
>> +     ranges = <0 0 0 0x01000000>;    /* minimum GPMC partition = 16MB */
>> +     nand@0,0 {
>> +             /* To use NAND, DIP switch SW5 must be set like so:
>> +              * SW5.1 (NAND_SELn) = ON (LOW)
>> +              * SW5.9 (GPMC_WPN) = OFF (HIGH)
>> +              */

[...]

Uggh.. ignore my comment - I see you already did that.. my bad.. i missed it :(

Quickly trying to test this, I got the following:
"

[    1.840728] omap-gpmc 50000000.gpmc: GPMC revision 6.0
[    1.847290] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xca
[    1.854003] nand: Micron MT29F2G16ABAEAWP
[    1.858245] nand: 256MiB, SLC, page size: 2048, OOB size: 64
[    1.864227] omap2-nand omap2-nand.0: CONFIG_MTD_NAND_OMAP_BCH not enabled
[    1.871459] omap2-nand: probe of omap2-nand.0 failed with error -22
"

Full log: http://hastebin.com/ozugepemin.md

Does this depend on
http://marc.info/?l=linux-omap&m=141389532511600&w=2 to function? I
assume yes.

as well?

---
Regards,
Nishanth Menon

Re: [PATCH 1/4] ARM: dts: dra72-evm: Add NAND support

[Nishanth Menon]

On 12:16-20141021, Nishanth Menon wrote:
> On Tue, Oct 21, 2014 at 11:43 AM, Nishanth Menon <nm@ti.com> wrote:
> > Roger,
> >
> > On 10/21/2014 05:41 AM, Roger Quadros wrote:
> >> DRA72-evm has a 256MB 16-bit wide NAND chip. Add
> >> pinmux and NAND node.
> >>
> >> The NAND chips 'Chip select' and 'Write protect' can be
> >> controlled using DIP Switch SW5. To use NAND,
> >> the switch must be configured like so:
> >>
> >> SW5.1 (NAND_SELn) = ON (LOW)
> >> SW5.9 (GPMC_WPN) = OFF (HIGH)
> >
> > Could we move this description to the dts as a comment? it would be
> > little more easier to refer to than figuring it out from git log. I
> > recollect trying to figure this out while attempting to test out NAND
> > previously, never actually thought to check in git log. just a
> > suggestion..
> 
> [...]
> 
> >> +&gpmc {
> >> +     status = "okay";
> >> +     pinctrl-names = "default";
> >> +     pinctrl-0 = <&nand_default>;
> >> +     ranges = <0 0 0 0x01000000>;    /* minimum GPMC partition = 16MB */
> >> +     nand@0,0 {
> >> +             /* To use NAND, DIP switch SW5 must be set like so:
		      ^^ minor:
		      /*
		       * To use NAND,.... 
> >> +              * SW5.1 (NAND_SELn) = ON (LOW)
> >> +              * SW5.9 (GPMC_WPN) = OFF (HIGH)
> >> +              */
> 
> [...]
> 
> Uggh.. ignore my comment - I see you already did that.. my bad.. i missed it :(
> 
> Quickly trying to test this, I got the following:
> "
> 
> [    1.840728] omap-gpmc 50000000.gpmc: GPMC revision 6.0
> [    1.847290] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xca
> [    1.854003] nand: Micron MT29F2G16ABAEAWP
> [    1.858245] nand: 256MiB, SLC, page size: 2048, OOB size: 64
> [    1.864227] omap2-nand omap2-nand.0: CONFIG_MTD_NAND_OMAP_BCH not enabled
> [    1.871459] omap2-nand: probe of omap2-nand.0 failed with error -22
> "
> 
> Full log: http://hastebin.com/ozugepemin.md
> 
> Does this depend on
> http://marc.info/?l=linux-omap&m=141389532511600&w=2 to function? I
> assume yes.

looks like we'd want Tony to enable CONFIG_MTD_NAND_OMAP_BCH in
omap2plus_defconfig?

With that, it works like a charm..
http://slexy.org/raw/s29rfTTWB4


Feel free to add my:
Tested-by: Nishanth Menon <nm@ti.com>
Acked-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon

Re: [PATCH 1/4] ARM: dts: dra72-evm: Add NAND support

[Roger Quadros]

Nishant,

On 10/21/2014 08:32 PM, Nishanth Menon wrote:
> On 12:16-20141021, Nishanth Menon wrote:
>> On Tue, Oct 21, 2014 at 11:43 AM, Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> wrote:
>>> Roger,
>>>
>>> On 10/21/2014 05:41 AM, Roger Quadros wrote:
>>>> DRA72-evm has a 256MB 16-bit wide NAND chip. Add
>>>> pinmux and NAND node.
>>>>
>>>> The NAND chips 'Chip select' and 'Write protect' can be
>>>> controlled using DIP Switch SW5. To use NAND,
>>>> the switch must be configured like so:
>>>>
>>>> SW5.1 (NAND_SELn) = ON (LOW)
>>>> SW5.9 (GPMC_WPN) = OFF (HIGH)
>>>
>>> Could we move this description to the dts as a comment? it would be
>>> little more easier to refer to than figuring it out from git log. I
>>> recollect trying to figure this out while attempting to test out NAND
>>> previously, never actually thought to check in git log. just a
>>> suggestion..
>>
>> [...]
>>
>>>> +&gpmc {
>>>> +     status = "okay";
>>>> +     pinctrl-names = "default";
>>>> +     pinctrl-0 = <&nand_default>;
>>>> +     ranges = <0 0 0 0x01000000>;    /* minimum GPMC partition = 16MB */
>>>> +     nand@0,0 {
>>>> +             /* To use NAND, DIP switch SW5 must be set like so:
> 		      ^^ minor:
> 		      /*
> 		       * To use NAND,.... 
>>>> +              * SW5.1 (NAND_SELn) = ON (LOW)
>>>> +              * SW5.9 (GPMC_WPN) = OFF (HIGH)
>>>> +              */
>>
>> [...]
>>
>> Uggh.. ignore my comment - I see you already did that.. my bad.. i missed it :(
>>
>> Quickly trying to test this, I got the following:
>> "
>>
>> [    1.840728] omap-gpmc 50000000.gpmc: GPMC revision 6.0
>> [    1.847290] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xca
>> [    1.854003] nand: Micron MT29F2G16ABAEAWP
>> [    1.858245] nand: 256MiB, SLC, page size: 2048, OOB size: 64
>> [    1.864227] omap2-nand omap2-nand.0: CONFIG_MTD_NAND_OMAP_BCH not enabled
>> [    1.871459] omap2-nand: probe of omap2-nand.0 failed with error -22
>> "
>>
>> Full log: http://hastebin.com/ozugepemin.md
>>
>> Does this depend on
>> http://marc.info/?l=linux-omap&m=141389532511600&w=2 to function? I
>> assume yes.
> 
> looks like we'd want Tony to enable CONFIG_MTD_NAND_OMAP_BCH in
> omap2plus_defconfig?
> 
> With that, it works like a charm..
> http://slexy.org/raw/s29rfTTWB4
> 
> 
> Feel free to add my:
> Tested-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
> Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
> 

Thanks for testing. Sorry for being silent for a while. This whole thread
got moved accidentally to old-inbox ;). Took a while to figure out if I really
sent these patches or just in my dreamworld. :)

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] ARM: dts: dra72-evm: NAND and USB support

[Roger Quadros]

Hi Tony,

On 10/21/2014 01:41 PM, Roger Quadros wrote:
> Hi Tony,
> 
> These patches add NAND and USB support for DRA72-evm.
> Patches are for v3.19 and based on v3.18-rc1.
> 
> I've tested that NAND and USB host works fine on DRA72-evm.
> 
> I couldn't get USB gadget mode to work. It doesn't work on DRA7-evm either.
> There seems to be some issue at the driver level. The dts entries are correct though.

Any further comments on this? Can we please queue this for -next? Thanks.

cheers,
-roger

> 
> cheers,
> -roger
> 
> George Cherian (1):
>   ARM: dts: dra72-evm: Enable USB support for dra72-evm.
> 
> Roger Quadros (3):
>   ARM: dts: dra72-evm: Add NAND support
>   ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi
>   ARM: dts: dra72-evm: Add regulator information to USB2 PHYs
> 
>  arch/arm/boot/dts/dra7.dtsi     |  20 ------
>  arch/arm/boot/dts/dra72-evm.dts | 147 ++++++++++++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/dra74x.dtsi   |  22 ++++++
>  3 files changed, 169 insertions(+), 20 deletions(-)
> 

Re: [PATCH 0/4] ARM: dts: dra72-evm: NAND and USB support

[Tony Lindgren]

* Roger Quadros <rogerq@ti.com> [141030 07:37]:
> Hi Tony,
> 
> On 10/21/2014 01:41 PM, Roger Quadros wrote:
> > Hi Tony,
> > 
> > These patches add NAND and USB support for DRA72-evm.
> > Patches are for v3.19 and based on v3.18-rc1.
> > 
> > I've tested that NAND and USB host works fine on DRA72-evm.
> > 
> > I couldn't get USB gadget mode to work. It doesn't work on DRA7-evm either.
> > There seems to be some issue at the driver level. The dts entries are correct though.
> 
> Any further comments on this? Can we please queue this for -next? Thanks.

Applying into omap-for-v3.19/dt thanks.

Tony

 
> > cheers,
> > -roger
> > 
> > George Cherian (1):
> >   ARM: dts: dra72-evm: Enable USB support for dra72-evm.
> > 
> > Roger Quadros (3):
> >   ARM: dts: dra72-evm: Add NAND support
> >   ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi
> >   ARM: dts: dra72-evm: Add regulator information to USB2 PHYs
> > 
> >  arch/arm/boot/dts/dra7.dtsi     |  20 ------
> >  arch/arm/boot/dts/dra72-evm.dts | 147 ++++++++++++++++++++++++++++++++++++++++
> >  arch/arm/boot/dts/dra74x.dtsi   |  22 ++++++
> >  3 files changed, 169 insertions(+), 20 deletions(-)
> > 
>