From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
Jiang Liu <jiang.liu@linux.intel.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
arm@kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
yingjoe.chen@gmail.com,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
yh.chen@mediatek.com, nathan.chung@mediatek.com,
Grant Likely <grant.likely@linaro.org>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Hans de Goede <hdegoede@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, hc.yen@mediatek.com,
linux-kernel@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
Olof Johansson <olof@lixom.net>
Subject: [PATCH v4 2/7] irqdomain: Add back xlate and set_type for hierarchy irq domain
Date: Thu, 23 Oct 2014 23:53:10 +0800 [thread overview]
Message-ID: <1414079595-26129-3-git-send-email-yingjoe.chen@mediatek.com> (raw)
In-Reply-To: <1414079595-26129-1-git-send-email-yingjoe.chen@mediatek.com>
Move xlate and set_type out to common code for hierarchy irq domain.
Withouth this common code, all outermost irq domain will have to duplicate
these function.
Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
---
kernel/irq/irqdomain.c | 29 ++++++++++++++++++++---------
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index dd8d3ab..b3288e8 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -478,11 +478,6 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
return 0;
}
- if (irq_domain_is_hierarchy(domain)) {
- virq = irq_domain_alloc_irqs(domain, 1, NUMA_NO_NODE, irq_data);
- return virq <= 0 ? 0 : virq;
- }
-
/* If domain has no translation, then we assume interrupt line */
if (domain->ops->xlate == NULL)
hwirq = irq_data->args[0];
@@ -492,10 +487,26 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
return 0;
}
- /* Create mapping */
- virq = irq_create_mapping(domain, hwirq);
- if (!virq)
- return virq;
+ if (irq_domain_is_hierarchy(domain)) {
+ if (domain->ops->xlate) {
+ /*
+ * If we've already configured this interrupt,
+ * don't do it again, or hell will break loose.
+ */
+ virq = irq_find_mapping(domain, hwirq);
+ if (virq)
+ return virq;
+ }
+
+ virq = irq_domain_alloc_irqs(domain, 1, NUMA_NO_NODE, irq_data);
+ if (virq <= 0)
+ return 0;
+ } else {
+ /* Create mapping */
+ virq = irq_create_mapping(domain, hwirq);
+ if (!virq)
+ return virq;
+ }
/* Set type if specified and different than the current one */
if (type != IRQ_TYPE_NONE &&
--
1.8.1.1.dirty
next prev parent reply other threads:[~2014-10-23 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 15:53 [PATCH v4 0/7] ARM: mediatek: Add support for interrupt polarity Yingjoe Chen
2014-10-23 15:53 ` [PATCH v4 1/7] irqdomain: Fix irq_domain_alloc_irqs return check Yingjoe Chen
2014-10-23 15:53 ` Yingjoe Chen [this message]
2014-10-23 15:53 ` [PATCH v4 3/7] genirq: Add more helper functions to support stacked irq_chip Yingjoe Chen
2014-10-23 15:53 ` [PATCH v4 4/7] irqchip: gic: Support hierarchy irq domain Yingjoe Chen
[not found] ` <1414079595-26129-5-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2014-10-24 6:50 ` Yingjoe Chen
2014-10-23 15:53 ` [PATCH v4 5/7] ARM: mediatek: Add sysirq interrupt polarity support Yingjoe Chen
2014-10-23 15:53 ` [PATCH v4 6/7] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi Yingjoe Chen
2014-10-23 15:53 ` [PATCH v4 7/7] dt-bindings: add bindings for mediatek sysirq Yingjoe Chen
[not found] ` <1414079595-26129-1-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2014-10-24 14:59 ` [PATCH v4 0/7] ARM: mediatek: Add support for interrupt polarity Matthias Brugger
[not found] ` <CABuKBeLjFDm2TSqxc=K3rDnYTKRok3sCvEuL+chxxo7p1UbhLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-24 15:06 ` Yingjoe Chen
2014-10-27 7:44 ` Yingjoe Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414079595-26129-3-git-send-email-yingjoe.chen@mediatek.com \
--to=yingjoe.chen@mediatek.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=hc.yen@mediatek.com \
--cc=hdegoede@redhat.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nathan.chung@mediatek.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
--cc=yh.chen@mediatek.com \
--cc=yingjoe.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).