From: Kevin Cernekee <cernekee@gmail.com>
To: f.fainelli@gmail.com, tglx@linutronix.de, jason@lakedaemon.net,
ralf@linux-mips.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
mbizon@freebox.fr, jogo@openwrt.org, linux-mips@linux-mips.org
Subject: [PATCH 01/11] irqchip: Allow irq_reg_{readl,writel} to use __raw_{readl_writel}
Date: Tue, 28 Oct 2014 20:58:48 -0700 [thread overview]
Message-ID: <1414555138-6500-1-git-send-email-cernekee@gmail.com> (raw)
On big-endian systems readl/writel may perform an unwanted endian swap,
breaking generic-chip.c. Let the platform code opt to use the __raw_
variants by selecting RAW_IRQ_ACCESSORS.
This is required in order for bcm3384 to use GENERIC_IRQ_CHIP. Several
existing irqchip drivers also use the __raw_ accessors directly, so it
is a reasonably common requirement.
Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
---
drivers/irqchip/Kconfig | 3 +++
include/linux/irq.h | 13 +++++++++++++
2 files changed, 16 insertions(+)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index b21f12f..6f0e80b 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -2,6 +2,9 @@ config IRQCHIP
def_bool y
depends on OF_IRQ
+config RAW_IRQ_ACCESSORS
+ bool
+
config ARM_GIC
bool
select IRQ_DOMAIN
diff --git a/include/linux/irq.h b/include/linux/irq.h
index 03f48d9..ed1ea8a 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -639,6 +639,17 @@ void arch_teardown_hwirq(unsigned int irq);
void irq_init_desc(unsigned int irq);
#endif
+#ifdef CONFIG_RAW_IRQ_ACCESSORS
+
+#ifndef irq_reg_writel
+# define irq_reg_writel(val, addr) __raw_writel(val, addr)
+#endif
+#ifndef irq_reg_readl
+# define irq_reg_readl(addr) __raw_readl(addr)
+#endif
+
+#else
+
#ifndef irq_reg_writel
# define irq_reg_writel(val, addr) writel(val, addr)
#endif
@@ -646,6 +657,8 @@ void irq_init_desc(unsigned int irq);
# define irq_reg_readl(addr) readl(addr)
#endif
+#endif
+
/**
* struct irq_chip_regs - register offsets for struct irq_gci
* @enable: Enable register offset to reg_base
--
2.1.1
next reply other threads:[~2014-10-29 3:58 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 3:58 Kevin Cernekee [this message]
2014-10-29 3:58 ` [PATCH 02/11] irqchip: brcmstb-l2: Eliminate dependency on ARM code Kevin Cernekee
[not found] ` <1414555138-6500-2-git-send-email-cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-29 7:29 ` Arnd Bergmann
2014-10-29 16:53 ` Florian Fainelli
2014-10-29 3:58 ` [PATCH 03/11] irqchip: bcm7120-l2: Eliminate bad IRQ check Kevin Cernekee
2014-10-29 16:53 ` Florian Fainelli
2014-10-29 3:58 ` [PATCH 04/11] irqchip: Remove ARM dependency for bcm7120-l2 and brcmstb-l2 Kevin Cernekee
2014-10-29 7:44 ` Arnd Bergmann
2014-10-29 16:53 ` Florian Fainelli
2014-10-29 3:58 ` [PATCH 05/11] irqchip: bcm7120-l2: Make sure all register accesses use base+offset Kevin Cernekee
2014-10-29 7:46 ` Arnd Bergmann
2014-10-29 7:56 ` Arnd Bergmann
2014-10-29 16:53 ` Florian Fainelli
2014-10-29 3:58 ` [PATCH 06/11] irqchip: bcm7120-l2: Use irq_reg_* accessors Kevin Cernekee
2014-10-29 7:46 ` Arnd Bergmann
2014-10-29 16:54 ` Florian Fainelli
2014-10-29 3:58 ` [PATCH 07/11] irqchip: brcmstb-l2: " Kevin Cernekee
[not found] ` <1414555138-6500-7-git-send-email-cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-29 7:46 ` Arnd Bergmann
2014-10-29 16:54 ` Florian Fainelli
2014-10-29 3:58 ` [PATCH 08/11] irqchip: bcm7120-l2: Fix missing nibble in gc->unused mask Kevin Cernekee
2014-10-29 7:47 ` Arnd Bergmann
2014-10-29 16:55 ` Florian Fainelli
2014-10-29 3:58 ` [PATCH 09/11] irqchip: bcm7120-l2: Use gc->mask_cache to simplify suspend/resume functions Kevin Cernekee
[not found] ` <1414555138-6500-9-git-send-email-cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-29 16:55 ` Florian Fainelli
2014-10-29 3:58 ` [PATCH 10/11] irqchip: bcm7120-l2: Extend driver to support 64+ bit controllers Kevin Cernekee
2014-10-29 7:53 ` Arnd Bergmann
2014-10-29 23:22 ` Kevin Cernekee
2014-10-30 9:10 ` Arnd Bergmann
2014-10-29 3:58 ` [PATCH 11/11] irqchip: Decouple bcm7120-l2 from brcmstb-l2 Kevin Cernekee
2014-10-29 7:55 ` Arnd Bergmann
2014-10-29 16:56 ` Florian Fainelli
2014-10-29 7:43 ` [PATCH 01/11] irqchip: Allow irq_reg_{readl,writel} to use __raw_{readl_writel} Arnd Bergmann
2014-10-29 17:36 ` Florian Fainelli
[not found] ` <54512599.4080500-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-29 19:14 ` Arnd Bergmann
2014-10-29 18:48 ` Kevin Cernekee
2014-10-29 19:10 ` Thomas Gleixner
2014-10-29 19:14 ` Arnd Bergmann
2014-10-29 20:09 ` Kevin Cernekee
2014-10-29 21:13 ` Arnd Bergmann
2014-10-29 21:31 ` Thomas Gleixner
2014-10-29 21:41 ` Arnd Bergmann
2014-10-29 21:50 ` Thomas Gleixner
2014-10-29 23:05 ` Kevin Cernekee
2014-10-30 9:58 ` Arnd Bergmann
2014-10-30 19:03 ` Kevin Cernekee
2014-10-30 19:52 ` Arnd Bergmann
2014-10-30 20:54 ` Kevin Cernekee
[not found] ` <CAJiQ=7C+r80Jt51NXLCk-0D2nRezBfMN9pGBVT9V8ncefGhBnQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-30 21:18 ` Arnd Bergmann
2014-10-29 10:12 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414555138-6500-1-git-send-email-cernekee@gmail.com \
--to=cernekee@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jason@lakedaemon.net \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).