From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs Date: Wed, 29 Oct 2014 10:20:13 +0100 Message-ID: <1414574413.18868.6.camel@AMDC1943> References: <1414411911-5539-1-git-send-email-k.kozlowski@samsung.com> <1414411911-5539-4-git-send-email-k.kozlowski@samsung.com> <20141028223121.GH18557@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20141028223121.GH18557@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Liam Girdwood , linux-kernel@vger.kernel.org, Ben Dooks , Kukjin Kim , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas , Chanwoo Choi List-Id: devicetree@vger.kernel.org On wto, 2014-10-28 at 22:31 +0000, Mark Brown wrote: > On Mon, Oct 27, 2014 at 01:11:49PM +0100, Krzysztof Kozlowski wrote: > > > @@ -247,6 +250,8 @@ static struct regulator_ops max77686_ldo_ops = { > > .set_voltage_sel = regulator_set_voltage_sel_regmap, > > .set_voltage_time_sel = regulator_set_voltage_time_sel, > > .set_suspend_mode = max77686_ldo_set_suspend_mode, > > + .set_suspend_disable = max77686_set_suspend_disable, > > + .set_suspend_enable = max77686_enable, > > This looks wrong, you're using the regular enable operation as suspend > enable. How does that work without disrupting the current runtime > state? Currently it shouldn't disrupt state of regulator because during runtime it may only be only: on (0x3) or off (0x0). Suspend enable in max77686 writes 0x3 to the register which means - always on. If regulator was disabled before suspend then it has to be enabled during suspend_enable() call which is exactly what max77686_enable does. If it was enabled then nothing happens. Best regards, Krzysztof