From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs Date: Wed, 29 Oct 2014 11:44:02 +0100 Message-ID: <1414579442.18868.13.camel@AMDC1943> References: <1414411911-5539-1-git-send-email-k.kozlowski@samsung.com> <1414411911-5539-4-git-send-email-k.kozlowski@samsung.com> <20141028223121.GH18557@sirena.org.uk> <1414574413.18868.6.camel@AMDC1943> <20141029100142.GR18557@sirena.org.uk> <1414577934.18868.7.camel@AMDC1943> <20141029103140.GY18557@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <20141029103140.GY18557@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Liam Girdwood , linux-kernel@vger.kernel.org, Ben Dooks , Kukjin Kim , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas , Chanwoo Choi List-Id: devicetree@vger.kernel.org On =C5=9Bro, 2014-10-29 at 10:31 +0000, Mark Brown wrote: > On Wed, Oct 29, 2014 at 11:18:54AM +0100, Krzysztof Kozlowski wrote: > > On =C5=9Bro, 2014-10-29 at 10:01 +0000, Mark Brown wrote: >=20 > > > No, this isn't suspend enable control - this is normal, standard = enable > > > control and the device has no suspend enable control. >=20 > > You mean that for such regulator the driver shouldn't implement > > suspend_enable()? >=20 > Yes, if there is no separate control of suspend mode in hardware then= of > course the driver shouldn't implement operations for things it doesn'= t > have. Oh, thanks! I'll send fixed patch. This means that probably the max77802 ("mirrored" driver) should be fixed... Best regards, Krzysztof