From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yingjoe Chen Subject: Re: [PATCH 3/3] I2C: mediatek: Add driver for MediaTek I2C controller Date: Thu, 30 Oct 2014 22:49:05 +0800 Message-ID: <1414680545.5833.21.camel@mtksdaap41> References: <1414561058-23803-1-git-send-email-xudong.chen@mediatek.com> <1414561058-23803-4-git-send-email-xudong.chen@mediatek.com> <20141030132537.GB23852@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141030132537.GB23852@katana> Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: Matthias Brugger , Xudong Chen , Mark Rutland , arm@kernel.org, srv_heupstream , Sascha Hauer , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , Grant Likely , Jean Delvare , Arnd Bergmann , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-i2c@vger.kernel.org, Eddie Huang , Nathan Chung , YH Chen List-Id: devicetree@vger.kernel.org On Thu, 2014-10-30 at 14:25 +0100, Wolfram Sang wrote: > > > +obj-$(CONFIG_I2C_MT65XX) += i2c-mt65xx.o > > > > As it works for mt65xx and mt81xx series, better rename it to i2c-mtk.c > > That is a bit too generic IMO. It is likely that we will see some > totally different I2C core from MTK in the future. Plus, it is not > uncommon that a driver initially for SoC-X supports SoC-Y, too. Hi, Yes, MTK TV SoCs(MT53xx) do use a different/incompatible I2C IP. So we preferred to keep original file name. Joe.C