From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yingjoe Chen Subject: Re: [PATCH v4 2/8] ARM: mediatek: add dts for 8127 Moose board Date: Tue, 4 Nov 2014 13:44:21 +0800 Message-ID: <1415079861.31861.0.camel@mtksdaap41> References: <1413973797-17619-1-git-send-email-yingjoe.chen@mediatek.com> <1413973797-17619-3-git-send-email-yingjoe.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matthias Brugger Cc: Rob Herring , arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Olof Johansson , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , srv_heupstream , Yingjoe Chen , Hsien-Chun Yen , huang eddie , Nathan Chung , Yuhau Chen , Sascha Hauer List-Id: devicetree@vger.kernel.org On Mon, 2014-11-03 at 18:55 +0100, Matthias Brugger wrote: > 2014-10-22 12:29 GMT+02:00 Joe.C : > > From: "Joe.C" > > > > Moose is a tablet evalutation board based on MT8127 SoC. > > > > Signed-off-by: Joe.C > > --- > > arch/arm/boot/dts/mt8127-moose.dts | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > create mode 100644 arch/arm/boot/dts/mt8127-moose.dts > > > > diff --git a/arch/arm/boot/dts/mt8127-moose.dts b/arch/arm/boot/dts/mt8127-moose.dts > > new file mode 100644 > > index 0000000..602e2f0 > > --- /dev/null > > +++ b/arch/arm/boot/dts/mt8127-moose.dts > > @@ -0,0 +1,24 @@ > > +/* > > + * Copyright (c) 2014 MediaTek Inc. > > + * Author: Joe.C > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +/dts-v1/; > > +#include "mt8127.dtsi" > > + > > +/ { > > + model = "mediatek,mt8127-moose", "mediatek,mt8127"; > > The model should be a string that identifies the board, e.g. "Moose". > Please add the compatible property. Thanks for catching this. I just note we have warning on this line. Will fix in next version. Joe.C -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html