devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] sata_rcar: Add clocks to sata_rcar bindings
@ 2014-11-10 18:42 Geert Uytterhoeven
  2014-11-10 18:42 ` [PATCH v2 2/2] sata_rcar: Document deprecated "renesas,rcar-sata" Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-11-10 18:42 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Simon Horman, Magnus Damm, Valentine Barshak, linux-ide,
	devicetree, linux-sh, Geert Uytterhoeven

From: Valentine Barshak <valentine.barshak@cogentembedded.com>

Now that the clocks are available in the R-Car Gen2 DT,
add clocks property description to the sata_rcar bindings.
The clocks have been tested on r8a7791 so we use that
as an example of the R-Car SATA node.

Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
[geert: Reworded clocks property]
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
---
v2:
  - Add Acked-by
---
 Documentation/devicetree/bindings/ata/sata_rcar.txt | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt b/Documentation/devicetree/bindings/ata/sata_rcar.txt
index 80ae87a0784bdba8..f09c1ee260ba1d10 100644
--- a/Documentation/devicetree/bindings/ata/sata_rcar.txt
+++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt
@@ -9,12 +9,14 @@ Required properties:
 			  - "renesas,sata-r8a7793" for R-Car M2-N
 - reg			: address and length of the SATA registers;
 - interrupts		: must consist of one interrupt specifier.
+- clocks		: must contain a reference to the functional clock.
 
 Example:
 
-sata: sata@fc600000 {
-	compatible = "renesas,sata-r8a7779";
-	reg = <0xfc600000 0x2000>;
+sata0: sata@ee300000 {
+	compatible = "renesas,sata-r8a7791";
+	reg = <0 0xee300000 0 0x2000>;
 	interrupt-parent = <&gic>;
-	interrupts = <0 100 IRQ_TYPE_LEVEL_HIGH>;
+	interrupts = <0 105 IRQ_TYPE_LEVEL_HIGH>;
+	clocks = <&mstp8_clks R8A7791_CLK_SATA0>;
 };
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] sata_rcar: Document deprecated "renesas,rcar-sata"
  2014-11-10 18:42 [PATCH v2 1/2] sata_rcar: Add clocks to sata_rcar bindings Geert Uytterhoeven
@ 2014-11-10 18:42 ` Geert Uytterhoeven
  2014-11-14 17:36   ` Tejun Heo
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-11-10 18:42 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Simon Horman, Magnus Damm, Valentine Barshak, linux-ide,
	devicetree, linux-sh, Geert Uytterhoeven

Commit e67adb4e669db834 ("sata_rcar: Add R-Car Gen2 SATA PHY support")
deprecated "renesas,rcar-sata" in favor of "renesas,sata-r8a7779", but
the deprecated value was never documented in the binding documentation,
while it is still in active use.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
---
v2:
  - Add Acked-by,
  - Rebased on top of libata/for-next
---
 Documentation/devicetree/bindings/ata/sata_rcar.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt b/Documentation/devicetree/bindings/ata/sata_rcar.txt
index f09c1ee260ba1d10..2493a5a316551de8 100644
--- a/Documentation/devicetree/bindings/ata/sata_rcar.txt
+++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt
@@ -3,6 +3,7 @@
 Required properties:
 - compatible		: should contain one of the following:
 			  - "renesas,sata-r8a7779" for R-Car H1
+			    ("renesas,rcar-sata" is deprecated)
 			  - "renesas,sata-r8a7790-es1" for R-Car H2 ES1
 			  - "renesas,sata-r8a7790" for R-Car H2 other than ES1
 			  - "renesas,sata-r8a7791" for R-Car M2-W
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 2/2] sata_rcar: Document deprecated "renesas,rcar-sata"
  2014-11-10 18:42 ` [PATCH v2 2/2] sata_rcar: Document deprecated "renesas,rcar-sata" Geert Uytterhoeven
@ 2014-11-14 17:36   ` Tejun Heo
  0 siblings, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2014-11-14 17:36 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Valentine Barshak, linux-ide,
	devicetree, linux-sh

On Mon, Nov 10, 2014 at 07:42:30PM +0100, Geert Uytterhoeven wrote:
> Commit e67adb4e669db834 ("sata_rcar: Add R-Car Gen2 SATA PHY support")
> deprecated "renesas,rcar-sata" in favor of "renesas,sata-r8a7779", but
> the deprecated value was never documented in the binding documentation,
> while it is still in active use.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>

Applied to libata/for-3.19.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-11-14 17:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-10 18:42 [PATCH v2 1/2] sata_rcar: Add clocks to sata_rcar bindings Geert Uytterhoeven
2014-11-10 18:42 ` [PATCH v2 2/2] sata_rcar: Document deprecated "renesas,rcar-sata" Geert Uytterhoeven
2014-11-14 17:36   ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).