From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C243814A61B for ; Wed, 26 Jun 2024 06:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719382428; cv=none; b=VqK0YhQB5EWupVaz+GC3idGTwcLUjoX90pGAuxFeDP4Tatprth2PCsJKdwWACFsC6AOGnQZPjQwKHk0WbB+c4Y/ECq4/ljZcNBp5rdSnD8KttqrnEYqQQzyedNo9TZTAplYIjEoWAjOVa14Ej3IE8qjaPpIuCzy6dYzPUAfJzPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719382428; c=relaxed/simple; bh=BJtQ9l+V2WAR5BzRXmZ0v9xaywUqO0Ckllr4TBtCJU8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sJjEBSol5Yxk5KdvWSrByE/fnj/OJYYlM9h6KBQkUMQ66NnmRZp99cBaw8YN5ImFAbP361oDA1iOUfAUrUSq0MGOtXksUUMzgP04xoeaCZUxnHqSatQwpU6QAGqDa4J3UV5YEof3J+IBjPYC2He+LNrWugwSGBYavAwnNI/qo28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=l2KHR/DW; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="l2KHR/DW" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-424aa70fbc4so6085715e9.1 for ; Tue, 25 Jun 2024 23:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1719382425; x=1719987225; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3MYj1syjPNYZBySDVupnxlkb67gyc3eu/jDgMDAJ8cA=; b=l2KHR/DWvmu3ZJJm7LyULj0+2SWeZjDRcYCUdV3x0MuunR04zGf+UCeZzW6HDqtRXc Nllno76v51jDC5wMjhCKeJss/d3gD5Z7lrZCuN4vlzT9F9K4qBd3cyw3aF64KlTNUYj5 wXPRrBstOB7vhRaOHG3uMotE05PY4XTXgHBr6LSd4jP8Wm4Jz6pVlz74A7YZ1Aa37gCG GihMrtUDHAoa8J/Shutxe22fgPe+Mr7kr9NWqQ8D8Se94s9I2HBbjWtdoH8ZmwIpxEa1 WeIA3U+hi/10hvmZLrxbxS1YHcMW4PcjRimqxbr/1NW/g9sg7WyfZbA7cxu7kO93wGt5 PSbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719382425; x=1719987225; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3MYj1syjPNYZBySDVupnxlkb67gyc3eu/jDgMDAJ8cA=; b=Tx8CfqgSO9v44qBzUbzUZzEhxIONnE9V0QE4saozgYmGFtf4olZkbvGE+wmvBiyFkA +2G9rAU/BvNuXMxryj05x3lL98afQW6r8777L40WBXLwaFXA8udV5heDj7HCQ37jvqk7 bHuu1J1EaD24t5ulA+sC4MKZTMZ9EQUzIBb7s9Pjlr4qGzm1vJ/+NwmKIMTOAU+C0rE9 GgO31fSlwk5a6sI/OSMoJzOrdqm2HIRiZ/V/dLO60N6zaVmzcFn3dl6AYm2ERfr2WO0A PcKd6r5KtNI0x+TglvZGHvpJ8WyBLPdZi4OLNCpGmcC+rvDsQ8PxxxD1YhB8FuRB+fdc GJVw== X-Forwarded-Encrypted: i=1; AJvYcCUzm8yBF9EhgYU/DFtvV40w4VEMU3xKF3L5IehKZ+urEEiQRgOk5Rhi3nKgB/HjQ6Xz2HaGNzovKsUruzCzm8YYw32kUUxVTfNj8Q== X-Gm-Message-State: AOJu0YwY9i8eMj5c2vinFLtAAunCE/dxgWZRaCG3479qZd6WymQ822iO ozjlMrT09Mp/8Y/YRiShWscUCdUBLeKIKr7pj2zryjBg4uqKaZ8IHhYw5lhOpfs= X-Google-Smtp-Source: AGHT+IHbF71gbIghJoYKFbrg4W+yIrq0Ui8qDFkKVSeUFQObkIKWpiU0iUTb4PgiFnvihuycMlGCFw== X-Received: by 2002:a5d:4689:0:b0:35f:275c:fb63 with SMTP id ffacd0b85a97d-366e948fa5emr7116687f8f.25.1719382424899; Tue, 25 Jun 2024 23:13:44 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.70]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366f466979dsm7064166f8f.7.2024.06.25.23.13.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 23:13:44 -0700 (PDT) Message-ID: <14167607-e67b-4627-99f0-6e99acc7f880@tuxon.dev> Date: Wed, 26 Jun 2024 09:13:42 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/12] i2c: riic: Use pm_runtime_resume_and_get() Content-Language: en-US To: Biju Das , Chris Brandt , "andi.shyti@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "geert+renesas@glider.be" , "magnus.damm@gmail.com" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "p.zabel@pengutronix.de" , "wsa+renesas@sang-engineering.com" Cc: "linux-renesas-soc@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , Claudiu Beznea References: <20240625121358.590547-1-claudiu.beznea.uj@bp.renesas.com> <20240625121358.590547-5-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Biju, On 25.06.2024 18:53, Biju Das wrote: > Hi Claudiu, > >> -----Original Message----- >> From: Claudiu >> Sent: Tuesday, June 25, 2024 1:14 PM >> Subject: [PATCH v2 04/12] i2c: riic: Use pm_runtime_resume_and_get() >> >> From: Claudiu Beznea >> >> pm_runtime_get_sync() may return with error. In case it returns with error >> dev->power.usage_count needs to be decremented. >> dev->pm_runtime_resume_and_get() >> takes care of this. Thus use it. >> >> Signed-off-by: Claudiu Beznea >> --- >> >> Changes in v2: >> - delete i2c adapter all the time in remove >> >> drivers/i2c/busses/i2c-riic.c | 30 ++++++++++++++++++++++++------ >> 1 file changed, 24 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-riic.c b/drivers/i2c/busses/i2c-riic.c index >> 83e4d5e14ab6..002b11b020fa 100644 >> --- a/drivers/i2c/busses/i2c-riic.c >> +++ b/drivers/i2c/busses/i2c-riic.c >> @@ -113,6 +113,8 @@ struct riic_irq_desc { >> char *name; >> }; >> >> +static const char * const riic_rpm_err_msg = "Failed to runtime >> +resume"; >> + >> static inline void riic_writeb(struct riic_dev *riic, u8 val, u8 offset) { >> writeb(val, riic->base + riic->info->regs[offset]); @@ -133,10 +135,14 @@ static int >> riic_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num) >> struct riic_dev *riic = i2c_get_adapdata(adap); >> struct device *dev = adap->dev.parent; >> unsigned long time_left; >> - int i; >> + int i, ret; >> u8 start_bit; >> >> - pm_runtime_get_sync(dev); >> + ret = pm_runtime_resume_and_get(dev); >> + if (ret) { >> + dev_err(dev, riic_rpm_err_msg); > > As at the moment we don't know how to reproduce this error condition > Can we use WARN_ON_ONCE() instead to catch detailed error condition here?? [1] states "So, naturally, use of WARN_ON() is also now discouraged much of the time". I've go with dev_err() or something similar. Thank you, Claudiu Beznea [1] https://lwn.net/Articles/969923/ > > Cheers, > Biju > >> + return ret; >> + } >> >> if (riic_readb(riic, RIIC_ICCR2) & ICCR2_BBSY) { >> riic->err = -EBUSY; >> @@ -301,6 +307,7 @@ static const struct i2c_algorithm riic_algo = { >> >> static int riic_init_hw(struct riic_dev *riic, struct i2c_timings *t) { >> + int ret; >> unsigned long rate; >> int total_ticks, cks, brl, brh; >> struct device *dev = riic->adapter.dev.parent; @@ -379,7 +386,11 @@ static int >> riic_init_hw(struct riic_dev *riic, struct i2c_timings *t) >> t->scl_fall_ns / (1000000000 / rate), >> t->scl_rise_ns / (1000000000 / rate), cks, brl, brh); >> >> - pm_runtime_get_sync(dev); >> + ret = pm_runtime_resume_and_get(dev); >> + if (ret) { >> + dev_err(dev, riic_rpm_err_msg); >> + return ret; >> + } >> >> /* Changing the order of accessing IICRST and ICE may break things! */ >> riic_writeb(riic, ICCR1_IICRST | ICCR1_SOWP, RIIC_ICCR1); @@ -498,11 +509,18 @@ static void >> riic_i2c_remove(struct platform_device *pdev) { >> struct riic_dev *riic = platform_get_drvdata(pdev); >> struct device *dev = &pdev->dev; >> + int ret; >> >> - pm_runtime_get_sync(dev); >> - riic_writeb(riic, 0, RIIC_ICIER); >> - pm_runtime_put(dev); >> i2c_del_adapter(&riic->adapter); >> + >> + ret = pm_runtime_resume_and_get(dev); >> + if (ret) { >> + dev_err(dev, riic_rpm_err_msg); >> + } else { >> + riic_writeb(riic, 0, RIIC_ICIER); >> + pm_runtime_put(dev); >> + } >> + >> pm_runtime_disable(dev); >> } >> >> -- >> 2.39.2 >> >