devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: mark.rutland@arm.com, grant.likely@linaro.org,
	robh+dt@kernel.org, plagnioj@jcrosoft.com, ijc@debian.org
Subject: [PATCH] of: support passing console options with stdout-path
Date: Mon, 24 Nov 2014 22:23:58 +0000	[thread overview]
Message-ID: <1416867838-18652-1-git-send-email-leif.lindholm@linaro.org> (raw)

Support specifying console options (like with console=ttyXN,<options>)
by appending them to the stdout-path property after a separating ':'.

Example:
	stdout-path = "uart0:115200";

This patch also modifies of_find_node_by_path() to match only the
portion of the path before a ':'.

Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 drivers/of/base.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 3823edf..89c6b33 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -37,6 +37,7 @@ EXPORT_SYMBOL(of_allnodes);
 struct device_node *of_chosen;
 struct device_node *of_aliases;
 struct device_node *of_stdout;
+static char *of_stdout_options;
 
 struct kset *of_kset;
 
@@ -703,6 +704,8 @@ static struct device_node *__of_find_node_by_path(struct device_node *parent,
 	if (!len)
 		return NULL;
 
+	len = strchrnul(path, ':') - path;
+
 	__for_each_child_of_node(parent, child) {
 		const char *name = strrchr(child->full_name, '/');
 		if (WARN(!name, "malformed device_node %s\n", child->full_name))
@@ -747,6 +750,8 @@ struct device_node *of_find_node_by_path(const char *path)
 		if (!of_aliases)
 			return NULL;
 
+		len = strchrnul(path, ':') - path;
+
 		for_each_property_of_node(of_aliases, pp) {
 			if (strlen(pp->name) == len && !strncmp(pp->name, path, len)) {
 				np = of_find_node_by_path(pp->value);
@@ -1830,8 +1835,12 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align))
 			name = of_get_property(of_chosen, "linux,stdout-path", NULL);
 		if (IS_ENABLED(CONFIG_PPC) && !name)
 			name = of_get_property(of_aliases, "stdout", NULL);
-		if (name)
+		if (name) {
 			of_stdout = of_find_node_by_path(name);
+			of_stdout_options = strchr(name, ':');
+			if (of_stdout_options != NULL)
+				of_stdout_options++;
+		}
 	}
 
 	if (!of_aliases)
@@ -1957,7 +1966,7 @@ bool of_console_check(struct device_node *dn, char *name, int index)
 {
 	if (!dn || dn != of_stdout || console_set_on_cmdline)
 		return false;
-	return !add_preferred_console(name, index, NULL);
+	return !add_preferred_console(name, index, of_stdout_options);
 }
 EXPORT_SYMBOL_GPL(of_console_check);
 
-- 
1.9.1

             reply	other threads:[~2014-11-24 22:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 22:23 Leif Lindholm [this message]
     [not found] ` <1416867838-18652-1-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-11-24 23:00   ` [PATCH] of: support passing console options with stdout-path Andrew Lunn
     [not found]     ` <20141124230016.GP20238-g2DYL2Zd6BY@public.gmane.org>
2014-11-25  0:12       ` Leif Lindholm
2014-11-25  6:49       ` Sascha Hauer
2014-11-25 14:44       ` Grant Likely
     [not found]         ` <20141125144439.07212C44343-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-25 16:21           ` Andrew Lunn
2014-11-25 10:35   ` Mark Rutland
2014-11-25 11:17     ` Leif Lindholm
2014-11-25 12:07       ` Ian Campbell
     [not found]         ` <1416917249.32327.15.camel-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-11-25 14:35           ` Leif Lindholm
2014-11-25 14:55         ` Grant Likely
2014-11-25 12:54     ` Sascha Hauer
2014-11-25 14:58   ` Grant Likely
2014-11-25 15:15     ` Leif Lindholm
2014-11-25 15:20       ` Grant Likely
2014-11-25 15:24         ` Ian Campbell
     [not found]           ` <1416929071.16769.1.camel-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-11-25 15:39             ` Grant Likely
     [not found]               ` <CACxGe6vekjF4M0J4s7g2Q_E-KYUrT_3Pna2z6nobSMZ7bc8Bhw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-25 15:41                 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416867838-18652-1-git-send-email-leif.lindholm@linaro.org \
    --to=leif.lindholm@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc@debian.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).