From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access Date: Wed, 26 Nov 2014 17:34:17 +0100 Message-ID: <1417019657.3177.10.camel@pengutronix.de> References: <1417008157-31861-1-git-send-email-andy.yan@rock-chips.com> <1417008759-32257-1-git-send-email-andy.yan@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417008759-32257-1-git-send-email-andy.yan@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andy Yan Cc: Mark Rutland , heiko@sntech.de, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Rob Herring , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala List-Id: devicetree@vger.kernel.org QW0gTWl0dHdvY2gsIGRlbiAyNi4xMS4yMDE0LCAyMTozMiArMDgwMCBzY2hyaWViIEFuZHkgWWFu Ogo+IE9uIHJvY2tjaGlwIHJrMzI4OCwgb25seSB3b3JkKDMyLWJpdCkgYWNjZXNzZXMgYXJlCj4g cGVybWl0dGVkIGZvciBoZG1pIHJlZ2lzdGVycy4gIEJ5dGUgd2lkdGggYWNjZXNzZXMgKHdyaXRl YiwKPiByZWFkYikgZ2VuZXJhdGUgYW4gaW1wcmVjaXNlIGV4dGVybmFsIGFib3J0Lgo+Cj4gU2ln bmVkLW9mZi1ieTogQW5keSBZYW4gPGFuZHkueWFuQHJvY2stY2hpcHMuY29tPgo+IAo+IC0tLQo+ IAo+IENoYW5nZXMgaW4gdjEzOiBOb25lCj4gQ2hhbmdlcyBpbiB2MTI6IE5vbmUKPiBDaGFuZ2Vz IGluIHYxMTogTm9uZQo+IENoYW5nZXMgaW4gdjEwOiBOb25lCj4gQ2hhbmdlcyBpbiB2OTogTm9u ZQo+IENoYW5nZXMgaW4gdjg6IE5vbmUKPiBDaGFuZ2VzIGluIHY3OiBOb25lCj4gQ2hhbmdlcyBp biB2NjoKPiAtIHJlZmFjdG9yIHJlZ2lzdGVyIGFjY2VzcyB3aXRob3V0IHJlZ19zaGlmdAo+IAo+ IENoYW5nZXMgaW4gdjU6Cj4gLSByZWZhY3RvciByZWctaW8td2lkdGgKPiAKPiBDaGFuZ2VzIGlu IHY0OiBOb25lCj4gQ2hhbmdlcyBpbiB2MzoKPiAtIHNwbGl0IG11bHRpLXJlZ2lzdGVyIGFjY2Vz cyB0byBvbmUgaW5kZXBlbnQgcGF0Y2gKPiAKPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9kd19o ZG1pLmMgfCA1NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R3X2hkbWkuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9icmlkZ2UvZHdfaGRtaS5jCj4gaW5kZXggYTUzYmY2My4uNWU4OGM4ZCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R3X2hkbWkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9icmlkZ2UvZHdfaGRtaS5jCj4gQEAgLTEwMCw2ICsxMDAsMTEgQEAgc3RydWN0IGhkbWlfZGF0 YV9pbmZvIHsKPiAgCXN0cnVjdCBoZG1pX3Ztb2RlIHZpZGVvX21vZGU7Cj4gIH07Cj4gIAo+ICt1 bmlvbiBkd19yZWdfcHRyIHsKPiArCXUzMiBfX2lvbWVtICpwMzI7Cj4gKwl1OCBfX2lvbWVtICpw ODsKPiArfTsKCkkgc2VlIG5vIG5lZWQgdG8gaW50cm9kdWNlIHRoaXMuIEp1c3QgZXhwbGljaXRs eSBtdWx0aXBseSB0aGUgb2Zmc2V0IGluCmR3X2hkbWlfd3JpdGVsLgoKPiAgc3RydWN0IGR3X2hk bWkgewo+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgY29ubmVjdG9yOwo+ICAJc3RydWN0IGRybV9l bmNvZGVyICplbmNvZGVyOwo+IEBAIC0xMjEsMjAgKzEyNiw0MyBAQCBzdHJ1Y3QgZHdfaGRtaSB7 Cj4gIAo+ICAJc3RydWN0IHJlZ21hcCAqcmVnbWFwOwo+ICAJc3RydWN0IGkyY19hZGFwdGVyICpk ZGM7Cj4gLQl2b2lkIF9faW9tZW0gKnJlZ3M7Cj4gKwl1bmlvbiBkd19yZWdfcHRyIHJlZ3M7CgpL ZWVwIHRoaXMgYXMgdm9pZCBfX2lvbWVtICoKCj4gIAl1bnNpZ25lZCBpbnQgc2FtcGxlX3JhdGU7 Cj4gIAlpbnQgcmF0aW87Cj4gKwo+ICsJdm9pZCAoKndyaXRlKShzdHJ1Y3QgZHdfaGRtaSAqaGRt aSwgdTggdmFsLCBpbnQgb2Zmc2V0KTsKPiArCXU4ICgqcmVhZCkoc3RydWN0IGR3X2hkbWkgKmhk bWksIGludCBvZmZzZXQpOwo+ICB9Owo+ICAKPiArc3RhdGljIHZvaWQgZHdfaGRtaV93cml0ZWwo c3RydWN0IGR3X2hkbWkgKmhkbWksIHU4IHZhbCwgaW50IG9mZnNldCkKPiArewo+ICsJd3JpdGVs KHZhbCwgaGRtaS0+cmVncy5wMzIgKyBvZmZzZXQpOwoKaGRtaS0+cmVncyArIDQgKiBvZmZzZXQK Cj4gK30KPiArCj4gK3N0YXRpYyB1OCBkd19oZG1pX3JlYWRsKHN0cnVjdCBkd19oZG1pICpoZG1p LCBpbnQgb2Zmc2V0KQo+ICt7Cj4gKwlyZXR1cm4gcmVhZGwoaGRtaS0+cmVncy5wMzIgKyBvZmZz ZXQpOwoKc2FtZSBoZXJlCgo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBkd19oZG1pX3dyaXRlYihz dHJ1Y3QgZHdfaGRtaSAqaGRtaSwgdTggdmFsLCBpbnQgb2Zmc2V0KQo+ICt7Cj4gKwl3cml0ZWIo dmFsLCBoZG1pLT5yZWdzLnA4ICsgb2Zmc2V0KTsKPiArfQo+ICsKPiArc3RhdGljIHU4IGR3X2hk bWlfcmVhZGIoc3RydWN0IGR3X2hkbWkgKmhkbWksIGludCBvZmZzZXQpCj4gK3sKPiArCXJldHVy biByZWFkYihoZG1pLT5yZWdzLnA4ICsgb2Zmc2V0KTsKPiArfQo+ICsKPiAgc3RhdGljIGlubGlu ZSB2b2lkIGhkbWlfd3JpdGViKHN0cnVjdCBkd19oZG1pICpoZG1pLCB1OCB2YWwsIGludCBvZmZz ZXQpCj4gIHsKPiAtCXdyaXRlYih2YWwsIGhkbWktPnJlZ3MgKyBvZmZzZXQpOwo+ICsJaGRtaS0+ d3JpdGUoaGRtaSwgdmFsLCBvZmZzZXQpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW5saW5lIHU4IGhk bWlfcmVhZGIoc3RydWN0IGR3X2hkbWkgKmhkbWksIGludCBvZmZzZXQpCj4gIHsKPiAtCXJldHVy biByZWFkYihoZG1pLT5yZWdzICsgb2Zmc2V0KTsKPiArCXJldHVybiBoZG1pLT5yZWFkKGhkbWks IG9mZnNldCk7Cj4gIH0KPgo+ICBzdGF0aWMgdm9pZCBoZG1pX21vZGIoc3RydWN0IGR3X2hkbWkg KmhkbWksIHU4IGRhdGEsIHU4IG1hc2ssIHVuc2lnbmVkIHJlZykKPiBAQCAtMTUwOCw2ICsxNTM2 LDcgQEAgaW50IGR3X2hkbWlfYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2Ug Km1hc3RlciwKPiAgCXN0cnVjdCBkd19oZG1pICpoZG1pOwo+ICAJc3RydWN0IHJlc291cmNlICpp b3JlczsKPiAgCWludCByZXQsIGlycTsKPiArCXUzMiB2YWwgPSAxOwo+ICAKPiAgCWhkbWkgPSBk ZXZtX2t6YWxsb2MoJnBkZXYtPmRldiwgc2l6ZW9mKCpoZG1pKSwgR0ZQX0tFUk5FTCk7Cj4gIAlp ZiAoIWhkbWkpCj4gQEAgLTE1MjAsNiArMTU0OSwyMiBAQCBpbnQgZHdfaGRtaV9iaW5kKHN0cnVj dCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLAo+ICAJaGRtaS0+cmF0aW8gPSAx MDA7Cj4gIAloZG1pLT5lbmNvZGVyID0gZW5jb2RlcjsKPiAgCj4gKwlvZl9wcm9wZXJ0eV9yZWFk X3UzMihucCwgInJlZy1pby13aWR0aCIsICZ2YWwpOwo+ICsKPiArCXN3aXRjaCAodmFsKSB7Cj4g KwljYXNlIDQ6Cj4gKwkJaGRtaS0+d3JpdGUgPSBkd19oZG1pX3dyaXRlbDsKPiArCQloZG1pLT5y ZWFkID0gZHdfaGRtaV9yZWFkbDsKPiArCQlicmVhazsKPiArCWNhc2UgMToKPiArCQloZG1pLT53 cml0ZSA9IGR3X2hkbWlfd3JpdGViOwo+ICsJCWhkbWktPnJlYWQgPSBkd19oZG1pX3JlYWRiOwo+ ICsJCWJyZWFrOwo+ICsJZGVmYXVsdDoKPiArCQlkZXZfZXJyKGRldiwgInJlZy1pby13aWR0aCBt dXN0IGJlIDEgb3IgNFxuIik7Cj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwl9Cj4gKwo+ICAJZGRj X25vZGUgPSBvZl9wYXJzZV9waGFuZGxlKG5wLCAiZGRjLWkyYy1idXMiLCAwKTsKPiAgCWlmIChk ZGNfbm9kZSkgewo+ICAJCWhkbWktPmRkYyA9IG9mX2ZpbmRfaTJjX2FkYXB0ZXJfYnlfbm9kZShk ZGNfbm9kZSk7Cj4gQEAgLTE1NDQsOSArMTU4OSw5IEBAIGludCBkd19oZG1pX2JpbmQoc3RydWN0 IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsCj4gIAkJcmV0dXJuIHJldDsKPiAg Cj4gIAlpb3JlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwg MCk7Cj4gLQloZG1pLT5yZWdzID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgaW9yZXMpOwo+ IC0JaWYgKElTX0VSUihoZG1pLT5yZWdzKSkKPiAtCQlyZXR1cm4gUFRSX0VSUihoZG1pLT5yZWdz KTsKPiArCWhkbWktPnJlZ3MucDMyID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgaW9yZXMp Owo+ICsJaWYgKElTX0VSUihoZG1pLT5yZWdzLnAzMikpCj4gKwkJcmV0dXJuIFBUUl9FUlIoaGRt aS0+cmVncy5wMzIpOwo+ICAKPiAgCS8qIFByb2R1Y3QgYW5kIHJldmlzaW9uIElEcyAqLwo+ICAJ ZGV2X2luZm8oZGV2LAoKcmVnYXJkcwpQaGlsaXBwCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=