devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Rob Herring <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
	devicetree@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH/RFC 0/4] ARM: shmobile: Correct masks for GIC PPI interrupts
Date: Thu, 27 Nov 2014 11:57:15 +0100	[thread overview]
Message-ID: <1417085839-22836-1-git-send-email-geert+renesas@glider.be> (raw)

	Hi all,

This patch series corrects the masks in the second interrupt cells for
Private Peripheral Interrupts in dtsi files for the shmobile family of
SoCs.

It's my understanding this mask should reflect the actual number of CPU
cores the interrupt is wired too.
Is that correct?

  - Hence it should be "GIC_CPU_MASK_SIMPLE(2)" on dual-core CPUs, like
    r8a7791 and r8a7794 (the first two patches),
  - Should it be "GIC_CPU_MASK_SIMPLE(8)" on big.LITTLE configurations
    with four Cortex-A15 cores and four Cortex-A7 cores?
    Or should the interrupts be delivered to the four Cortex-A15 cores
    only by default?
    The last two RFC-patches implement the former for r8a7790 and
    r8a73a4.

Note that incorrect masks for GIC PPI interrupts are not limited to
shmobile. Presumably the interrupt specifiers got copied around a lot,
cfr. the proliferation of "GIC_CPU_MASK_SIMPLE(4)" (and the older
hardcoded "0xf0x" variant) in various dtsi files, not always limited to
quad-core CPUs.

This was tested on r8a7791/koelsch, which uses the arch timer interrupt.

Thanks for your feedback!

Geert Uytterhoeven (4):
  ARM: shmobile: r8a7791: Correct mask for GIC PPI interrupts
  ARM: shmobile: r8a7794: Correct mask for GIC PPI interrupts
  [RFC] ARM: shmobile: r8a7790: Correct mask for GIC PPI interrupts
  [RFC] ARM: shmobile: r8a73a4: Correct mask for GIC PPI interrupts

 arch/arm/boot/dts/r8a73a4.dtsi | 10 +++++-----
 arch/arm/boot/dts/r8a7790.dtsi | 10 +++++-----
 arch/arm/boot/dts/r8a7791.dtsi | 10 +++++-----
 arch/arm/boot/dts/r8a7794.dtsi | 10 +++++-----
 4 files changed, 20 insertions(+), 20 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2014-11-27 10:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 10:57 Geert Uytterhoeven [this message]
2014-11-27 10:57 ` [PATCH 1/4] ARM: shmobile: r8a7791: Correct mask for GIC PPI interrupts Geert Uytterhoeven
2014-11-27 10:57 ` [PATCH 2/4] ARM: shmobile: r8a7794: " Geert Uytterhoeven
2014-11-27 10:57 ` [PATCH/RFC 3/4] ARM: shmobile: r8a7790: " Geert Uytterhoeven
2014-11-27 10:57 ` [PATCH/RFC 4/4] ARM: shmobile: r8a73a4: " Geert Uytterhoeven
2014-12-08  0:13 ` [PATCH/RFC 0/4] ARM: shmobile: Correct masks " Simon Horman
2014-12-08  8:04   ` Geert Uytterhoeven
2014-12-09  0:29     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417085839-22836-1-git-send-email-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=devicetree@vger.kernel.org \
    --cc=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=marc.zyngier@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).