From: Kevin Cernekee <cernekee@gmail.com>
To: grant.likely@linaro.org
Cc: kbuild-all@01.org, gregkh@linuxfoundation.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] m32r: Add missing big-endian I/O accessors
Date: Thu, 27 Nov 2014 09:46:44 -0800 [thread overview]
Message-ID: <1417110404-13297-2-git-send-email-cernekee@gmail.com> (raw)
In-Reply-To: <1417110404-13297-1-git-send-email-cernekee@gmail.com>
m32r doesn't use GENERIC_IOMAP, and it doesn't currently implement e.g.
ioread32be() on its own. Add definitions to <asm/io.h> to fix build
failures in common drivers that use these functions.
drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_out':
>> drivers/tty/serial/8250/8250_core.c:434:2: error: implicit declaration of function 'iowrite32be' [-Werror=implicit-function-declaration]
iowrite32be(value, p->membase + offset);
^
drivers/tty/serial/8250/8250_core.c: In function 'mem32be_serial_in':
>> drivers/tty/serial/8250/8250_core.c:440:2: error: implicit declaration of function 'ioread32be' [-Werror=implicit-function-declaration]
return ioread32be(p->membase + offset);
^
cc1: some warnings being treated as errors
Compile-tested only.
Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
---
arch/m32r/include/asm/io.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/m32r/include/asm/io.h b/arch/m32r/include/asm/io.h
index 343ae4c..5fb2ad8 100644
--- a/arch/m32r/include/asm/io.h
+++ b/arch/m32r/include/asm/io.h
@@ -4,6 +4,7 @@
#include <linux/string.h>
#include <linux/compiler.h>
#include <asm/page.h> /* __va */
+#include <asm/byteorder.h>
#ifdef __KERNEL__
@@ -169,6 +170,11 @@ static inline void _writel(unsigned long l, unsigned long addr)
#define iowrite16 writew
#define iowrite32 writel
+#define ioread16be(addr) be16_to_cpu(readw(addr))
+#define ioread32be(addr) be32_to_cpu(readl(addr))
+#define iowrite16be(val, addr) writew(cpu_to_be16(val), addr)
+#define iowrite32be(val, addr) writel(cpu_to_be32(val), addr)
+
#define mmiowb()
#define flush_write_buffers() do { } while (0) /* M32R_FIXME */
--
2.1.0
next prev parent reply other threads:[~2014-11-27 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 17:46 [PATCH 1/2] m32r: Fix ioread8 definition Kevin Cernekee
2014-11-27 17:46 ` Kevin Cernekee [this message]
[not found] ` <1417110404-13297-2-git-send-email-cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-27 17:52 ` [PATCH 2/2] m32r: Add missing big-endian I/O accessors Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417110404-13297-2-git-send-email-cernekee@gmail.com \
--to=cernekee@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).