From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Kukjin Kim <kgene@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v4 3/7] regulator: of: Parse ena-gpios property from DTS
Date: Fri, 28 Nov 2014 10:19:56 +0100 [thread overview]
Message-ID: <1417166396.18249.16.camel@AMDC1943> (raw)
In-Reply-To: <20141127184544.GD7712@sirena.org.uk>
On czw, 2014-11-27 at 18:45 +0000, Mark Brown wrote:
> On Thu, Nov 27, 2014 at 12:20:49PM +0100, Krzysztof Kozlowski wrote:
>
> > + constraints->ena_gpio = of_get_named_gpio_flags(np, "ena-gpios", 0,
> > + &gpio_flags);
> > + if (gpio_is_valid(constraints->ena_gpio)) {
>
> No, this isn't sensible - in what way would an enable control GPIO be a
> constraint? The whole reason we have separate constraint and config
> structures is that these are different things. Keep the GPIO setup in
> the configuration.
OK, I'll change it to config.
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-11-28 9:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 11:20 [PATCH v4 0/7] regulator: Parse ena_gpio in core, add GPIO to max77686 Krzysztof Kozlowski
2014-11-27 11:20 ` [PATCH v4 1/7] mfd: max77686/802: Remove support for board files Krzysztof Kozlowski
2014-11-27 13:03 ` Mark Brown
2014-11-27 13:08 ` Krzysztof Kozlowski
2014-11-27 11:20 ` [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property Krzysztof Kozlowski
2014-11-27 18:30 ` Mark Brown
[not found] ` <20141127183058.GB7712-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-11-28 9:09 ` Krzysztof Kozlowski
2014-11-28 11:21 ` Mark Brown
[not found] ` <20141128112116.GG7712-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-11-28 11:54 ` Krzysztof Kozlowski
2014-11-28 14:29 ` Mark Brown
2014-11-27 11:20 ` [PATCH v4 3/7] regulator: of: Parse ena-gpios property from DTS Krzysztof Kozlowski
2014-11-27 18:45 ` Mark Brown
2014-11-28 9:19 ` Krzysztof Kozlowski [this message]
2014-11-27 11:20 ` [PATCH v4 4/7] regulator: Use ena_gpio supplied with generic regulator bindings Krzysztof Kozlowski
2014-11-27 18:43 ` Mark Brown
2014-11-28 10:30 ` Krzysztof Kozlowski
2014-11-28 11:38 ` Mark Brown
2014-11-28 14:14 ` Krzysztof Kozlowski
2014-11-28 15:07 ` Mark Brown
2014-11-27 11:20 ` [PATCH v4 5/7] regulator: max77686: Add GPIO control Krzysztof Kozlowski
2014-11-27 11:20 ` [PATCH v4 6/7] mfd/regulator: dt-bindings: max77686: Document gpio properties Krzysztof Kozlowski
2014-11-27 11:20 ` [PATCH v4 7/7] ARM: dts: exynos4412-trats: Switch max77686 regulators to GPIO control Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417166396.18249.16.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).