devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/panel: Add support for Giantplus GPG482739QS5 panel
Date: Mon, 01 Dec 2014 12:07:38 +0100	[thread overview]
Message-ID: <1417432058.2391.1.camel@pengutronix.de> (raw)
In-Reply-To: <1416389395-15152-2-git-send-email-l.stach@pengutronix.de>

Hi Thierry,

just a gentle ping for those 2 patches. It would be nice if you could
pick them up, so they can go into the next mergewindow.

Regards,
Lucas

Am Mittwoch, den 19.11.2014, 10:29 +0100 schrieb Lucas Stach:
> From: Philipp Zabel <philipp.zabel@gmail.com>
> 
> This patch adds support for the GiantPlus GPG48273QS5 4.3" WQVGA TFT LCD panel
> to the simple-panel driver.
> 
> This panel is connected via a parallel bus and uses both HSYNC and VSYNC,
> whose lengths are unfortunately not clearly defined. The datasheet only
> specifies the front- and backporch length, but the timing diagram suggests
> that both sync signals should be asserted for exactly one clock cycle.
> 
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> [lst]: rebased on top of drm/panel/for-next + added commit message
> ---
>  .../bindings/panel/giantplus,gpg482739qs5.txt      |  7 ++++++
>  drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++++++++++
>  2 files changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/panel/giantplus,gpg482739qs5.txt
> 
> diff --git a/Documentation/devicetree/bindings/panel/giantplus,gpg482739qs5.txt b/Documentation/devicetree/bindings/panel/giantplus,gpg482739qs5.txt
> new file mode 100644
> index 000000000000..24b0b624434b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/panel/giantplus,gpg482739qs5.txt
> @@ -0,0 +1,7 @@
> +GiantPlus GPG48273QS5 4.3" (480x272) WQVGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "giantplus,gpg48273qs5"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index c4b6167a8bf3..1d8ed2062841 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -560,6 +560,29 @@ static const struct panel_desc foxlink_fl500wvr00_a0t = {
>  	},
>  };
>  
> +static const struct drm_display_mode giantplus_gpg482739qs5_mode = {
> +	.clock = 9000,
> +	.hdisplay = 480,
> +	.hsync_start = 480 + 5,
> +	.hsync_end = 480 + 5 + 1,
> +	.htotal = 480 + 5 + 1 + 40,
> +	.vdisplay = 272,
> +	.vsync_start = 272 + 8,
> +	.vsync_end = 272 + 8 + 1,
> +	.vtotal = 272 + 8 + 1 + 8,
> +	.vrefresh = 60,
> +};
> +
> +static const struct panel_desc giantplus_gpg482739qs5 = {
> +	.modes = &giantplus_gpg482739qs5_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 95,
> +		.height = 54,
> +	},
> +};
> +
>  static const struct drm_display_mode hannstar_hsd070pww1_mode = {
>  	.clock = 71100,
>  	.hdisplay = 1280,
> @@ -757,6 +780,9 @@ static const struct of_device_id platform_of_match[] = {
>  		.compatible = "foxlink,fl500wvr00-a0t",
>  		.data = &foxlink_fl500wvr00_a0t,
>  	}, {
> +		.compatible = "giantplus,gpg482739qs5",
> +		.data = &giantplus_gpg482739qs5
> +	}, {
>  		.compatible = "hannstar,hsd070pww1",
>  		.data = &hannstar_hsd070pww1,
>  	}, {

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-12-01 11:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19  9:29 [PATCH 1/2] of: Add vendor prefix for Giantplus Technology Co., Ltd Lucas Stach
2014-11-19  9:29 ` [PATCH 2/2] drm/panel: Add support for Giantplus GPG482739QS5 panel Lucas Stach
2014-12-01 11:07   ` Lucas Stach [this message]
2014-12-04 13:16     ` Thierry Reding
     [not found] ` <1416389395-15152-1-git-send-email-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-11-19 14:50   ` [PATCH 1/2] of: Add vendor prefix for Giantplus Technology Co., Ltd Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417432058.2391.1.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).