From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yingjoe Chen Subject: Re: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support Date: Mon, 1 Dec 2014 22:09:33 +0800 Message-ID: <1417442973.24330.6.camel@mtksdaap41> References: <1416902662-19281-1-git-send-email-yingjoe.chen@mediatek.com> <1416902662-19281-3-git-send-email-yingjoe.chen@mediatek.com> <20141129174030.GA4696@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141129174030.GA4696-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Beniamino Galvani Cc: Mark Rutland , Jason Cooper , Thomas Gleixner , Jiang Liu , Marc Zyngier , Boris BREZILLON , Bjorn Helgaas , Russell King , Pawel Moll , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hc.yen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yijing Wang , Rob Herring , Matthias Brugger , nathan.chung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Sascha Hauer , Grant Likely , eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, yingjoe.chen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sat, 2014-11-29 at 18:40 +0100, Beniamino Galvani wrote: > On Tue, Nov 25, 2014 at 04:04:20PM +0800, Yingjoe Chen wrote: > > Mediatek SoCs have interrupt polarity support in sysirq which > > allows to invert polarity for given interrupt. Add this support > > using hierarchy irq domain. > > > > [...] > > > > +static int __init mtk_sysirq_of_init(struct device_node *node, > > + struct device_node *parent) > > +{ > > + struct irq_domain *domain, *domain_parent; > > + struct mtk_sysirq_chip_data *chip_data; > > + int ret = 0; > > + > > + domain_parent = irq_find_host(parent); > > + if (!domain_parent) { > > + pr_err("mtk_sysirq: interrupt-parent not found\n"); > > + return -EINVAL; > > + } > > + > > + chip_data = kzalloc(sizeof(*chip_data), GFP_KERNEL); > > + if (!chip_data) > > + return -ENOMEM; > > + > > + chip_data->intpol_base = of_io_request_and_map(node, 0, "intpol"); > > + if (!chip_data->intpol_base) { > > Hi, > > you should use IS_ERR() to check the return value here. Thanks for catching this. I think this is merged, so I'll prepare a new patch to fix this. Joe.C -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html