From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: [PATCH v3 3/3] ARM: dts: exynos5420: Add clock for audss pinctrl (fixing GPIO setup failure) Date: Thu, 04 Dec 2014 11:47:55 +0100 Message-ID: <1417690075-13483-4-git-send-email-k.kozlowski@samsung.com> References: <1417690075-13483-1-git-send-email-k.kozlowski@samsung.com> Return-path: In-reply-to: <1417690075-13483-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mike Turquette , Sylwester Nawrocki , Tomasz Figa , Kukjin Kim , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Javier Martinez Canillas , Linus Walleij , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vivek Gautam , Kevin Hilman Cc: Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski List-Id: devicetree@vger.kernel.org The pinctrl for audio subsystem needs 'mau_epll' clock to be enabled in order to properly access memory during GPIO setup. After introducing runtime PM to pl330 DMA driver the 'mau_epll' was gated, because the "amba" clock was disabled and there were no more users of mau_epll. This lead to system hang just before probing i2s0 because samsung_pinmux_setup() tried to access memory from audss block which was gated. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi index ba686e40eac7..c0ca0da36ade 100644 --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi @@ -696,6 +696,9 @@ }; pinctrl@03860000 { + clocks = <&clock CLK_MAU_EPLL>; + clock-names = "block"; + gpz: gpz { gpio-controller; #gpio-cells = <2>; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html