devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: at91/dt: sam9263: Fix typo: ac91_clk -> ac97_clk
@ 2014-12-05 14:16 Alexander Stein
  2014-12-05 14:16 ` [PATCH 2/2] ARM: at91/dt: sam9263: Add missing clocks to ac97 node Alexander Stein
       [not found] ` <1417789016-20001-1-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
  0 siblings, 2 replies; 5+ messages in thread
From: Alexander Stein @ 2014-12-05 14:16 UTC (permalink / raw)
  To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Nicolas Ferre
  Cc: Alexander Stein, Russell King,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

That clock should be called ac97_clk.

Signed-off-by: Alexander Stein <alexanders83-S0/GAf8tV78@public.gmane.org>
---
 arch/arm/boot/dts/at91sam9263.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
index 7989756..5ed2810 100644
--- a/arch/arm/boot/dts/at91sam9263.dtsi
+++ b/arch/arm/boot/dts/at91sam9263.dtsi
@@ -294,7 +294,7 @@
 						reg = <17>;
 					};
 
-					ac91_clk: ac97_clk {
+					ac97_clk: ac97_clk {
 						#clock-cells = <0>;
 						reg = <18>;
 					};
-- 
2.2.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: at91/dt: sam9263: Add missing clocks to ac97 node
  2014-12-05 14:16 [PATCH 1/2] ARM: at91/dt: sam9263: Fix typo: ac91_clk -> ac97_clk Alexander Stein
@ 2014-12-05 14:16 ` Alexander Stein
       [not found]   ` <1417789016-20001-2-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
       [not found] ` <1417789016-20001-1-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
  1 sibling, 1 reply; 5+ messages in thread
From: Alexander Stein @ 2014-12-05 14:16 UTC (permalink / raw)
  To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Nicolas Ferre
  Cc: Alexander Stein, devicetree, Russell King, linux-arm-kernel

The clock node specifying 'ac97_clk' was missing.

Signed-off-by: Alexander Stein <alexanders83@web.de>
---
 arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
index 5ed2810..2d9d0ad 100644
--- a/arch/arm/boot/dts/at91sam9263.dtsi
+++ b/arch/arm/boot/dts/at91sam9263.dtsi
@@ -821,6 +821,8 @@
 				interrupts = <18 IRQ_TYPE_LEVEL_HIGH 5>;
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_ac97>;
+				clocks = <&ac97_clk>;
+				clock-names = "ac97_clk";
 				status = "disabled";
 			};
 
-- 
2.2.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: at91/dt: sam9263: Fix typo: ac91_clk -> ac97_clk
       [not found] ` <1417789016-20001-1-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
@ 2014-12-05 15:00   ` Alexander Stein
  2014-12-10 10:04     ` Nicolas Ferre
  0 siblings, 1 reply; 5+ messages in thread
From: Alexander Stein @ 2014-12-05 15:00 UTC (permalink / raw)
  To: Rob Herring
  Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Nicolas Ferre,
	Russell King, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Friday 05 December 2014, 15:16:55 wrote Alexander Stein:
> That clock should be called ac97_clk.
> 
> Signed-off-by: Alexander Stein <alexanders83-S0/GAf8tV78@public.gmane.org>
> ---
>  arch/arm/boot/dts/at91sam9263.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
> index 7989756..5ed2810 100644
> --- a/arch/arm/boot/dts/at91sam9263.dtsi
> +++ b/arch/arm/boot/dts/at91sam9263.dtsi
> @@ -294,7 +294,7 @@
>  						reg = <17>;
>  					};
>  
> -					ac91_clk: ac97_clk {
> +					ac97_clk: ac97_clk {
>  						#clock-cells = <0>;
>  						reg = <18>;
>  					};
> 

Please ignore those 2 patches for now. I made a mistake during local rebase.

Best regards,
Alexander
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: at91/dt: sam9263: Fix typo: ac91_clk -> ac97_clk
  2014-12-05 15:00   ` [PATCH 1/2] ARM: at91/dt: sam9263: Fix typo: ac91_clk -> ac97_clk Alexander Stein
@ 2014-12-10 10:04     ` Nicolas Ferre
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2014-12-10 10:04 UTC (permalink / raw)
  To: Alexander Stein, Rob Herring
  Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

Le 05/12/2014 16:00, Alexander Stein a écrit :
> On Friday 05 December 2014, 15:16:55 wrote Alexander Stein:
>> That clock should be called ac97_clk.
>>
>> Signed-off-by: Alexander Stein <alexanders83-S0/GAf8tV78@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/at91sam9263.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
>> index 7989756..5ed2810 100644
>> --- a/arch/arm/boot/dts/at91sam9263.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9263.dtsi
>> @@ -294,7 +294,7 @@
>>  						reg = <17>;
>>  					};
>>  
>> -					ac91_clk: ac97_clk {
>> +					ac97_clk: ac97_clk {
>>  						#clock-cells = <0>;
>>  						reg = <18>;
>>  					};
>>
> 
> Please ignore those 2 patches for now. I made a mistake during local rebase.

Well at least this one (1/2) is valid and applies on my new
at91-3.20-dt. So I take it for now: tell me if you feel otherwise.

Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

Bye,


> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] ARM: at91/dt: sam9263: Add missing clocks to ac97 node
       [not found]   ` <1417789016-20001-2-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
@ 2014-12-10 10:05     ` Nicolas Ferre
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2014-12-10 10:05 UTC (permalink / raw)
  To: Alexander Stein, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala
  Cc: Russell King, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

Le 05/12/2014 15:16, Alexander Stein a écrit :
> The clock node specifying 'ac97_clk' was missing.
> 
> Signed-off-by: Alexander Stein <alexanders83-S0/GAf8tV78@public.gmane.org>
> ---
>  arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
> index 5ed2810..2d9d0ad 100644
> --- a/arch/arm/boot/dts/at91sam9263.dtsi
> +++ b/arch/arm/boot/dts/at91sam9263.dtsi
> @@ -821,6 +821,8 @@
>  				interrupts = <18 IRQ_TYPE_LEVEL_HIGH 5>;
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&pinctrl_ac97>;
> +				clocks = <&ac97_clk>;
> +				clock-names = "ac97_clk";
>  				status = "disabled";
>  			};

I see, this one comes after the addition of the node itself. I ignore it.

Bye,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-12-10 10:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-05 14:16 [PATCH 1/2] ARM: at91/dt: sam9263: Fix typo: ac91_clk -> ac97_clk Alexander Stein
2014-12-05 14:16 ` [PATCH 2/2] ARM: at91/dt: sam9263: Add missing clocks to ac97 node Alexander Stein
     [not found]   ` <1417789016-20001-2-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
2014-12-10 10:05     ` Nicolas Ferre
     [not found] ` <1417789016-20001-1-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
2014-12-05 15:00   ` [PATCH 1/2] ARM: at91/dt: sam9263: Fix typo: ac91_clk -> ac97_clk Alexander Stein
2014-12-10 10:04     ` Nicolas Ferre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).