* [PATCH] i2c: designware: Fix falling time bindings doc @ 2014-12-05 18:49 Doug Anderson [not found] ` <1417805379-8999-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Doug Anderson @ 2014-12-05 18:49 UTC (permalink / raw) To: Romain Baeriswyl, Wolfram Sang, Shinya Kuribayashi Cc: Christian Ruppert, Addy Ke, Doug Anderson, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, linux-kernel In (6468276 i2c: designware: make SCL and SDA falling time configurable) new device tree properties were added for setting the falling time of SDA and SCL. The device tree bindings doc had a typo in it: it forgot the "-ns" suffix for both properies in the prose of the bindings. I assume this is a typo because: * The source code includes the "-ns" * The example in the bindings includes the "-ns". Fix the typo. Signed-off-by: Doug Anderson <dianders@chromium.org> Fixes: 6468276b2206 ("i2c: designware: make SCL and SDA falling time configurable") --- Documentation/devicetree/bindings/i2c/i2c-designware.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt index 5199b0c..fee26dc 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt @@ -14,10 +14,10 @@ Optional properties : - i2c-sda-hold-time-ns : should contain the SDA hold time in nanoseconds. This option is only supported in hardware blocks version 1.11a or newer. - - i2c-scl-falling-time : should contain the SCL falling time in nanoseconds. + - i2c-scl-falling-time-ns : should contain the SCL falling time in nanoseconds. This value which is by default 300ns is used to compute the tLOW period. - - i2c-sda-falling-time : should contain the SDA falling time in nanoseconds. + - i2c-sda-falling-time-ns : should contain the SDA falling time in nanoseconds. This value which is by default 300ns is used to compute the tHIGH period. Example : -- 2.2.0.rc0.207.ga3a616c ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1417805379-8999-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>]
* Re: [PATCH] i2c: designware: Fix falling time bindings doc [not found] ` <1417805379-8999-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> @ 2014-12-08 8:57 ` Romain Baeriswyl 2014-12-08 9:51 ` Wolfram Sang 1 sibling, 0 replies; 3+ messages in thread From: Romain Baeriswyl @ 2014-12-08 8:57 UTC (permalink / raw) To: Doug Anderson, Romain Baeriswyl, Wolfram Sang, Shinya Kuribayashi Cc: Christian Ruppert, Addy Ke, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Acked-by: Romain Baeriswyl <romain.baeriswyl-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org> On 2014-12-05 19:49, Doug Anderson wrote: > In (6468276 i2c: designware: make SCL and SDA falling time > configurable) new device tree properties were added for setting the > falling time of SDA and SCL. The device tree bindings doc had a typo > in it: it forgot the "-ns" suffix for both properies in the prose of > the bindings. > > I assume this is a typo because: > * The source code includes the "-ns" > * The example in the bindings includes the "-ns". > > Fix the typo. > > Signed-off-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> > Fixes: 6468276b2206 ("i2c: designware: make SCL and SDA falling time configurable") > --- > Documentation/devicetree/bindings/i2c/i2c-designware.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > index 5199b0c..fee26dc 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > @@ -14,10 +14,10 @@ Optional properties : > - i2c-sda-hold-time-ns : should contain the SDA hold time in nanoseconds. > This option is only supported in hardware blocks version 1.11a or newer. > > - - i2c-scl-falling-time : should contain the SCL falling time in nanoseconds. > + - i2c-scl-falling-time-ns : should contain the SCL falling time in nanoseconds. > This value which is by default 300ns is used to compute the tLOW period. > > - - i2c-sda-falling-time : should contain the SDA falling time in nanoseconds. > + - i2c-sda-falling-time-ns : should contain the SDA falling time in nanoseconds. > This value which is by default 300ns is used to compute the tHIGH period. > > Example : > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: designware: Fix falling time bindings doc [not found] ` <1417805379-8999-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2014-12-08 8:57 ` Romain Baeriswyl @ 2014-12-08 9:51 ` Wolfram Sang 1 sibling, 0 replies; 3+ messages in thread From: Wolfram Sang @ 2014-12-08 9:51 UTC (permalink / raw) To: Doug Anderson Cc: Romain Baeriswyl, Shinya Kuribayashi, Christian Ruppert, Addy Ke, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 738 bytes --] On Fri, Dec 05, 2014 at 10:49:39AM -0800, Doug Anderson wrote: > In (6468276 i2c: designware: make SCL and SDA falling time > configurable) new device tree properties were added for setting the > falling time of SDA and SCL. The device tree bindings doc had a typo > in it: it forgot the "-ns" suffix for both properies in the prose of > the bindings. > > I assume this is a typo because: > * The source code includes the "-ns" > * The example in the bindings includes the "-ns". > > Fix the typo. > > Signed-off-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> > Fixes: 6468276b2206 ("i2c: designware: make SCL and SDA falling time configurable") Applied to for-next and added stable, thanks! [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-08 9:51 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-12-05 18:49 [PATCH] i2c: designware: Fix falling time bindings doc Doug Anderson [not found] ` <1417805379-8999-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2014-12-08 8:57 ` Romain Baeriswyl 2014-12-08 9:51 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).